Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F532C433FE for ; Mon, 10 Oct 2022 06:49:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=L89q81ZR7g7Joe9keuI6nFtQ7UxGEAYfTxJ+bU4T5iM=; b=AiCDCNYfrzT8CA 8KBYsKYyjacDWwslSq5l6a45yEOGd17hPHvpGWUIcjff/m1VFKxTR+ntnALycp+coBgHZBlUtz+3O Kq/ybpsk6NcwcmbZsVjB0aP5tKeKpO0JmsSK0SPsTSBWMcHTshoZOWzHqnVRepBKmFhSN+W1VGzD9 LMBDEwcNSl/CEwnR64EldjRPuvWYUWnGtlLJRx4uwfiGoh8TMNZqiTt4NBDyd+YlWFlofJaTInHlK DOE3zzrqIp6fKCHByJaeMvVjyXuEo2vhBCIz1veQnkBhshLTJDjTYCm5PNwasfQ3E+PTDrVWRhS30 ybarG/s9T2sTIz47vhjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ohma7-00HH7s-ST; Mon, 10 Oct 2022 06:48:07 +0000 Received: from mga11.intel.com ([192.55.52.93]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ohma4-00HH7I-RN for linux-arm-kernel@lists.infradead.org; Mon, 10 Oct 2022 06:48:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665384484; x=1696920484; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=tpV8I20bPwnleIgRuVNbiXE++yFty8pyBbknzN9MNnw=; b=K/t+7wFwdtjzJazZTUb6EZ7AUEEM6M+bhzpFlB35kN8yAqrB5SS4xAs0 XriYTwmKjq5g7wwRDSZgt344/mGXl1yOMs0UoX2wfbmtFcU+YzWFjdAs1 m/cWtQoSYNKE/1nqEOlZCqDBQ77jaxd9N09QKl5yiIUDUq9VSVgyAPqVA DxCovMrpqJKTy97nYVG0q9fblgM5Qy0pjA6kZZOdNFwf5p0S9u+K62IxB JDGJyGobj+SCPU88KHV1wh6l1Ajem6fbWsW81ZChhF7LFGCRQNapCy6gY Ps2i9fR2u1fUnDCIUUwwQUzW+vDFOrR5v8vvU9FBjk2F4lwUSzysVpW0R w==; X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="301766012" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="301766012" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2022 23:48:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="625869133" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="625869133" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga002.jf.intel.com with ESMTP; 09 Oct 2022 23:47:58 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1ohmZx-004kth-0l; Mon, 10 Oct 2022 09:47:57 +0300 Date: Mon, 10 Oct 2022 09:47:56 +0300 From: Andy Shevchenko To: Dmitry Torokhov Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Patrice Chotard , Linus Walleij Subject: Re: [PATCH v1 1/1] pinctrl: st: Avoid using of_node member of struct gpio_chip Message-ID: References: <20221004125449.67679-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221009_234804_977893_D7DBDB83 X-CRM114-Status: GOOD ( 21.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Oct 09, 2022 at 11:13:44PM -0700, Dmitry Torokhov wrote: > On Tue, Oct 04, 2022 at 03:54:49PM +0300, Andy Shevchenko wrote: > > The of_node member of the struct gpio_chip is obsoleted and > > shouldn't be used. It will be removed in the future. > > > > Replace its use in st_pctl_dt_calculate_pin() by comparing > > the fwnode pointers. > > > > Fixes: e75729b2f63f ("pinctrl: st: stop abusing of_get_named_gpio()") ... > Are you sure chip's fwnode is properly set here (without your other > patch)? I don't believe the driver sets it up, and I don't think gpiolib > maps it from the gpio_chip->of_node. > > Actually, there is another reference to of_node in gpio chip in > st_gpiolib_register_bank()... You are right, this patch has been made on top of another not yet published one. Hence, nothing to fix it right now. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel