Date: Mon, 10 Oct 2022 18:29:26 +0200 From: Frank Lichtenheld Message-ID: References: <20221010154116.1685877-1-arne@...1227...> <20221010155515.1687151-1-arne@...1227...> MIME-Version: 1.0 In-Reply-To: <20221010155515.1687151-1-arne@...1227...> Subject: Re: [Openvpn-devel] [PATCH v2] Ensure only CBC, CFB, OFB and AEAD ciphers are considered valid data ciphers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit Content-Disposition: inline To: Arne Schwabe Cc: openvpn-devel@lists.sourceforge.net On Mon, Oct 10, 2022 at 05:55:15PM +0200, Arne Schwabe wrote: > Make sure cipher_valid only considered these four operations as valid. "considers" > This fixes that somjething like --data-ciphers AES-256-GCM:AES-128-CCM "something" > will start but later fail when trying to use the CCM cipher. > > We say "a supported AEAD" mode in our error since CCM is also an AEAD mode > but one we support like GCM. "but not one we support, like GCM" or "but one we don't support, unlike GCM" Actual code looks good to me, so Acked-by: Frank Lichtenheld Regards, -- Frank Lichtenheld