Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC4AAC38A02 for ; Sun, 30 Oct 2022 21:05:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 094B310E03D; Sun, 30 Oct 2022 21:05:03 +0000 (UTC) X-Greylist: delayed 963 seconds by postgrey-1.36 at gabe; Sun, 30 Oct 2022 21:05:00 UTC Received: from mailrelay4-2.pub.mailoutpod1-cph3.one.com (mailrelay4-2.pub.mailoutpod1-cph3.one.com [46.30.212.3]) by gabe.freedesktop.org (Postfix) with ESMTPS id DBC1710E03D for ; Sun, 30 Oct 2022 21:05:00 +0000 (UTC) Received: from mailrelay1.pub.mailoutpod2-cph3.one.com (mailrelay1.pub.mailoutpod2-cph3.one.com [104.37.34.6]) by mailrelay4.pub.mailoutpod1-cph3.one.com (Halon) with ESMTPS id 44d1a8b6-5894-11ed-824f-d0431ea8bb10; Sun, 30 Oct 2022 20:48:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa2; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=57sc1zEaPoN7h4A46eYO7m7OBIbwdsJSNErw2oMh2i8=; b=ExNOMhkVFJztTvZcxnvH3h4fqJbsQkgg+bLEfOuaDMvE1gWzf+x03ZVf9gCp8uwhCeU2x+q6nekWi UMfVN39ir3tiH2OPaGvcsXRDQvpmQKHK3UuTp6v916Hd3c9eu8BAnGCKfFv5bGKDF/P9k9eqMzKaz3 YyNUCgEBiiyaZe6hupo2tczx7/snZxgERFISe14rqGEF3MLSehcW6uFvCTvTCzATO0Oq2qKub0zu+2 134gYtd6AYTmNhA/UKp4zhT678Ud601D0/AsB+uxyLjz/ajF3SKPi0XNAMhnCQdcLYMKT3t0b+QQDh m5xZYu4P+05A45nJ0qf/BSXWMKcZ1Sw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed2; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=57sc1zEaPoN7h4A46eYO7m7OBIbwdsJSNErw2oMh2i8=; b=tZrknHN/AT+yPRxITfnWcQoHnGW6VCifdzIareCpE0Xor8DK2nixpgY3yVhJk7aPL6M6bl/Bkor4y vmrkmxMDQ== X-HalOne-ID: 43a73db0-5894-11ed-bedf-1b2345786432 Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay1 (Halon) with ESMTPSA id 43a73db0-5894-11ed-bedf-1b2345786432; Sun, 30 Oct 2022 20:48:54 +0000 (UTC) Date: Sun, 30 Oct 2022 21:48:53 +0100 From: Sam Ravnborg To: antoniospg Message-ID: References: <20221029184851.25340-1-antoniospg100@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221029184851.25340-1-antoniospg100@gmail.com> Subject: Re: [Nouveau] [PATCH] drm/nouveau: Adding support to control backlight using bl_power for nva3. X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" , linux-kernel@vger.kernel.org, "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" , Ben Skeggs Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Sat, Oct 29, 2022 at 03:48:50PM -0300, antoniospg wrote: > Test plan: > > * Turn off: > echo 1 > /sys/class/backlight/nv_backlight/bl_power > > * Turn on: > echo 0 > /sys/class/backlight/nv_backlight/bl_power > > Signed-off-by: antoniospg > --- > drivers/gpu/drm/nouveau/nouveau_backlight.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c b/drivers/gpu/drm/nouveau/nouveau_backlight.c > index a2141d3d9b1d..855d0ce9f7fa 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_backlight.c > +++ b/drivers/gpu/drm/nouveau/nouveau_backlight.c > @@ -263,7 +263,16 @@ nva3_set_intensity(struct backlight_device *bd) > u32 div, val; > > div = nvif_rd32(device, NV50_PDISP_SOR_PWM_DIV(or)); > - val = (bd->props.brightness * div) / 100; > + > + switch (bd->props.power) { > + case FB_BLANK_UNBLANK: > + val = (bd->props.brightness * div) / 100; > + break; > + default: > + val = 0; > + break; > + } > + Consider the following change: val = backlight_get_brightness(bd); if (val) val = (val * dev) / 100; Then you avoid hard coding the use of FB_BLANK_UNBLANK. Sam