Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F215BC4332F for ; Thu, 20 Oct 2022 13:29:57 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.426807.675502 (Exim 4.92) (envelope-from ) id 1olVcK-0006PR-81; Thu, 20 Oct 2022 13:29:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 426807.675502; Thu, 20 Oct 2022 13:29:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1olVcK-0006PK-5N; Thu, 20 Oct 2022 13:29:48 +0000 Received: by outflank-mailman (input) for mailman id 426807; Thu, 20 Oct 2022 13:29:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1olVcJ-0006PC-A6 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 13:29:47 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 428d2189-507b-11ed-91b5-6bf2151ebd3b; Thu, 20 Oct 2022 15:29:46 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 428d2189-507b-11ed-91b5-6bf2151ebd3b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1666272585; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=aWOjyxBt9oAQgjedR8p8FAX5XibGH38ijrGq3nkJQDw=; b=gcoWQBP4JFdpWSlx8TJcTbeYhXUe9bFUmI9kU9tb4XVxw+EltjRBFCDY XAcVetSQukLYzhyWEPdIgwfp5sq1+njW0iSMLK/HAfxf5QX7y+/xUBTXj j9MYmILinHmlYVzpIV2dMSS2+6G81R5ltd2SreSc+PntXzI/jXozh2M0t I=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 82266859 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:nTWSJqJypPJKabWpFE+R25UlxSXFcZb7ZxGr2PjKsXjdYENShGMDz mEYW2yFafuPMWKhL9sjaozko00Ov8XcydNqG1ZlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo rsemeWGULOe82MyYz98B56r8ks15q2q4mtA5zTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/ /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FbBJqr8sOX0Vy fAVIhYVdjCJrMHx/K3uH4GAhux7RCXqFIYWu3UmxjDFF/c2B5vERs0m5/cBgm123JoXW6+DO YxJMlKDbzyZC/FLEl4RFJI5mvbunnTleidUgFmUubA28y7YywkZPL3FYICPJILaGJQ9ckCwm D3q2E32XU8hOvuH4Aqn8layrN7+gnauMG4VPOLhraM76LGJ/UQMDDUGWF39puO24mauVtQaJ 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4O8037hucjJXd5QmxD3IBCDVGbbQbWNQeHGJwk AXTxpWwWGIp4Ob9pW+hGqm8kGLiYHMtMTQ+aSIOaxMdw9PIg8YPkUeaJjp8K5KdgtrwEDD25 jmFqikimrke5fI2O7WHEUPv2Gz1+MWQJuIhzkCOBz/+sFslDGKwT9bwgWU3+8qsO2pworOpm HEf0/aT4+kVZX1mvHzcGb5ddF1FChvsDdE9vbKNN8N8n9hO0yT5FWy13N2ZDB4wWvvogRezP CfuVfp5vfe/xkeCY65teJ6WAM8316XmHtmNfqmKMIQXO8gtKFHcoXsGiausM4fFyRJErE3CE c3DLZbE4YgyU8yLMwZat89CiOR2l0jSNEvYRIzhzgTP7IdykEW9EO9fWHPXN7hRxPrd/G3oH yN3apLiJ+N3C7alPEE6MOc7cDg3EJTMLcqv+p0GKLHfflcO9aNII6a5/I7NsrdNx8x9/tokN FnkBie0FHKXaaX7FDi3 IronPort-HdrOrdr: A9a23:CrMQxKw5+qOGSYH2n7uHKrPwKr1zdoMgy1knxilNoRw8SKKlfu SV7ZAmPHjP+VEssRAb6LW90ca7LE80maQY3WBVB8bFYOCEghrLEGgB1+vfKlTbckWUnNK1l5 0QEJSWYOeAdGSS5vya3ODXKbkd/OU= X-IronPort-AV: E=Sophos;i="5.95,198,1661832000"; d="scan'208";a="82266859" Date: Thu, 20 Oct 2022 14:29:36 +0100 From: Anthony PERARD To: Henry Wang CC: Roger Pau Monne , "xen-devel@lists.xenproject.org" , Wei Liu , Andrew Cooper Subject: Re: [PATCH for-4.17?] test/vpci: enable by default Message-ID: References: <20221020102706.29267-1-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Oct 20, 2022 at 10:30:26AM +0000, Henry Wang wrote: > Hi Roger, > > > -----Original Message----- > > From: Roger Pau Monne > > Subject: [PATCH for-4.17?] test/vpci: enable by default > > > > CONFIG_HAS_PCI is not defined for the tools build, and as a result the > > vpci harness would never get build. Fix this by building it > > unconditionally, there's nothing arch specific in it. > > > > Reported-by: Andrew Cooper > > Signed-off-by: Roger Pau Monné > > --- > > While not strictly a bugfix, I think it's worth adding this change to the > > release in order to always build the vpci test hardness and prevent it > > from bitrotting. > > Good point. > > No problem from my side, but I think you need also Anthony's opinion > as he is the toolstack maintainer. This sounds fine to me, the risk is that the build could fail. But we can easily revert the patch and reapply it at the next development cycle. Acked-by: Anthony PERARD Thanks, -- Anthony PERARD