Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1olsSy-0001EM-PD for mharc-grub-devel@gnu.org; Fri, 21 Oct 2022 09:53:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olsSx-0001EE-Qq for grub-devel@gnu.org; Fri, 21 Oct 2022 09:53:39 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olsSv-0004sm-V2 for grub-devel@gnu.org; Fri, 21 Oct 2022 09:53:39 -0400 Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29LD4Lfw030900; Fri, 21 Oct 2022 13:53:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2022-7-12; bh=27LAnJbFTXn/2eiStzH2SM2Qx/iXHJOH7Ts3F70gXV0=; b=1+u1Knm4ksXmj0sGZdTXRoaGUvxwuVr9jpak8Dlv9N/4+FTuPOq0kGL6TdwD39PB1url GNG+4L/CE0Joj5jw1YKviuGXehvnXqJdf5Tqj6TAKKO+7iq+hS3iCJP+O5g+d1GKhx9w w32ReNxdNdNhUWHzQaHJeWyrFIMTauDsKkEYozhl3mdH8HsGyKbQeS8qy+dmFFodVlnS ZBX5fcd4Nv7OsIOwxEOzwQZWgDoXojgmjUrg2gb6Zzu9cK2FJJn7PQfJl5neUrZKt3Vy p4K7Dna6/3sTycnL1Gx4ffBJAbJa5D8J3n2A5sY0j2MMNGbIHWd6rEnNG+PHeEprZ28s rA== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3k7mu08h78-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 21 Oct 2022 13:53:32 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 29LCAreu007219; Fri, 21 Oct 2022 13:53:32 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2045.outbound.protection.outlook.com [104.47.66.45]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3k8hrdv61f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 21 Oct 2022 13:53:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AxrbPkO92c3NBSt+L+9AXWBanUm2lX5n84V9fdNBJYPWD0JDw+DwoWN4oUjQ6zK6u4E+KSeWHtU7kKFZJbFsCfjGgWzSnDwSmn5FWnCX7mIc9BUYDT7rnU1HEllaoQr0DtrwTeHRMvHuO6P4mBBGhDFb6xebXKqz3m2ZbmxvnLuTHIRwe4agZF8NPkFykB+MEHFOjC4PxHuWLwt19OEH3Tq4z3IKBb6nX5xHRm6upt3uTcL0DLHiV4ZKgZM+FLYE6mZdZ6LlLJOE2WxyK2ZsHzlQHJMk1KSB7sI8llUUI4n0Wtktq5Vhvg6WNxQd3hvH3AuO3vfIPgu6QTOBndJoIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=27LAnJbFTXn/2eiStzH2SM2Qx/iXHJOH7Ts3F70gXV0=; b=oXZFxWurskAMDnpirHZLsjTtptaf4AfQ10aH/jAvjKRloyrGn4gdypRE2WAl4eT5TT3mtBZdJzsd0p0KjFGJ0k5VL/BjFpbY4Z9pDwptyOlcA7vvTCu/ILlnFLuTz+hkwK8Jq13PxmqZ7tXjW0XB4avoxL9XV5GLSq7c/3cvowsFdIxO/RDG6+7RjIhCIHJRGuRs+78s3ZVDKVbPZ0EeJVQLnZSDdOVe8WlQQzD1nZ4WmYP0iCSLxbgDMsSV3KNUiQzKNPOQKtyyB/RolTvSLpSIOahy7xnXMDuh2DPNzh18TjUDVYg6U2LoAiDSIiOr3Rabh3FLC8l+2Cqh/GC5mQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=27LAnJbFTXn/2eiStzH2SM2Qx/iXHJOH7Ts3F70gXV0=; b=QGNH+kwVfJ92/JJVyYE5fXVrLV/C9M9l6AFmp/00PglGWOdAd/i5ejZGqsL854459COEuIPfaGwlZ3L24X0gJIaiZNjvnUOgDJwtmY/KgbRpwKA4dnyyetvwRPou9TkJFl2By9yMjz3uOiXa36Q+jDGn1Nv1Vq4IwYfMKDvWD/o= Received: from BN0PR10MB4822.namprd10.prod.outlook.com (2603:10b6:408:124::13) by PH7PR10MB5832.namprd10.prod.outlook.com (2603:10b6:510:126::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 21 Oct 2022 13:53:30 +0000 Received: from BN0PR10MB4822.namprd10.prod.outlook.com ([fe80::57f4:23ef:5614:96a0]) by BN0PR10MB4822.namprd10.prod.outlook.com ([fe80::57f4:23ef:5614:96a0%2]) with mapi id 15.20.5723.035; Fri, 21 Oct 2022 13:53:30 +0000 Date: Fri, 21 Oct 2022 15:53:24 +0200 From: Daniel Kiper To: Darren Kenny Cc: grub-devel@gnu.org, Vladimir 'phcoder' Serbinenko , Robbie Harwood , Glenn Washburn Subject: Re: [PATCH v2 0/3] Fix building with clang Message-ID: References: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: BE0P281CA0033.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:14::20) To BN0PR10MB4822.namprd10.prod.outlook.com (2603:10b6:408:124::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN0PR10MB4822:EE_|PH7PR10MB5832:EE_ X-MS-Office365-Filtering-Correlation-Id: 9675e691-c4dd-41b8-cb32-08dab36ba2b0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q9OGk43LWtFZpNVJh8qbIsgJ4y23Qd32HeB2SeSfI7yw+MXXYs20iG0qg0+SwFvYfXGwhasjXK5n7fwcpok8uILE5qnLs+f4zewsvmQt7dbQrGN3oVYkNhWVC/mVyxNV8hsVxv7qP+0pKJ9aU4daaeqDeWLEzLRUzamvOoydIU25Aur/YpBom89dChppF/FHrO8+BDWVOCwNU2MCkGSvLvu46sV9GkDxAqFy3B7z691UfaknxO4ERXI3CT5CLxebHFnhNj4jG42NWdRVo5KtUkdyaWYUZ5e3vPU8Ec408jRzj5oFjV5si12jxPqYq551Oh6WGgUFijvuD4yodqqs00Ffmn+Qt+Cn26EvaIylc2EELacxHBydRLEGVqOrr7I0Cq0Gkc6ktLiHU3X72iOSQbmkxzkCGe3IJODwXP//IzylSOmnFDuPz+Xn+xJhXt1ygHZ7KcAfVxQ4pA9NPCwM1w2uS15UtfqaqJr3HxvMK9PKiYPApxAguQobnGfAlZqs51jHD1uzijQ0ITFlHK9RyF29YKQuSNhM5pDD41a6f9laehqLb+AqIS6hKUACK6EO9WjnoFF5xfWoTAIDM1Euhhp1/f6UXouWjShGAlIsESdZI7dFI+O55oIHskfwBZhJLi81mM2AxwxWNCarwBLd7NYl4a9ZKdsg2Hyi0YLZiIV0LjU9MFFtVpNToa/ssG5Dg/Ec5oyD7Dt9+l7LM1CXmA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN0PR10MB4822.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(346002)(396003)(366004)(376002)(136003)(451199015)(38100700002)(86362001)(2906002)(6512007)(9686003)(5660300002)(6666004)(44832011)(6506007)(26005)(478600001)(83380400001)(186003)(41300700001)(6486002)(66476007)(54906003)(316002)(66946007)(4326008)(6862004)(6636002)(8676002)(66556008)(8936002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GyGRa+bvoD5IlID1Obe0JUpYgyjV1SMFU7Tq4AWJMged5fmsdkn69dUGch/m?= =?us-ascii?Q?dgTlsNlVFwENUrkRypQUa9uIEh06P7QnzZ4vmfBKSvQXjKgZkowrQULkPIeT?= =?us-ascii?Q?7tRhYMzcUqpbunAh3lvSr4BClsimUUcxouN4Nn5NauLgiJRwmIhXZjLcmA4j?= =?us-ascii?Q?tt1rURHxAKfwxfocphNz9xpWMtAb/WOlJsonZxfpM8dY+gINact7njHSSBIS?= =?us-ascii?Q?KjEPaLCxHDPZH5SSnWObFribvUCABLPMY4DSPpqHHguZ6zNzQ0oA4PiO/NDc?= =?us-ascii?Q?PddnYa+pa9otN3v39lolSXXJ4tp3xA3dvJxbUF1Gv6lbLacwYa55AXTr1TFp?= =?us-ascii?Q?iHWn+9Z5x4IKUqYfvXaENZhzWnW0SsEus2aohLQQ9hLItlknNdob6AWR6pGw?= =?us-ascii?Q?VQNTA9TbO0BwPPrqKT+28pC6ZCXmFMCUCW4PMSeKhFd0unV/fy+mRC57pFaw?= =?us-ascii?Q?hdGLOkc90Y4pzLAT5Adl35+tzelgvgwwEPS+BczuJ71WuJ/fmFT9AwENrK8p?= =?us-ascii?Q?97t1sUerBnASYlxfvZNpWaGO63BudYpFBnmLIv+wsx7cXNlXZrdFu8M+Ez9f?= =?us-ascii?Q?eUFfAbYQ5gTa4MebCN9NdneVRjR2csm8K8q5IejnXDv43CVZTExt5B57zXke?= =?us-ascii?Q?iIgPTwrR2A+G2Dg350F6ukwQtYfTa4doEwxt4HW2j1YI08N0NTZSGhZ4G8CQ?= =?us-ascii?Q?g4D9uLO/HMHoGYAVw6oOpP5cuzWmj6p5Zw9RylM4b1H5/Y9Z480hyQGooOqE?= =?us-ascii?Q?TvJiMvCQhVHMB4ZYs3DWuRfnkYIYibYym10oZel0TYfc9BO3c+14kuDUwR6K?= =?us-ascii?Q?wIKgpk8Z6/66tfltwiX/T0zallipACsXdXN4YAtL3Lv1CEwIzEAVwSU8aK6C?= =?us-ascii?Q?PBMqHTNMxCI0vBaAjratDgamEd0nHq8rDhg/Zb9JEH1xQjjekKFW8wsyMf9s?= =?us-ascii?Q?1lADvLWopyvuC+xZ4pZaLcZ5gEi7de61ANbFUlWlWyGxF1/zz6LWGpffkJh3?= =?us-ascii?Q?gcabjemDoF65Fu0XzLXDK8qFFpJ2avImY4JHMMt1xn1hGVYDiapqlyHcZfoz?= =?us-ascii?Q?/VqY/w+oUK3OLAvhSqyxm1Gqh8NWT09mvhTPzuuLnqRTuijMlalzvZqjbliN?= =?us-ascii?Q?HJadEn356vP8A0ZMoggkBIf4hjKPm/XSIyP70+EJCN5atTaxxgYkJFuhccHj?= =?us-ascii?Q?vfL6iSImcRcEQk7d7AEdhXSWPBbnvjRuGzZGWnoaWFcvuR3mQ4xtcJYvkkEs?= =?us-ascii?Q?P2KzPvJhE+OM0O/BV/HuESk/6SDJ0xFzDWaQ9rrBv6lac7uJfWg7DHPOAwAY?= =?us-ascii?Q?jrPIvOgkLu7kXOabgLhTKzImMJsRgYqVkRrQ/o7FezdhNOUiDVSzOsW5uqDk?= =?us-ascii?Q?IaAeCuOWw5v+uwbCelsGC3DXlBjxx/DnrsNGIn0mSrgiVmfV1e9mwFZyLmmq?= =?us-ascii?Q?fqRYLH9nxn2y8VH3/PyBvMBbEcX4OJ7HyGl4nrhEfEZTplyuu1f2PBtsRczO?= =?us-ascii?Q?hvDBDXwoGAMg3sPLtiD4oB+M4+dint97oQ5vHFKdjcPy4bYGdxE1BbRvgaRP?= =?us-ascii?Q?8K4UGDz9EplblQYnwtTwOaXMx0hSwpyUgkCyoMxi?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9675e691-c4dd-41b8-cb32-08dab36ba2b0 X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB4822.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 13:53:29.9807 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JKwyGb8Z0h3rnXZJYO0etQEYNfuOc+tz/9vMuHa8Jfe2gxTZ23qpEUAyiAKbwb+NeVK5ZcOlYwmjAwmiYzAT8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB5832 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-21_04,2022-10-21_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 bulkscore=0 mlxscore=0 phishscore=0 suspectscore=0 adultscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210210083 X-Proofpoint-ORIG-GUID: DoaOLwo4FoQWU8ubdDT1DZXIpvo9RgAu X-Proofpoint-GUID: DoaOLwo4FoQWU8ubdDT1DZXIpvo9RgAu Received-SPF: pass client-ip=205.220.177.32; envelope-from=daniel.kiper@oracle.com; helo=mx0b-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2022 13:53:40 -0000 On Fri, Oct 21, 2022 at 01:32:58PM +0000, Darren Kenny wrote: > The abiltiy to build with clang was broken in the last release after the > upgrade of gnulib, but it would also appear to have been broken too with > versions of clang prior to 8.0.0. > > There were two main issues: > > - The use of __builtin_trap in the abort() macro. > > This builtin doesn't exist for clang builds > > After some discussion between Daniel and Vladimir, it was requested that I > should revert some past changes in this area, and re-introduce the use of > grub_abort(). > > - The is some use of variable length arrays (vla) in gnulib's code, and when > an attempt was made to resolve this in gnulib itself, I was informed that we > shouldn't be building gnulib with -Werror. > > Rather than totally disabling -Werror, it seemed better to just limit it for > the specific case that is causing problems, i.e. vla. > > - Attempts to build clang with versions prior to 8.0.0 are also failing due to > the use of the previously introduced safematch function usage. So we're also > bumping the minimum version of clang in the INSTALL file and safemath.h > where the test is done for the requisite version. > > Thanks, > > Darren. > > v1 -> v2 > -------- > - Update with changes to INSTALL and safemath.h after testing various clang > versions from 3.8 and up. > > Darren Kenny (3): > gnulib: Provide abort() implementation for gnulib > configure: Fix building with clang > build: Update to reflect minimum clang version 8.0 Reviewed-by: Daniel Kiper for all patches... Thank you for fixing all these issues! Daniel