Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5ED0E1FAE for ; Fri, 28 Oct 2022 10:04:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666951458; x=1698487458; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=hhsMbbxGYStohAh15fvX1DMTKWlhhSTK1Gfncm9ni3g=; b=RIUM0epUNODLl2tp2Gdxg3lv6p3JpUQloT5b1a2M3MseV1MBgq1kJvWj M75FM2UhwHUvnTYZuRXFgPg2eYrtD3wprnaVKZ761Od+jXT671T1KqY8B hUI8VO9eSkAZh+OiPiC/+PGvF4p/U+b/VHeML4QyZAgICsxnMQ1U3Mq5w g3fuGlp6eJR2WfhffCr/wAZ3LuQM1zXeM6snHgneHLxBOheYXSp+O/P7w jMyLLNvXrsk6TVgWJfSMPyTVMwY7DxLFKHSqQoT9KO7b8dTecDGvTHTLx nODA7Annn8L2yqUXcoa7S6kiF5F8ui5iiNhWxDzllftEeFa6wMa9Bagtl Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10513"; a="309549299" X-IronPort-AV: E=Sophos;i="5.95,220,1661842800"; d="scan'208";a="309549299" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2022 03:04:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10513"; a="627478453" X-IronPort-AV: E=Sophos;i="5.95,220,1661842800"; d="scan'208";a="627478453" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.191]) by orsmga007.jf.intel.com with SMTP; 28 Oct 2022 03:04:13 -0700 Received: by stinkbox (sSMTP sendmail emulation); Fri, 28 Oct 2022 13:04:11 +0300 Date: Fri, 28 Oct 2022 13:04:11 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Thomas Zimmermann Cc: Hector Martin , Maarten Lankhorst , Maxime Ripard , David Airlie , Daniel Vetter , Javier Martinez Canillas , stable@vger.kernel.org, Pekka Paalanen , asahi@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/simpledrm: Only advertise formats that are supported Message-ID: References: <20221027101327.16678-1-marcan@marcan.st> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment On Thu, Oct 27, 2022 at 01:08:24PM +0200, Thomas Zimmermann wrote: > I trust you when you say that ->XRGB8888 is not enough. But > although I've read your replies, I still don't understand why this > switch is necessary. > > Why don't we call drm_fb_build_fourcc_list() with the native > format/formats and let it append a number of formats, such as adding > XRGB888, adding ARGB8888 if necessary, adding ARGB2101010 if necessary. > Each with a elaborate comment why and which userspace needs the format. (?) Are you saying there is some real userspace that breaks without the alpha formats? That would already be broken on many devices. -- Ville Syrjälä Intel