Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE253C433FE for ; Fri, 11 Nov 2022 09:52:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3223010E7DA; Fri, 11 Nov 2022 09:52:56 +0000 (UTC) Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9A02210E7DA for ; Fri, 11 Nov 2022 09:52:53 +0000 (UTC) Received: by mail-ej1-x634.google.com with SMTP id 13so11482494ejn.3 for ; Fri, 11 Nov 2022 01:52:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=wQ6YznR2BI+m/vKYdhlJWOm0sz9hVepJ2G+rgEFzHpc=; b=dMjmB/xlFnRM7OMOyX622qYvotpfqOYbWV0ItdfnXTE0S08FngGImIzUDdJ06HXso5 kK5/lBIotm05BB2vsPUALHYDxJKnR/wGCWfP207f0s0P6jweDORA8Wk8f5XkfSmt6gfa Neue5Xf8KFvfK/bsGEg+xRQi776n4ocK6vyEY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wQ6YznR2BI+m/vKYdhlJWOm0sz9hVepJ2G+rgEFzHpc=; b=xa7gGtpYQj7xKGYFYy0Kg+/sX+m4op3YDBatz6OLKL0A5/xsaZhS/hgMQtJhT5PGMy Szf0+fiJy2WFRDuMZ5UOwKYXsURjgneN3sXJBLym4sTjCZ0BTOL2XsXQL5MqV6IPKwh7 eYsHFRpE6VHwzCax/5pK5UdevJrJwiPeQbp6Mbo90WdBM+S1GpVnO2DMaHTDu92JTClf ENtg6CDWfev/mA+UTZ0163dr0QKbM21NxAfSOSx+5KSfdFbOPT3yE8aig6IufaFNWe6B gmRx8Dp6JF3mDSdy1LKTMHe4AmgPa3LcdJGpiKCoLDHL0G44nvLjsDAx6+n0WdazSCoc SivQ== X-Gm-Message-State: ANoB5pmBOqsNS0Dmy6rf9O3BuDA8llw55V5hK8HozjIY1AJVphctL212 emDZ8jL8Na5NW4IVWtQLlW0KTQ== X-Google-Smtp-Source: AA0mqf7tI0J+v3LANgtPDstoGFOuwa8zdVJZ2xKskHEWq6W/1BsDMylXj31N+rQUv+b28zl8bcIf8w== X-Received: by 2002:a17:907:990f:b0:7ad:79c0:5479 with SMTP id ka15-20020a170907990f00b007ad79c05479mr1220274ejc.392.1668160372076; Fri, 11 Nov 2022 01:52:52 -0800 (PST) Received: from phenom.ffwll.local (212-51-149-33.fiber7.init7.net. [212.51.149.33]) by smtp.gmail.com with ESMTPSA id b3-20020a170906728300b007ad86f86b4fsm697416ejl.69.2022.11.11.01.52.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Nov 2022 01:52:51 -0800 (PST) Date: Fri, 11 Nov 2022 10:52:49 +0100 From: Daniel Vetter To: Won Chung Subject: Re: [PATCH v4] drm/sysfs: Link DRM connectors to corresponding Type-C connectors Message-ID: Mail-Followup-To: Won Chung , bleung@google.com, pmalani@chromium.org, heikki.krogerus@linux.intel.com, imre.deak@intel.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, jani.nikula@linux.intel.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20221108185004.2263578-1-wonchung@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.19.0-2-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: heikki.krogerus@linux.intel.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, pmalani@chromium.org, tzimmermann@suse.de, bleung@google.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Nov 10, 2022 at 11:33:11AM -0800, Won Chung wrote: > Hi Daniel, > > Thank you very much for a review. > > On Wed, Nov 9, 2022 at 3:54 AM Daniel Vetter wrote: > > > > On Tue, Nov 08, 2022 at 06:50:04PM +0000, Won Chung wrote: > > > Create a symlink pointing to USB Type-C connector for DRM connectors > > > when they are created. The link will be created only if the firmware is > > > able to describe the connection beween the two connectors. > > > > > > Currently, even if a display uses a USB Type-C port, there is no way for > > > the userspace to find which port is used for which display. With the > > > symlink, display information would be accessible from Type-C connectors > > > and port information would be accessible from DRM connectors. > > > Associating the two subsystems, userspace would have potential to expose > > > and utilize more complex information, such as bandwidth used for a > > > specific USB Type-C port. > > > > > > Signed-off-by: Won Chung > > > Acked-by: Heikki Krogerus > > > --- > > > Changes from v3: > > > - Append to the commit message on why this patch is needed > > > > > > Changes from v2: > > > - Resend the patch to dri-devel list > > > > > > Changes from v1: > > > - Fix multiple lines to single line > > > > We seem to be spinning wheels a bit here (or at least I'm missing a lot of > > important information from this series alone) with already at v4 but the > > fundamentals not answered: > > > > - where's the usb side of this, and anything we need to do in drivers? > > This should all be one series, or if that's too big, then a link in the > > cover letter for where to find all the other pieces > > We already have a framework in typec port-mapper.c where it goes > through component devices and runs the bind functions for those with > matching _PLD (physical location of device). > https://elixir.bootlin.com/linux/v5.18.1/source/drivers/usb/typec/port-mapper.c > > Currently, USB ports and USB4 ports are added as components to create > a symlink with Type C connector. > USB: https://lore.kernel.org/all/20211223082349.45616-1-heikki.krogerus@linux.intel.com/ > USB4: https://lore.kernel.org/all/20220418175932.1809770-3-wonchung@google.com/ > > Since these are already submitted, do you think it would be a good > idea to add the links in the commit message? Hm yeah explaining this in the commit message with links should be good enough. Another thing, will this hit the component nesting problem? With this change we'll have drm drivers which are both aggregates and components at the same time, and last time someone tried this it all deadlocked in component.c. > > - since I'm guessing this is for cros, will this also work on standard > > acpi x86 that are built for windows? arm with dt? Might be answered with > > the full picture > > Yes this is for cros, but it should work on any ACPI x86 as long as > _PLD field for Type C connectors and DRM connectors are correctly > added to the firmware. > > Since _PLD is ACPI specific, we do not have ARM with DT supported at the moment. > In the future, if we find something similar to _PLD in DT, I think we > can also use that in typec port-mapper for component matching. > > Heikki@ Can you correct me if I am incorrect or missing something? Ok sounds good, would be good to include this in the commit message, too. > > > > > > - you say this helps userspace, but how? Best way here is to just point at > > the userspace change set that makes use of this link, code explains > > concepts much more precisely than lots of words, and it's also easier to > > review for corner cases that might be missed. That link also needs to be > > in the commit message/cover letter somewhere, so people can find it. > > I do not have working code in the userspace yet since there is no > symlink created between Type C connector and DRM connector at the > moment. > If this patch is to go through, ChromeOS will parse the symlink in DRM > to find which Type C port got displays connected. This isn't how new uapi works, we need to have the userspace together with the kernel changes. Otherwise ... how can you test that things actually work before we commit to the kernel change? Freezing down uapi on the promise that userspace will show up and that we're crossing fingers that it'll all work is not how we roll in drm. > First use case is metrics collection. > We would like to know which port at which location is most preferred > to be used for displays. > We also want to see how many users charge the system on the same Type > C port as displays. > To answer these types of questions, we need to know which specific > display uses which specific Type C connector. > > Second use case is to get a better idea on USB-C pin assignments. > When a Type C port is in DP alt mode, there are some options on pin > assignments, whether to prioritize DP bandwidth vs USB Superspeed. > If we can find whether a display is actually being used by a Type C > port, we can check the cases where the port prioritizes DP bandwidth > over USB Superspeed while there is no display actually connected. > > This symlink can also be useful in the future with USB4 that makes use > of DP tunnelling. > > Benson@ Can you add on to the use cases above if something is missing? Above should probably all be included somewhere in the commit message too. > I can try to create mock patches in ChromeOS to give an idea how > userspace can utilize this symlink. > Would this also work? drm expects fully reviewed&ready for merge patches, not just mock tests. Also ideally some igt uapi tests, but for a symlink I honestly don't know what that should be so I guess we can skip that :-) For details see our docs: https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#open-source-userspace-requirements https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#testing-and-validation > If it sounds okay, I can work on the userspace mock patches and resend > v5 with the links added to the commit message. Sounds good! Cheers, Daniel > > > > > > In principle nothing against the idea, seems reasonable (but I'm also not > > sure what exact problem it's solving) - but all the detail work to make > > this work than an RFP to kick of some discussion is missing. And I think > > it's not even enough to really kick off a discussion as-is since there's > > really no user of this at all (in-kernel or userspace) linked. > > > > Cheers, Daniel > > > > > > > > > > > drivers/gpu/drm/drm_sysfs.c | 40 +++++++++++++++++++++++++++++++++++++ > > > 1 file changed, 40 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c > > > index 430e00b16eec..6a9904fa9186 100644 > > > --- a/drivers/gpu/drm/drm_sysfs.c > > > +++ b/drivers/gpu/drm/drm_sysfs.c > > > @@ -11,12 +11,14 @@ > > > */ > > > > > > #include > > > +#include > > > #include > > > #include > > > #include > > > #include > > > #include > > > #include > > > +#include > > > #include > > > > > > #include > > > @@ -95,6 +97,34 @@ static char *drm_devnode(struct device *dev, umode_t *mode) > > > return kasprintf(GFP_KERNEL, "dri/%s", dev_name(dev)); > > > } > > > > > > +static int typec_connector_bind(struct device *dev, > > > + struct device *typec_connector, void *data) > > > +{ > > > + int ret; > > > + > > > + ret = sysfs_create_link(&dev->kobj, &typec_connector->kobj, "typec_connector"); > > > + if (ret) > > > + return ret; > > > + > > > + ret = sysfs_create_link(&typec_connector->kobj, &dev->kobj, "drm_connector"); > > > + if (ret) > > > + sysfs_remove_link(&dev->kobj, "typec_connector"); > > > + > > > + return ret; > > > +} > > > + > > > +static void typec_connector_unbind(struct device *dev, > > > + struct device *typec_connector, void *data) > > > +{ > > > + sysfs_remove_link(&typec_connector->kobj, "drm_connector"); > > > + sysfs_remove_link(&dev->kobj, "typec_connector"); > > > +} > > > + > > > +static const struct component_ops typec_connector_ops = { > > > + .bind = typec_connector_bind, > > > + .unbind = typec_connector_unbind, > > > +}; > > > + > > > static CLASS_ATTR_STRING(version, S_IRUGO, "drm 1.1.0 20060810"); > > > > > > /** > > > @@ -355,6 +385,13 @@ int drm_sysfs_connector_add(struct drm_connector *connector) > > > if (connector->ddc) > > > return sysfs_create_link(&connector->kdev->kobj, > > > &connector->ddc->dev.kobj, "ddc"); > > > + > > > + if (dev_fwnode(kdev)) { > > > + r = component_add(kdev, &typec_connector_ops); > > > + if (r) > > > + drm_err(dev, "failed to add component\n"); > > > + } > > > + > > > return 0; > > > > > > err_free: > > > @@ -367,6 +404,9 @@ void drm_sysfs_connector_remove(struct drm_connector *connector) > > > if (!connector->kdev) > > > return; > > > > > > + if (dev_fwnode(connector->kdev)) > > > + component_del(connector->kdev, &typec_connector_ops); > > > + > > > if (connector->ddc) > > > sysfs_remove_link(&connector->kdev->kobj, "ddc"); > > > > > > -- > > > 2.37.3.998.g577e59143f-goog > > > > > > > -- > > Daniel Vetter > > Software Engineer, Intel Corporation > > http://blog.ffwll.ch > > Thank you, > Won -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch