Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDD6CC433FE for ; Fri, 11 Nov 2022 18:16:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232983AbiKKSQY (ORCPT ); Fri, 11 Nov 2022 13:16:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232949AbiKKSQX (ORCPT ); Fri, 11 Nov 2022 13:16:23 -0500 Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D5DF532D8 for ; Fri, 11 Nov 2022 10:16:22 -0800 (PST) Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.94.2) (envelope-from ) id 1otYZg-0006gQ-HF for netfilter-devel@vger.kernel.org; Fri, 11 Nov 2022 19:16:20 +0100 Date: Fri, 11 Nov 2022 19:16:20 +0100 From: Phil Sutter To: netfilter-devel@vger.kernel.org Subject: Re: [iptables PATCH 0/6] Merge NAT extensions Message-ID: Mail-Followup-To: Phil Sutter , netfilter-devel@vger.kernel.org References: <20221103014113.10851-1-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221103014113.10851-1-phil@nwl.cc> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Thu, Nov 03, 2022 at 02:41:07AM +0100, Phil Sutter wrote: > Besides the three different data structures in use to store different > revisions' extensions data, the actual code is pretty similar in all the > different NAT "flavors". > > Patch 1 fixes a minor bug introduced by a previous commit. Patch 2 > eliminates some needless checks and some that seem not necessary. > Patches 3 to 5 prepare DNAT extension code for the actual merge > happening in patch 6. > > Phil Sutter (6): > extensions: DNAT: Fix bad IP address error reporting > extensions: *NAT: Drop NF_NAT_RANGE_PROTO_RANDOM* flag checks > extensions: DNAT: Use __DNAT_xlate for REDIRECT, too > extensions: DNAT: Generate print, save and xlate callbacks > extensions: DNAT: Rename some symbols > extensions: Merge SNAT, DNAT, REDIRECT and MASQUERADE Series applied.