Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D895CC4332F for ; Tue, 8 Nov 2022 14:17:24 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8539D84C17; Tue, 8 Nov 2022 15:17:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=microchip.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=microchip.com header.i=@microchip.com header.b="1e1X/qA2"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BBCCC84FB1; Tue, 8 Nov 2022 15:17:19 +0100 (CET) Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E932481C06 for ; Tue, 8 Nov 2022 15:17:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=microchip.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=Conor.Dooley@microchip.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1667917034; x=1699453034; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=kXQLzPr2o5zxqPpXsjego/dCX3SUd7L0HRlppZUssLQ=; b=1e1X/qA2BSZYuLKTxo4P6NXPgzh4DyiD9FeLIduxu0yQuVbsthFvbC0a cX0ImGHcWsbBe+PUBpyVYkAFXJ0hIKgg0tZeRQJ13k69rhPA0BGIYP+Lz fm456yQXh6O18H5ilYthDzBgochCyI86t25xQNqzdNyeht6kz3mcbO77x 8tGvHdlYvmy8agNNgq76iQ5PWYp40Cl2MuolnO4/I3VZ13h6dZRnJpIsT MHTlSHBKCXRpH09x6LPkK6XtcMep7rO/7+fC3My9lJhYJH59VUReExRm/ pm8T9t41JLbJo1KctxIX2tqA7hxJcUvi4y67Mu30n7LphSD5HKyFbMMQq w==; X-IronPort-AV: E=Sophos;i="5.96,148,1665471600"; d="scan'208";a="122372707" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 08 Nov 2022 07:16:23 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Tue, 8 Nov 2022 07:16:22 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12 via Frontend Transport; Tue, 8 Nov 2022 07:16:21 -0700 Date: Tue, 8 Nov 2022 14:16:05 +0000 From: Conor Dooley To: Heinrich Schuchardt CC: Padmarao Begari , Cyril Jean , Subject: Re: [PATCH 1/1] riscv: enable reset via SBI on PolarFire Icicle Kit Message-ID: References: <20221107095546.28362-1-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20221107095546.28362-1-heinrich.schuchardt@canonical.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Mon, Nov 07, 2022 at 10:55:46AM +0100, Heinrich Schuchardt wrote: > HSS 2022.10 provides support for resetting the board. It's actually v2022.09 that added support for reset. I don't think that that is important to correct though, since v2022.10 is the version we are updating the dt in U-Boot to match. Reviewed-by: Conor Dooley One minor & mostly unrelated question below. > Signed-off-by: Heinrich Schuchardt > --- > configs/microchip_mpfs_icicle_defconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/configs/microchip_mpfs_icicle_defconfig b/configs/microchip_mpfs_icicle_defconfig > index c295b9bad3..65bd50db80 100644 > --- a/configs/microchip_mpfs_icicle_defconfig > +++ b/configs/microchip_mpfs_icicle_defconfig > @@ -21,3 +21,5 @@ CONFIG_SYS_MEM_TOP_HIDE=0x400000 > CONFIG_SYS_RELOC_GD_ENV_ADDR=y > CONFIG_BOOTP_SEND_HOSTNAME=y > CONFIG_DM_MTD=y > +CONFIG_SYSRESET=y > +CONFIG_SYSRESET_SBI=y I took a look at the config option, but something seemed odd to me. It says "depends on SBI_V02" but the help text says "version 0.3". I see there's no define for SBI_V03 so I assume that's why there's a mismatch. I didn't see a comment about it in the commit hence asking. AFAIR, v0.3 is the correct version. > config SYSRESET_SBI > bool "Enable support for SBI System Reset" > depends on RISCV_SMODE && SBI_V02 > default y > select SYSRESET_CMD_POWEROFF if CMD_POWEROFF > help > Enable system reset and poweroff via the SBI system reset extension. > The extension was introduced in version 0.3 of the SBI specification.