Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F98EC4332F for ; Tue, 8 Nov 2022 14:43:32 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 79AAC84FD1; Tue, 8 Nov 2022 15:43:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=microchip.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=microchip.com header.i=@microchip.com header.b="uSTigU+J"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9D14B84FD2; Tue, 8 Nov 2022 15:43:28 +0100 (CET) Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2A59C84FD1 for ; Tue, 8 Nov 2022 15:43:25 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=microchip.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=Conor.Dooley@microchip.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1667918605; x=1699454605; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Hvy4LUxR1oyTBcWqsDSzWGKUwNoCHmKCZ9dnTF4/YmU=; b=uSTigU+J1UEfdtxZuwBDrjcX0ZneDHTkbIsKHwKKoHVgTcAvg+vk3B3r VexMTHrUEazRuIEHV7XKXIsgNaDih7dSGEgVaeU9D7S92yj5v3DOb3WQB SL2PT+KszXQd1AAi+7lS4/ur4vTk2KIvkDz9uFJIm3jNfnSFdVLBPx8PJ mSmmuT5x5wq1w/U0NCgdklplrn57ag+ihTqMhcbbX5ACiOyfM4IqhXdKo rVN80DpgZBoNV5H96ibGY1HCeftlCs2jPVierqmReYiYN3DwxqKA2pW4m 4PP81YKa9ss3P2JJA0+nOTJInHVR4ip7LN4uf+J16gsrckDk0Fkk30G8c Q==; X-IronPort-AV: E=Sophos;i="5.96,148,1665471600"; d="scan'208";a="185924914" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 08 Nov 2022 07:43:23 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Tue, 8 Nov 2022 07:43:18 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12 via Frontend Transport; Tue, 8 Nov 2022 07:43:17 -0700 Date: Tue, 8 Nov 2022 14:43:01 +0000 From: Conor Dooley To: Sean Anderson CC: Heinrich Schuchardt , Padmarao Begari , Cyril Jean , Subject: Re: [PATCH 1/1] riscv: enable reset via SBI on PolarFire Icicle Kit Message-ID: References: <20221107095546.28362-1-heinrich.schuchardt@canonical.com> <13fa1f45-d831-b6c3-df8a-5ed9fc7a2a7c@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <13fa1f45-d831-b6c3-df8a-5ed9fc7a2a7c@gmail.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Tue, Nov 08, 2022 at 09:23:19AM -0500, Sean Anderson wrote: > On 11/8/22 09:16, Conor Dooley wrote: > > > +CONFIG_SYSRESET_SBI=y > > > > I took a look at the config option, but something seemed odd to me. It > > says "depends on SBI_V02" but the help text says "version 0.3". I see > > there's no define for SBI_V03 so I assume that's why there's a mismatch. > > > > I didn't see a comment about it in the commit hence asking. AFAIR, v0.3 > > is the correct version. > > IIRC 0.3 is the same as 0.2 except it was ratified. Ah I see. Apologies for the noise on that one so, had a quick look on the riscv-non-isa github but obviously not enough! Thanks Sean. > > > config SYSRESET_SBI > > > bool "Enable support for SBI System Reset" > > > depends on RISCV_SMODE && SBI_V02 > > > default y > > > select SYSRESET_CMD_POWEROFF if CMD_POWEROFF > > > help > > > Enable system reset and poweroff via the SBI system reset extension. > > > The extension was introduced in version 0.3 of the SBI specification. >