Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D915C433FE for ; Thu, 10 Nov 2022 13:24:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229892AbiKJNYL (ORCPT ); Thu, 10 Nov 2022 08:24:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229675AbiKJNYK (ORCPT ); Thu, 10 Nov 2022 08:24:10 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EEA86A69F for ; Thu, 10 Nov 2022 05:24:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=e1f5N8gRSqfzxUpxVA2y18vSJE/+F6MBjUppYvek5vQ=; b=Mzz/oPuTE09WjY+WXKN3jJuzr0 J9bI9aRb02xhKkmSh/RwG4qj2yfYorD/199a+3cWBzZaRrrpYFhFhXfQkM3cEWkmNaXsaG/XicMSN v/jUsWDMPYSeyOkyImXnaQzYR5GvpWxMcR9+HSVQ4/Gcw4rZQBEahXKWelYD5EE+dc34=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ot7X9-00229v-DV; Thu, 10 Nov 2022 14:23:55 +0100 Date: Thu, 10 Nov 2022 14:23:55 +0100 From: Andrew Lunn To: David Thompson Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, cai.huoqing@linux.dev, brgl@bgdev.pl, limings@nvidia.com, chenhao288@hisilicon.com, huangguangbin2@huawei.com, Asmaa Mnebhi Subject: Re: [PATCH net-next v2 2/4] mlxbf_gige: support 10M/100M/1G speeds on BlueField-3 Message-ID: References: <20221109224752.17664-1-davthompson@nvidia.com> <20221109224752.17664-3-davthompson@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221109224752.17664-3-davthompson@nvidia.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Nov 09, 2022 at 05:47:50PM -0500, David Thompson wrote: > The BlueField-3 OOB interface supports 10Mbps, 100Mbps, and 1Gbps speeds. > The external PHY is responsible for autonegotiating the speed with the > link partner. Once the autonegotiation is done, the BlueField PLU needs > to be configured accordingly. > > This patch does two things: > 1) Initialize the advertised control flow/duplex/speed in the probe > based on the BlueField SoC generation (2 or 3) > 2) Adjust the PLU speed config in the PHY interrupt handler > > Signed-off-by: David Thompson > Signed-off-by: Asmaa Mnebhi Reviewed-by: Andrew Lunn Andrew