Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CDC4C4332F for ; Thu, 10 Nov 2022 13:34:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230466AbiKJNeE (ORCPT ); Thu, 10 Nov 2022 08:34:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230018AbiKJNeC (ORCPT ); Thu, 10 Nov 2022 08:34:02 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DE86B850 for ; Thu, 10 Nov 2022 05:33:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=RgsVAepD3nxQVWROE+vTabZLY0EkelIOXRN6DmurrE8=; b=gTHc2y74GhWzebDyuYtsL9zDKH q23XnIZSsikB+Hp3XGbuF3sED4xGqBC1oy3TBZv+oYSxoli+No0wo1ilju7jfffTyRT649Zk9x1Ot hclpojJs7/71xOGbgg6+c59R01f1I/zCmiO+lSrsS0qNDRs7Szslb5W4pil0V4sJiCOE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ot7gh-0022EZ-6W; Thu, 10 Nov 2022 14:33:47 +0100 Date: Thu, 10 Nov 2022 14:33:47 +0100 From: Andrew Lunn To: David Thompson Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, cai.huoqing@linux.dev, brgl@bgdev.pl, limings@nvidia.com, chenhao288@hisilicon.com, huangguangbin2@huawei.com, Asmaa Mnebhi Subject: Re: [PATCH net-next v2 3/4] mlxbf_gige: add BlueField-3 Serdes configuration Message-ID: References: <20221109224752.17664-1-davthompson@nvidia.com> <20221109224752.17664-4-davthompson@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221109224752.17664-4-davthompson@nvidia.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Nov 09, 2022 at 05:47:51PM -0500, David Thompson wrote: > The BlueField-3 out-of-band Ethernet interface requires > SerDes configuration. There are two aspects to this: > > Configuration of PLL: > 1) Initialize UPHY registers to values dependent on p1clk clock > 2) Load PLL best known values via the gateway register > 3) Set the fuses to tune up the SerDes voltage > 4) Lock the PLL > 5) Get the lanes out of functional reset. > 6) Configure the UPHY microcontroller via gateway reads/writes > > Configuration of lanes: > 1) Configure and open TX lanes > 2) Configure and open RX lanes I still don't like all these black magic tables in the driver. But lets see what others say. Andrew