Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1oxsL9-0005wV-S6 for mharc-grub-devel@gnu.org; Wed, 23 Nov 2022 11:11:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxsL8-0005wG-Ls for grub-devel@gnu.org; Wed, 23 Nov 2022 11:11:10 -0500 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxsL4-00034Z-5R for grub-devel@gnu.org; Wed, 23 Nov 2022 11:11:10 -0500 Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2ANENjJJ026926 for ; Wed, 23 Nov 2022 16:11:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2022-7-12; bh=xjdvhHSjdby+YYWb0mIYLOvd+s+/jzBBS62Tgkrx3Dw=; b=NOgk2aZPEbT4SVc+UPXCGTMI7rn9V0/WEg74CkkRrFJSfrGJLakgaNLHnJuetzwYrFwP zgjytnELklcV0IHuwnQi/DwNCGHcH9wFy3Bmf68yrmBPHZbcZZ+f0bNr+NCZdNsZxJEM zqPo/IO/7iGU76YyuHXG1LsQzwTyMKM2WLje5uIePGY2g11lrcZ1x4RC0P2BEeFFq3CP rspL1a5XUAU/YRjOJLt+ueXUS1v1bi5HmMGOzBHKwwc2TDFADfbUh4NPcquv657jdpyC X5f+Ny7bBYcXmJo1clElFdN4W0aBJcOsIy1Pz1xMfCV3sewqzC9R4AShMxiE6g5y1dqM vw== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3kxrfb3xcd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 23 Nov 2022 16:11:03 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2ANFL37r010712 for ; Wed, 23 Nov 2022 16:11:03 GMT Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam02lp2048.outbound.protection.outlook.com [104.47.51.48]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3kxnkdbkms-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 23 Nov 2022 16:11:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EDctFEBf2P04mPLNThA092n8lne0AEbjlmdwnOx+KZ4Tm3xR3TD41Ee7DE/Y2V4/KnIphkqDGhPmv/40S2kXJo0SjYOdbZz3O+iPBOF1zQROPPzlW+pcqUYeDeSZUFt9umPuAedic4YOt8XfcutBklW7k5qczE2fw4YOAG8/cI45F98J6nkwA8McIUIPlfZw08t3iqwUHCOOWZnUzV216rTk6RaJcLAomKHA5Hik/lLr60xLCz6wM8EL3rIZDBHBWvE3+gOvyVv0GbTi+FiW/vZjiMUYMfobIyclwsHsEFsjXOAgL7EAkyR0pSYNU37ItVy8+qkBRFjTH9F8IENrsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xjdvhHSjdby+YYWb0mIYLOvd+s+/jzBBS62Tgkrx3Dw=; b=D8GvqdXZsroeEAWyymJfoIjy7yYet+Gk9V14PFs8cL4a6lV847jXmrT/Mw0F9V9cVx2amvNClHR+sw9z5OR8oLX8rXepzcNrijtScf7h5ga22sV5hmoL2J1dvscxStz/kxoska2y6MSzjituo1qVgEAO9AlHw4e45unqeUjJwuKJburrnzjyELtYkaGEdcfFH2YoKqAh7aSohMc76Bpv6KxqEtkrmUoV6qW0cPii3F50bNGAC4TKkIA56iUxjZ6K3rq9n2P4ryjZ2I7g91oyipWg8RJXcN7DY9LG0aHLtCDF7S2lnHarsu4EFv4cBMuaK6ZsI+cFJ9CZlfTcyvSSng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xjdvhHSjdby+YYWb0mIYLOvd+s+/jzBBS62Tgkrx3Dw=; b=kNC+NsiMa758k+y+qqPkGwJWL7nrkGHeZS899KhAeawwWuzv922FNDUtFobQL1Sh6DrHF5sxdw5h64f0f0GQs6F2BBBXlSkbTM0Kii8+MntpeaVrf0h8T1XCnX1pl9P+yoczuHVn2xkkJxfkVIbLAD9Xf2rs+ZZ5lf4HrWBE8aE= Received: from DS7PR10MB4829.namprd10.prod.outlook.com (2603:10b6:5:38c::20) by BLAPR10MB5378.namprd10.prod.outlook.com (2603:10b6:208:328::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Wed, 23 Nov 2022 16:11:00 +0000 Received: from DS7PR10MB4829.namprd10.prod.outlook.com ([fe80::e426:2700:f2bd:1f55]) by DS7PR10MB4829.namprd10.prod.outlook.com ([fe80::e426:2700:f2bd:1f55%5]) with mapi id 15.20.5834.015; Wed, 23 Nov 2022 16:11:00 +0000 Date: Wed, 23 Nov 2022 17:10:52 +0100 From: Daniel Kiper To: Jag Raman Cc: "grub-devel@gnu.org" , Darren Kenny , Ross Philipson , Alec Brown Subject: Re: [PATCH 1/1] fs/udf: validate length of AED in grub_udf_read_block() Message-ID: References: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: BE0P281CA0010.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:a::20) To DS7PR10MB4829.namprd10.prod.outlook.com (2603:10b6:5:38c::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR10MB4829:EE_|BLAPR10MB5378:EE_ X-MS-Office365-Filtering-Correlation-Id: 3d1e2235-16d7-40dd-4ea6-08dacd6d4f3b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 23D9ROIJiecQeB9l0cI6Lcv+ZuxmiUPOhue7XspjIvxGcqGK3WPxFYASZZCZd094DEtzFzAfTClM3ztsGpItJqBqfQ/ePo6WDd0qPCkqaTnNA0pT3ljjrAkOoY5ft+GSoHggqXp6S5yrM6t8z15In/fTCsnrtrrH33sjnhWumTX7eh32t7jbG17ZINXlz+JmS0iEa6GqWvo8BFpj3ShHoiCmkVqsv55pgLID8NOUNXuy13WwNl43VEIBJ1wqikaO/fNFLWojbz34VdQW4cd6rMWiyvR6+R/kVgyLFZlNWkkPhgTe9udbZ+SqShZiYvjv9vlgYbug2wScACKhRIVRcHqlAPRshZUZNpgyq6GvSPqi6Bk+91M8QBn+bjR91gibredloBfZeOfT2Oxea/uYzxg2Bws+Jl9ODy3f5kme5gLyc06jSMidYqioIy33FMI6v77E1kl/t/VKq0gdLv+D4Obl4VM31KF3zRwPBi2ctJWaDcYPR3Z/pvlUavrF0z2o6KVyuXyhTkHfp7jgaUO2D2ZTLwLS2J7KbHEihO/jLY3GAw6nZ1KiAxhK5p4+WBzEhdCcKDIjE8/nnp/giQB1rjY4umXeHznc3KT7xtv2TDY6UtOLYCiFRan1Iy1hIOsEqlmgF7TAGusmMGMplSKAZw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS7PR10MB4829.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(396003)(376002)(366004)(346002)(39860400002)(451199015)(9686003)(6512007)(186003)(83380400001)(53546011)(4744005)(38100700002)(2906002)(26005)(44832011)(5660300002)(6506007)(4326008)(107886003)(66556008)(6666004)(8676002)(66946007)(8936002)(6862004)(478600001)(316002)(41300700001)(54906003)(6636002)(66476007)(6486002)(15650500001)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qRBEXEPByJ1NqmTWQuhgBA0oaF3PPXxbGcAxd84aN5Q3x/a1SrLfrsR32Bj+?= =?us-ascii?Q?pO9d7aKXj7vrJL7BDVlmZPs0XHN1iGtPNJ9ZL+00LGUG1nuxRZ91u54YQn8A?= =?us-ascii?Q?cmpaiOvct3K5PQsPV42gAN4V16B6uxSLTosfrsp9GOvOuQzBHjrJJHzicMyR?= =?us-ascii?Q?OZTcmSCwIjjLugGliogKI/fl2lqMSwkP1uUpWspA1HEJ7YsB/RlYKgZhRnSm?= =?us-ascii?Q?vhIbr8Q9X9xqaohMbHZGZGN7dyKOeCCoOpZRv+N4bupuVL3zb4nghJGw0XBc?= =?us-ascii?Q?bRnDSZhUmS35t9zb1t4afStWuOKfAesunWYZTrnmNZ/h9d96thPfuxMVkwlp?= =?us-ascii?Q?U6xlmbpNUW8yYGvxkfANGtkdZLx8F/5vmvPCupJGHab7B4knbN5qXdX32a/U?= =?us-ascii?Q?YcMkDOCnDL3GbUIUedMpNilXxDMvhevzaAC9HSxh+CWsjJwo2VzXJJ/gpvSQ?= =?us-ascii?Q?UUzMyt73F1kJ2fnaQqWrgINd2rGuihDxzDIHjg0/2ggfkKlhhfbb3/mYodF/?= =?us-ascii?Q?Bvxm+GqJNUqz3hjxxvpR5zAMkxclJRUtzCe1Gf4EfbebXTq+s+kisS7Cs77Q?= =?us-ascii?Q?yPnbbhufQmLxxnB1RDPFm0Bgl3Aue54TfPc/wFqX/Har/zZ455UNvgEta1dS?= =?us-ascii?Q?aVccHRdv1U/WgYz23Jo4LbcIS0S2BHh3gzFXWX5wlSCGhkfY6tigs2ej3bpY?= =?us-ascii?Q?G4h6FZMLpITNfQeeyyNOswPIw9i1sJgseTvINewhw+G3m+AYvBbUH3MAIWGX?= =?us-ascii?Q?EYM1/nZuu3FX8lUZx3KL69vcJwesz8/TRYr/OkaHgKUflF6fCoyT6LRsXQc0?= =?us-ascii?Q?0yp3R4jwBs/eH8TIeTSe/5Frvxd5dBIWSovXMNQIBQb5B4FEWhELZMm5El3/?= =?us-ascii?Q?bWN8LETlc5iWzymPcGOE5Rap4L2ejwRGZ+I9gus4+hHg/OxPxGD7ye+7opES?= =?us-ascii?Q?b3nTbMn0yhNXpoC7HQqvxl3NW84WhGE7eJqh2WVdf9eg7C7nFE0zgU4qC21+?= =?us-ascii?Q?ie9lgIotg5uy3wUxZ2nRHJnd6Rrr+ZKEeFpYoo61lS1eV2/BMUPEbajWhMJK?= =?us-ascii?Q?MXVfEzONLwOEXmIiCKYNUyvn5U7NNIq5Sa4/mwFI9zD5KPea1ad1zOEu+xpb?= =?us-ascii?Q?+Np0ZLzN/dGChQNZ3vmthcpb3w+tc+N/yP76UrvQ/VO9IOnMt/wU6bDeenDK?= =?us-ascii?Q?+cabN+wIZO2e4bskb0O3LF7BUGffWmqh4QfUTqpcC/cv/k4WyTTBz2PIgv0y?= =?us-ascii?Q?GTlEeiwubwcyRExPN2S+CRDkIwNLiEEXMVbHwla8sb8MQWczgtObOyQr/JYY?= =?us-ascii?Q?Hwli7XdkOj8vvNmnZ9GjsO/Xg/F3SJ+mStZmjz0KbN8pXeRSxg/elADONyLL?= =?us-ascii?Q?0klZhscXY2AxmE2NOdQ4GXxf/c+jHHazhHEr+zq9cJqYSctvNMtSpx9CYWoO?= =?us-ascii?Q?bQGf47R17lDorszQhvbvf9DQ1+IfaZkD6DmXNjgFHvgkFmU1shMeWTox62oV?= =?us-ascii?Q?9QOXBW8nOIN9H8O7BHcsj0+KBhiQ7hUyaYrk+FTqxz71awoMisCk/zRcmrRf?= =?us-ascii?Q?FNxAcQIoPCHkNGZbTmRWCb0Rjz8eKFrcaUYnI0pi?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: aJeSL5PRsO1Ufu+qHbeWlPQXMHihI42HgW9Oezl2PezGXiFw6F4tbVZpXsHtF7pbXQPZGMRS13jh7yc9SxTnxm0ywe1OtrHgjDJFFRgNJRfbbqIf/KU7XxqwRWLovE/KLy786pfV02GvHJLMVzYz5kDf6R2EV8EUp6CZc9M2M9EsQkM2eaPYkcDskZHDNG3wKR+Fn/+rRGwxpt8WFRw4slvR789/YvttPgq08Uog3Wq5z0XSDo+k1gT+uRC+NY3RxlcvDWzAYAbcTHuxT1T72+A5NKKQvkbAQIk09We7MQWweCxlRx3ziOHCrg0baCkegaWPUh9JXGB24xIL2anXp2mRYaODzkC3v9CoK1FERmBzrKNYNbizKzeEmjRJYjuZBUFAykjbFpQNeIogjr7ls4sc2K+wkebLAdo1sapac7aghNfyQOJIEYO+w4yYiQ2TTDcbO2e8Rg5FO7h6RR4zJGm7kfVUIO1rP5Ro7JVAz7dNOzE8yLi+qNZPSkJIlflbj+Mu6+W8NjBg1/uYBSvRdSJh/B8nrI36whJ2J35hJEGnn5Pd+VJ7nZet9k/JcTQGHEJjjXLPqgbOsFTFGN6ChLDplhc/VjYoPcjJUpLicHXWlFFN83dPU/7Oy/RWZEOA/kDxVEyblAnh+UbEXqtocxDa9dt+3/+pwkAXNHd2QGIvBHJOh1u+jlf5MNjHKxkZDqRE7N5OtQUsgmeCI6qhsm2vvM8tDvzoX6ByUISSKvAIOb+VRCJOqp2S5aDoxfEz X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d1e2235-16d7-40dd-4ea6-08dacd6d4f3b X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB4829.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 16:11:00.3572 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4mvCjJ/Wevi0Jolimzq6ZlFM3X6AMBErcgx7YQ8jY3wiOdrwCRf/Ce8/zpKhJmgqQ7xbyxQc2ljd8uSEweFb9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5378 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-23_09,2022-11-23_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 phishscore=0 adultscore=0 suspectscore=0 mlxscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211230119 X-Proofpoint-GUID: wLbdI04QYsj1g1xn2YYgVi0oDbYOjBpd X-Proofpoint-ORIG-GUID: wLbdI04QYsj1g1xn2YYgVi0oDbYOjBpd Received-SPF: pass client-ip=205.220.177.32; envelope-from=daniel.kiper@oracle.com; helo=mx0b-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Nov 2022 16:11:11 -0000 On Wed, Nov 23, 2022 at 04:20:02PM +0100, Jag Raman wrote: > > On Nov 23, 2022, at 9:52 AM, Daniel Kiper wrote: > > On Thu, Nov 17, 2022 at 12:17:52AM +0000, Jagannathan Raman wrote: > >> Validate the length of Allocation Extent Descriptor in > >> grub_udf_read_block(), based on the details in UDF spec. v2.01 section > >> 2.3.11 > >> > >> Fixes: CID 314037 > >> > >> Signed-off-by: Jagannathan Raman > > > > Reviewed-by: Daniel Kiper > > Thank you! My pleasure! And thank you for fixing this issue! Daniel