Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DDFDC4332F for ; Wed, 16 Nov 2022 23:36:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234181AbiKPXgO (ORCPT ); Wed, 16 Nov 2022 18:36:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234115AbiKPXgM (ORCPT ); Wed, 16 Nov 2022 18:36:12 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB3A14AF29 for ; Wed, 16 Nov 2022 15:36:10 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 804DF6204D for ; Wed, 16 Nov 2022 23:36:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CEC8BC433C1; Wed, 16 Nov 2022 23:36:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668641769; bh=YXNyog7zqus4isM+WVpqyJTvWQueVicIoSCuR3+HRaQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kkLWU/0bh5GjhVOnCWHBgq/tnnDJdY1g9W5vtensf99iXQ50d2Xv1DTIRAQ4y5ItS Xu83DB6PHinW0bYGs41O73jd+B8ZHxaLnHniJggEcapMRx20U7i9uDKO9ictcUTZhJ K0V+lM5PsR5Vuml4hvT6rHNAd/KJhLAY97LvFI5ydBH3bmdV0FTg6EIAOONOAsVKXz /r8Vvpy7rVnOJ2L7ktnyyrRp68H3dAUGhTT9+xAF2h6YFebYXKsQc6w1ZFuRtfof6R RzW5TZKChVYfAQ0CsLKAIZFnsJee0vrvXU2PmSaMyEhleBNPEZKm1HJMJ7E/OQs+k4 /GONOPlGinbpA== Date: Wed, 16 Nov 2022 15:36:08 -0800 From: Saeed Mahameed To: Jeroen de Borst Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, jesse.brandeburg@intel.com Subject: Re: [PATCH net-next v3 2/2] gve: Handle alternate miss completions Message-ID: References: <20221114233514.1913116-1-jeroendb@google.com> <20221114233514.1913116-3-jeroendb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 16 Nov 08:23, Jeroen de Borst wrote: >Saeed, > >Thanks for your review. I like the suggestion, but >__test_and_clear_bit is for unsigned longs, comptag is a short. > gcc will up-cast it for you with no problem. Assuming it's unsigned short.. if not then consider changing it to unsigned short, or do the casting yourself. anyway this was just a minor suggestion.