Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E857C433FE for ; Sun, 20 Nov 2022 18:52:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229547AbiKTSw0 (ORCPT ); Sun, 20 Nov 2022 13:52:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229520AbiKTSwZ (ORCPT ); Sun, 20 Nov 2022 13:52:25 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA0E4DED0 for ; Sun, 20 Nov 2022 10:52:24 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A258030A; Sun, 20 Nov 2022 19:52:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668970342; bh=r1UE/leIRf9bUUECrpJEecq9LOrFyefnoUxbvgFjlxU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D5pbbhPCIiSJV70w0oEztvKdIyswMmrL3pw7Z+qnIUxiKf7wUmHD6ZI8pRr2heX92 sFA9OIYtYqt/b/3LrtCXIVDuSMMSzVT1eZpwHML8XQuB6P7j/aLIgERAmJ+gfaonCt Tt/7meLqDHa3qiBRSy5QqTHdyjRPAJFukcZassTI= Date: Sun, 20 Nov 2022 20:52:07 +0200 From: Laurent Pinchart To: Marek Vasut Cc: linux-media@vger.kernel.org, Mauro Carvalho Chehab , Sakari Ailus , Stefan Riedmueller Subject: Re: [PATCH] media: mt9p031: Drop bogus v4l2_subdev_get_try_crop() call from mt9p031_init_cfg() Message-ID: References: <20221120141304.80832-1-marex@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221120141304.80832-1-marex@denx.de> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Marek, Thank you for the patch. On Sun, Nov 20, 2022 at 03:13:04PM +0100, Marek Vasut wrote: > The mt9p031_init_cfg() already calls __mt9p031_get_pad_crop(), which > correctly calls v4l2_subdev_get_try_crop() on V4L2_SUBDEV_FORMAT_TRY > or returns &mt9p031->crop on V4L2_SUBDEV_FORMAT_ACTIVE. No need to > call v4l2_subdev_get_try_crop() in mt9p031_init_cfg() again in case > of both V4L2_SUBDEV_FORMAT_TRY and V4L2_SUBDEV_FORMAT_ACTIVE. > > This also fixes a splat generated by this call since commit > 2ba3e38517f5a ("media: v4l: subdev: Fail graciously when getting try data for NULL state") > because v4l2_subdev_get_try_crop() is called with sd_state = NULL > in mt9p031_init_cfg(). > > Fixes: 69681cd041648 ("media: mt9p031: Move open subdev op init code into init_cfg") > Signed-off-by: Marek Vasut Reviewed-by: Laurent Pinchart > --- > Cc: Laurent Pinchart > Cc: Mauro Carvalho Chehab > Cc: Sakari Ailus > Cc: Stefan Riedmueller > --- > drivers/media/i2c/mt9p031.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c > index 5f5caafe56887..4ffc2f6e7db47 100644 > --- a/drivers/media/i2c/mt9p031.c > +++ b/drivers/media/i2c/mt9p031.c > @@ -708,7 +708,6 @@ static int mt9p031_init_cfg(struct v4l2_subdev *subdev, > V4L2_SUBDEV_FORMAT_TRY; > > crop = __mt9p031_get_pad_crop(mt9p031, sd_state, 0, which); > - v4l2_subdev_get_try_crop(subdev, sd_state, 0); > crop->left = MT9P031_COLUMN_START_DEF; > crop->top = MT9P031_ROW_START_DEF; > crop->width = MT9P031_WINDOW_WIDTH_DEF; -- Regards, Laurent Pinchart