Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E751DC4332F for ; Tue, 22 Nov 2022 15:15:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id B4F1DC433B5; Tue, 22 Nov 2022 15:15:08 +0000 (UTC) Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 119A6C433D6; Tue, 22 Nov 2022 15:15:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 119A6C433D6 Authentication-Results: smtp.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=microchip.com Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=microchip.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1669130102; x=1700666102; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=GpkSIeWT0lMRPcyAIGKwb/kNRvRf9zXgnioryzKVzg8=; b=Ky1dotnQhMQr1xoy5KhaYyvPDrolUYe7SWp7vEaRgLwjenROBwrfYLB9 1k0zKcrAPM4R8IcKQYZb6APS+ZkgQurfpj+LuEUhOvDJtt5MCcfKXRpx+ uo3Fqa+4BB7c/NyMY1UTx658oHUQVUDwLGSPUCY1AU0cv+wf8y1v+vHZB AXgoTl+BFq4e3Rchn5VA5dAcD3GaYkhel2O0tHqU2fUC4Hy7yKV+ZGzeu EIR6oJv1xrLTfth8zOZQtV1/8FGwyc7oQTaSqZT8RTP+HHDT5OGtNQ/Kn u0ANfxKeoebrC9N5fHj/9ISHOAIa73bgnA72qMsvD4XOqFkopkxPViOJe g==; X-IronPort-AV: E=Sophos;i="5.96,184,1665471600"; d="scan'208";a="188165690" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 22 Nov 2022 08:15:00 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Tue, 22 Nov 2022 08:15:00 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12 via Frontend Transport; Tue, 22 Nov 2022 08:14:59 -0700 Date: Tue, 22 Nov 2022 15:14:41 +0000 From: Conor Dooley To: Palmer Dabbelt , List-Id: CC: Arnd Bergmann , Conor Dooley , , Subject: Re: RISC-V SoC Drivers for v6.2 Message-ID: References: <608037ab-1e9c-4f70-b85c-5665a4bb1769@app.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Tue, Nov 22, 2022 at 07:00:00AM -0800, Palmer Dabbelt wrote: > On Tue, 22 Nov 2022 06:38:40 PST (-0800), Arnd Bergmann wrote: > > On Mon, Nov 21, 2022, at 18:24, Conor Dooley wrote: > > > Hey Arnd, > > > > > > Same stuff applies here: lmk if there's something you'd rather see changed. > > > Perhaps you'd prefer to see PRs per vendor? Although I think that's less > > > likely to matter here than in the DT stuff. Again, I'll try to get the PR > > > out a bit earlier next time. > > > > Applied, this looks fine, just a few things to keep in mind: > > Thanks! Ditto :) > > - please add "[GIT PULL]" to the subject line of the email > > FWIW, here's the script I use to send pull requests: https://github.com/palmer-dabbelt/home/blob/master/.local/src/git-send-pull.bash I noticed that yesterday evening while double checking what I'd sent out but by then it was too late... I'll use the script I use for internal stuff going forward & hopefully avoid a repeat. > > - Splitting up a large pull request into smaller ones can be > > helpful to make sure things don't go in unnoticed. I try to > > (briefly) look at each patch, but if you have 20 boring but > > large patches, and a small but important patch that I may > > need to comment on, that is a good reason to split. Sure. I'll try to figure out what makes the most sense for a split versus having stuff in linux-next in a reasonable way. I suppose volume of changes will mainly dictate the approach. > > > Not too much to see here, Yang Yingliang has added some error handling > > > to the setup of the driver that reports SiFive cache topology > > > information. I've put it on -next given how far we are in the release > > > cycle, feel free to put it on fixes if you disagree :) > > > > This is fine either way, as none of the fixes are likely to cause > > any real issues. I usually like to err on the side of having too much > > in the fixes branch instead of risking to miss something, but I'm > > just as happy to follow your preference here. Cool. I'll bear that in mind for next time, thanks. > > > RISC-V SoC drivers for v6.2 > > > > > > SiFive: > > > - add probe error handling to the ccache driver > > > > Since this tag description becomes part of the git history, try to write > > it like you would write a commit log in the future. Ideally that > > avoids bulleted lists (I know they are easy) and instead uses full > > sentences that explain things about the state of the patches. If there > > are bugfixes, are users likely to need the fixes or were they found > > through inspection? For new features, explain who would have the > > corresponding hardware and what it does. Again, what you have here > > is not wrong, but it can always get better. Yeah, I can do that. You likely won't get a Christian Brauner novella out of me ever, but I'll do something more cover letter-y next time around. Thanks again, Conor.