Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 074B7C4332F for ; Sun, 18 Dec 2022 14:55:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9s/AKaX6ySH+ojqKH6ukRA6HYQxxav24n5L0PEeDjHs=; b=MG3+IibuJ6GlFb dECv13Tpedmww8E75WtX0y94Cg6Za0f0ybr+sHrF7N6GgDi90HNVDXxQ0PoGTEgVRSfRXwLHW7Esd q4k9YUcjW/OCat9KuheZoRrRQVYnayQR8wMXzf7UEAu+HOOvzS35DAE2OZXLPmYO98KoKytwc2naC zAbrBSOy5uYdy4nzKLIdw5lveF+6N38x4zCGfHQ7667YPC2Jx5NI3vFERqYFJAysUamzp+3YUfEEw xNe0MIgD9y6Qk/ZTo3Xa+2c640CyupniP0klb2od9/S2yqNXWaqLkQfosjeX/wNfYYO99/APfX436 gG9f2IT8CquUQ8VkqCsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p6v3r-002O0C-Ov; Sun, 18 Dec 2022 14:54:43 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p6v3o-002Nuo-Tm for linux-arm-kernel@lists.infradead.org; Sun, 18 Dec 2022 14:54:42 +0000 Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 857EA825; Sun, 18 Dec 2022 15:54:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1671375278; bh=43Qt6ZYOC4TBKIY8dDjvik5pFjXPFyvL7XDMmzYhAeQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Of1OxrBzff2YmcJpMwRfKgc0skxPi3DqSyZsSTRMpzFpGPmStATuwQxsuPBJA+1Up VEuC0zkk2zU56TPVKVkJWSbOsh4vRjiM/J/DPdoGTedIK/HV1xGJyyL6sz13XngL4s v3GxvUUhMDauuj8kPrOBOzfgFslH2XcNhqdOV96k= Date: Sun, 18 Dec 2022 16:54:32 +0200 From: Laurent Pinchart To: Marek Vasut Cc: linux-arm-kernel@lists.infradead.org, Abel Vesa , Adam Ford , Alexander Stein , Ezequiel Garcia , Fabio Estevam , Jacky Bai , Krzysztof Kozlowski , Lucas Stach , Markus Niebel , NXP Linux Team , Peng Fan , Pengutronix Kernel Team , Richard Cochran , Richard Zhu , Rob Herring , Sascha Hauer , Shawn Guo Subject: Re: [PATCH v2] arm64: dts: imx8mp: Add Hantro G1, G2 DT nodes Message-ID: References: <20221218042056.328324-1-marex@denx.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221218042056.328324-1-marex@denx.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221218_065441_141690_E673B2B2 X-CRM114-Status: GOOD ( 17.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marek, Thank you for the patch. On Sun, Dec 18, 2022 at 05:20:56AM +0100, Marek Vasut wrote: > Add DT nodes for the Hantro VPU found in i.MX8MP SoC. > > Signed-off-by: Marek Vasut > --- > Cc: Abel Vesa > Cc: Adam Ford > Cc: Alexander Stein > Cc: Ezequiel Garcia > Cc: Fabio Estevam > Cc: Jacky Bai > Cc: Krzysztof Kozlowski > Cc: Laurent Pinchart > Cc: Lucas Stach > Cc: Marek Vasut > Cc: Markus Niebel > Cc: NXP Linux Team > Cc: Peng Fan > Cc: Pengutronix Kernel Team > Cc: Richard Cochran > Cc: Richard Zhu > Cc: Rob Herring > Cc: Sascha Hauer > Cc: Shawn Guo > To: linux-arm-kernel@lists.infradead.org > --- > V2: Drop the VC8000E > --- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 25 +++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index 34c2c80c47eb5..d472170ee9ff1 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -1639,6 +1639,28 @@ gpu2d: gpu@38008000 { > power-domains = <&pgc_gpu2d>; > }; > > + vpu_g1: video-codec@38300000 { > + compatible = "nxp,imx8mm-vpu-g1"; > + reg = <0x38300000 0x10000>; > + interrupts = ; > + clocks = <&clk IMX8MP_CLK_VPU_G1_ROOT>; > + assigned-clocks = <&clk IMX8MP_CLK_VPU_G1>; > + assigned-clock-parents = <&clk IMX8MP_VPU_PLL_OUT>; > + assigned-clock-rates = <700000000>; > + power-domains = <&vpumix_blk_ctrl IMX8MP_VPUBLK_PD_G1>; > + }; > + > + vpu_g2: video-codec@38310000 { > + compatible = "nxp,imx8mq-vpu-g2"; > + reg = <0x38310000 0x10000>; > + interrupts = ; > + clocks = <&clk IMX8MP_CLK_VPU_G2_ROOT>; > + assigned-clocks = <&clk IMX8MP_CLK_VPU_G2>; > + assigned-clock-parents = <&clk IMX8MP_VPU_PLL_OUT>; > + assigned-clock-rates = <700000000>; > + power-domains = <&vpumix_blk_ctrl IMX8MP_VPUBLK_PD_G2>; > + }; > + > vpumix_blk_ctrl: blk-ctrl@38330000 { > compatible = "fsl,imx8mp-vpu-blk-ctrl", "syscon"; > reg = <0x38330000 0x100>; > @@ -1650,6 +1672,9 @@ vpumix_blk_ctrl: blk-ctrl@38330000 { > <&clk IMX8MP_CLK_VPU_G2_ROOT>, > <&clk IMX8MP_CLK_VPU_VC8KE_ROOT>; > clock-names = "g1", "g2", "vc8000e"; > + assigned-clocks = <&clk IMX8MP_CLK_VPU_BUS>; > + assigned-clock-parents = <&clk IMX8MP_VPU_PLL_OUT>; > + assigned-clock-rates = <700000000>; Those three assigned-clock-rates all configure the same IMX8MP_VPU_PLL clock. It's a bit redundant, and maybe we could instead configure IMX8MP_VPU_PLL explicitly. This being said, I'm fine with this patch as-is. Reviewed-by: Laurent Pinchart > interconnects = <&noc IMX8MP_ICM_VPU_G1 &noc IMX8MP_ICN_VIDEO>, > <&noc IMX8MP_ICM_VPU_G2 &noc IMX8MP_ICN_VIDEO>, > <&noc IMX8MP_ICM_VPU_H1 &noc IMX8MP_ICN_VIDEO>; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel