Date: Wed, 14 Dec 2022 16:25:00 +0100 From: Frank Lichtenheld Message-ID: References: <1386e3cc-fc65-aa68-fa88-3639f6aec5a2@...2704...> <20221211190913.190-1-marc.becker@...2704...> MIME-Version: 1.0 In-Reply-To: <20221211190913.190-1-marc.becker@...2704...> Subject: Re: [Openvpn-devel] [PATCH v2 1/3] unify code path for adding PKCS#11 providers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit Content-Disposition: inline To: Marc Becker Cc: openvpn-devel@lists.sourceforge.net On Sun, Dec 11, 2022 at 08:09:13PM +0100, Marc Becker via Openvpn-devel wrote: > Use existing wrapper for pkcs11h_addProvider to have arguments with > "magic values" for pkcs11-helper call in a central place. > > Slot event argument to pkcs11h_addProvider has NOT been a boolean for > at least 15 years. > Luckily the default is PKCS11H_SLOTEVENT_METHOD_AUTO=0=FALSE. Change makes sense and should not change behavior AFAICT. Acked-By: Frank Lichtenheld Regards, -- Frank Lichtenheld