Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEA0BC46467 for ; Wed, 11 Jan 2023 12:26:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229555AbjAKM0x (ORCPT ); Wed, 11 Jan 2023 07:26:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238492AbjAKM0b (ORCPT ); Wed, 11 Jan 2023 07:26:31 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5E7AF5A for ; Wed, 11 Jan 2023 04:25:56 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E56A361CAB for ; Wed, 11 Jan 2023 12:25:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2F9DC433F0; Wed, 11 Jan 2023 12:25:54 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="SH1E+rYL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1673439953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+9n1uua4zWJT/BZyF0Y96QyxG38T8s3jc7xoj/TG0j8=; b=SH1E+rYLEbJcSKLaBqfV8UUNXRIMzVftLG/mb4iszRksixEf/mEgvM4A03N9iIhrtnbT4o ii8/J069qQiBcZYWEydUIVLYbMbCK+ZZ/uOBbSAEoL5OTY97oHay9xwImO+6OdUPkJX1f/ PRr8LL8FcufgZOTKSkSPYYBEcyLN6vg= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id f8545635 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 11 Jan 2023 12:25:52 +0000 (UTC) Date: Wed, 11 Jan 2023 13:25:50 +0100 From: "Jason A. Donenfeld" To: Ard Biesheuvel Cc: Greg KH , stable@vger.kernel.org Subject: Re: [PATCH stable] efi: random: combine bootloader provided RNG seed with RNG protocol output Message-ID: References: <20230110160416.2590-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Jan 11, 2023 at 09:44:34AM +0100, Ard Biesheuvel wrote: > On Tue, 10 Jan 2023 at 20:45, Jason A. Donenfeld wrote: > > > > On Tue, Jan 10, 2023 at 6:09 PM Greg KH wrote: > > > > > > On Tue, Jan 10, 2023 at 05:57:21PM +0100, Jason A. Donenfeld wrote: > > > > Thanks! IIRC, this applies to all current stable kernels (now that > > > > you've sunsetted 4.9). > > > > > > It does not apply cleanly to 5.4.y or 4.19.y or 4.14.y so can you > > > provide working backports for them? > > > > I did 5.4.y, which turned out to be hairy than I wanted. You and Ard > > can decide if you want it or not. I'll leave 4.19 and 4.14 for another > > day. > > I appreciate you spending the effort, but I'm not convinced this is > worth the risk. You are backporting new functionality (invoking the > firmware's RNG protocol at boot on x86), and we might end up > regressing on systems where the firmware's implementation is > problematic, even if the patch by itself is correct. This applies to > mixed mode especially, as the conversion between Win64 and i386 > calling conventions has kicked up some very surprising issues in the > past. Alright, yea, I was afraid that might be the case indeed. Oh well. So this means that for the purposes of systemd's usage of this, 5.10+ is the relevant cut-off. I'm noting it here because I'm sure I'll forget, and the question is bound to come up down the road. Jason