Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80DD9C38142 for ; Tue, 24 Jan 2023 14:14:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0BE9D6B0075; Tue, 24 Jan 2023 09:14:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 06F4E6B0078; Tue, 24 Jan 2023 09:14:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2BD76B007B; Tue, 24 Jan 2023 09:14:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D59B76B0075 for ; Tue, 24 Jan 2023 09:14:51 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9DBD51C6380 for ; Tue, 24 Jan 2023 14:14:51 +0000 (UTC) X-FDA: 80389888782.04.9D56B29 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2084.outbound.protection.outlook.com [40.107.92.84]) by imf09.hostedemail.com (Postfix) with ESMTP id B3106140013 for ; Tue, 24 Jan 2023 14:14:48 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=PhkZwYVw; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf09.hostedemail.com: domain of jgg@nvidia.com designates 40.107.92.84 as permitted sender) smtp.mailfrom=jgg@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674569688; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K+njodJ2VBLpNry+buY2EMdM2XjOi6T363pBkOLsiME=; b=5QoEV9IUKyRecqp2Woas9hOCfQ7h6ZQsvF4gtKRQUN4RE65zTllFVtP3Tu3oQoyNY69301 8HsOdhO5h3lkaiga4SvS9jFTb9v4o5lsfaJc+qWGgAcwHO6V2xcQQctSre9prtMvI5T14x wKlW/CtADkaaA4kh94sSf9x35vEOGFM= ARC-Authentication-Results: i=2; imf09.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=PhkZwYVw; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf09.hostedemail.com: domain of jgg@nvidia.com designates 40.107.92.84 as permitted sender) smtp.mailfrom=jgg@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1674569688; a=rsa-sha256; cv=pass; b=byCjyXexHwM7zBQJwujKiRqC69L0drKfavyKDTtJkFodxhBysu6L7QyE27t1G3q8WiDyOk v62qhCWlbbtW0p1XCfP2VPOq4jTCiYSC/z3eCm/0tENcdh58X3h5Esc16Pb0dYnBSy/Bq7 2HxtM5Sy6aqRMDH3QH58+Kldr9nVRxo= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ivslr4GFgE2R40zYmgDSwNNMzAeu0TRwsZrDwCISh+D5hPjwjVU5kR30ps2gO8kyWVkRTbLU24iuVHwKhxhSw5h/NfrsAoe+kO56HPfwSr3xFjHY6I1dtdvKhw3rc3vmLX/wmxvwpkQlAPjFJTocMWZd9wHi1g2fbq1hG8JG3qXY8NJ8y2yMccuuxvrtTV8kb2X3iMl6Zsstiw86q7cAqzTVSyCDGeKxZUCS5jOB0FdJrx5cKB7W0558lEL4UygjGlauKL6dft9ii0WJwYWBxPAenKiAxqWWEM612wMwyxgtQBK5/I98JXivBaPi2FnOjE5LwS5t9k9OG6siEp1jwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K+njodJ2VBLpNry+buY2EMdM2XjOi6T363pBkOLsiME=; b=SLKvUdr95dTmFHo/aJsWdAHJQ7D07UqV4ElWJbKFZ2ASuhIuRi0KEzXZ9tSD6okH86oEQbqidIo3vZVYoWUkL6N0tloOHCXUcbX+SluGNGdr8z3wds6vuzpCzDUG2wYJq077YW73Ta++uCxSPvdfDFb0SCHxO+KSc8wKoJgAGYqPajRMVUx1wuDekPcZObvZPp1P9cF4sWafKHC1R7QsfnKb9gxjl/I/v0ieR0PPvHAYQVAp9UMdDo9FpCrE5kHNmn4nN+skEtFyRmbec1V1I+dxmUB5NJ65qmFWUG8U6ILjlRhgres2NNDd8dU+0jKI2n0ukUpFVklzjY7ckUXAJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K+njodJ2VBLpNry+buY2EMdM2XjOi6T363pBkOLsiME=; b=PhkZwYVw36wFLyikR18rp3D4rm5nhxuaG3jOzlO4VWFHGQwuW3716CJ2G06QkAjvyDzrbqjtH1wqTYo2OcYqBYiaf+zf+j53T/OEWVzMWXIk1HIfOURGwhCmp/jFRGoygdPVSWSmdm8vvkkzRarvk8wwC8Db3BwPahS5mxYg4AdAQ/jCyTK2JM8HpxCj5FwQyOTvT8nWP3kIFpS3LNPRDr9x8t5/ha3oWisMXWDhLrMG+UDFlY6JJQZYmKwsyw8UTKkSm9swGBPb+PAs0EnGOS6zacdXlZx2TZ0IeV2lDguYPYIzr3Kkco0vdG7ePjqf+fZxhpExIfC76OEtI6b9dQ== Received: from LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) by IA0PR12MB8328.namprd12.prod.outlook.com (2603:10b6:208:3dd::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Tue, 24 Jan 2023 14:14:45 +0000 Received: from LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::3cb3:2fce:5c8f:82ee]) by LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::3cb3:2fce:5c8f:82ee%4]) with mapi id 15.20.6002.033; Tue, 24 Jan 2023 14:14:45 +0000 Date: Tue, 24 Jan 2023 10:14:44 -0400 From: Jason Gunthorpe To: David Howells Cc: John Hubbard , Al Viro , Christoph Hellwig , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , linux-mm@kvack.org Subject: Re: [PATCH v8 10/10] mm: Renumber FOLL_PIN and FOLL_GET down Message-ID: References: <20230123173007.325544-1-dhowells@redhat.com> <20230123173007.325544-11-dhowells@redhat.com> <31f7d71d-0eb9-2250-78c0-2e8f31023c66@nvidia.com> <84721e8d-d40e-617c-b75e-ead51c3e1edf@nvidia.com> <852117.1674567983@warthog.procyon.org.uk> <852914.1674568628@warthog.procyon.org.uk> <859142.1674569510@warthog.procyon.org.uk> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <859142.1674569510@warthog.procyon.org.uk> X-ClientProxiedBy: BL0PR02CA0066.namprd02.prod.outlook.com (2603:10b6:207:3d::43) To LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV2PR12MB5869:EE_|IA0PR12MB8328:EE_ X-MS-Office365-Filtering-Correlation-Id: a91cc852-0d76-45da-e572-08dafe155823 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JYwtAUUje5MAk9YKTgGT2cCXxkLunpFpjLS7hPPXLLxXj02BGKzr4AeQVqhLWpwpqzRdTsTIiAcsEky7MJ6nlCbGOtfSyEGIayMIpgKUzmlkbdh5zNkBswHYoLDeOFu3laVCXWZ+TbPxJXUKDSnriLGRRmsbRA3Uga/LR7Xvpd+iT96oPwSOV6fSV27GNKwSSw9tE0pFs92yyf0rw9zBO/JENL/YuuPmVi+yiT31dD7aMnL60L7dGab9FHZHX+qoT2TlaNGGRsx4KxIJa+qyTQaMKvlKwRppzhjrlu972P9IQR/CDVQZmVmGgT/xzzrs4kmiJC1qMRSMCtXheUsgjzvMEFl48FzZEWUrTOhSw0qfQ253lKYJgfIpb3CShP5XR5RtSfU4511RbUC2amDo9V3eQXgZcHw1XVcFt4/Gsk6L/rHfFkL6x8Cr9IBO17RwWrqVEo83857rhF/pnkp72y2H+BrTmhdCwMZsuMPxBfG24lD5+30QbKVabX6lcuXM9k2BMM7+450e0R9zyHDRAgvDgKClGPTgbg5BUtuX9/Oj4Ob2wycjncF17Tm0HNiH0zK6LAE+H44BzF7PyJhD5UpcnPO9VqPWgebxAZz4oAk1u0iJENfFU2qaMyx/wT3i1TYFCB2b4h3oIwu9P4J8Kg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV2PR12MB5869.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(396003)(376002)(136003)(346002)(451199015)(38100700002)(7416002)(41300700001)(86362001)(4744005)(2906002)(8936002)(5660300002)(4326008)(316002)(6512007)(26005)(6916009)(6506007)(186003)(8676002)(66476007)(66556008)(54906003)(2616005)(478600001)(6486002)(66946007)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?o0Ahp4q6eOWS7tyT2vfOMsPE8mQfFWBSvnwew24eglQcKe+5zXJ6jMKWStAT?= =?us-ascii?Q?XBYNhkmYmHffwP4EZgYYF9a14G2Jlby8/DahOFKgSezy9IiO2x9dY2VAiwVq?= =?us-ascii?Q?9JxSdju/AleZHch5XkkYx7uglmXSuAUATXH5NECs/SrH5Y0kVYXULG6HrcMy?= =?us-ascii?Q?/xZn/BlKa4PxLU3TujwUgsvIUozSlitFRVjAu8VOe0IJ1yOd5WGQc375pMww?= =?us-ascii?Q?YG8YSZRuL8dgnULyp9+nLejN1TtbSqql16FayTh3dE/+kGaSki086/7q56Jr?= =?us-ascii?Q?FjW1GPcS8WBfyGJdEmAVC1M2XViywyh2m3GYLhC/Fak5nrjeN9MSq9AR2hde?= =?us-ascii?Q?2OWzaEEs0MMiGAjGxO2Kb89w6m72QJtBPS91SEx5aMueSa79GYzucZ5Q1srM?= =?us-ascii?Q?EgGK+C/gFaDbQ0JcwE5UNexI4XprIbJsovRZtgM7ns6m9tGsnzpxlaCr5cF9?= =?us-ascii?Q?3a5eFMUv21O7OXbXG2RkvrSwH2ws3ilACNLwik23lIpf2XKSYbZ8p71a0jAk?= =?us-ascii?Q?faSdgrdvJnKuCIgAF0nesi5+VX+Q8T4SfnaVaAupn2kkrsuCYaen862xTRfb?= =?us-ascii?Q?56gfHSqoakEX8g0rkdJABC1y9sYSBQJOLlAquyIMTHNP9lr/Y+EcR8gcfrUF?= =?us-ascii?Q?Vz+Q27uTA6+9D0I/OFpZfas22fWLATfvMGoHTe2XyM2QC2VTn3ekHorzRkQS?= =?us-ascii?Q?cRRtqrze8OpdiRu3eOA2ojrkvN2RXAx8N62JiHQto3d3UuqLEExKW1F92lgY?= =?us-ascii?Q?mAQ453LWerEviCtBAWEj/WC1v4hc7388uB02K4M6IQT5OFDs9MCLkIfuGpkA?= =?us-ascii?Q?FJDUTm8/sw3lQBHS1ERjbI/yJzD6jm3vHBrkY0XPLqpSQqQKE4yxxWiSxsfq?= =?us-ascii?Q?nSPvAm9CFv66tW87JkMRqamwjnTnrg6dMK8tznYOQqiN0JYGWCF1kl6p2B5x?= =?us-ascii?Q?wo8Fc6YB9wTRGAWOPLyUNNmqZ6J2wEkpqGAvxdGr1vIBJvB+qMIfOO3EVSRv?= =?us-ascii?Q?nX4FbBCdYdQ18Nh0OI6+3Nn0bqMtoAmzsyswmUGOJvpwG0soElMdQg/Hwi/y?= =?us-ascii?Q?EliGJPXxCLrH6/rahBW8k68qBueQNNeiJUjLJqUSGrogJjSJHzYyyyrBydZs?= =?us-ascii?Q?O7+oAfNJjpl7/n29oLXYDA8g4LkCAJs4tzAomwu3s+oAB5b2qkl62fEJqsJ5?= =?us-ascii?Q?GkleHZfyJ9qd2OqoHzYndgwXWJzvcbzJwLjNUn/4h9dPR0YrAnPaLQ8pTg4B?= =?us-ascii?Q?DiF0IMn5U7wM8SFswncCmZ2POafbZYfd5TREyoIbyUX0dD0dTXhQx3RLjE3E?= =?us-ascii?Q?+W98wrOklLBBLxT9jiE4npHq32UNKj6T2254m10aL82If6yzLYPdghv1E9Np?= =?us-ascii?Q?4vJml8Ce0vFtJwTdWl/QV8DYDgSCZqYIkLDJ9gumrbTJlWqxqbNLrnfPBInL?= =?us-ascii?Q?yZovgnZNLBWDhsPnJ1HHKJmaI1GN7q49XJJJE8WkXVGi85TmRn92hVE2RxJf?= =?us-ascii?Q?Xf7/RePhVlD7kWT/xNEWyf8tOiryWEEai3Y8fHdutx+UnKsX87LtVADQLbTm?= =?us-ascii?Q?/+hZxxnqSGUihKBWVEDEmNPEGXPalyUmCNmY/MgC?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: a91cc852-0d76-45da-e572-08dafe155823 X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2023 14:14:45.3955 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ULytzAauRcnYl1Z0ARN44pAjTTiXMceFCYX0rOJVmDXFb8BNvva/ABmdprI/SVEx X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8328 X-Rspamd-Queue-Id: B3106140013 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 8ckoj1hrxwqw8mre4uz16jzqdf9byyif X-HE-Tag: 1674569688-95385 X-HE-Meta: U2FsdGVkX1+VjkrPoFtVBU4WWEYKT+2d5oFpAypvWlKm1TDl2G6BlloL1Fvw773ZQK6Vi6kQI8yZuozW7aYWHem8mykjLCjaltCPaRugWKbvu+oj7VT8Mu9K9ClNSExkODw5uEKy0A6WhhsHyZiKqY2tVqtA7e4BMZ2SfN/tCx8Z9qOYwBgThpmu3QYmosmxeHBmreWA94GCT3+Xws+BDScVjumVtUBLRoGNkZfLyLbwEvxhYGTTdo35n2tu044R35bDcyQ0I3zj94GDQ+WFQJcrSJ6WemPM3Wrqs9wZxJRZPR2UDNAE6cC0VwiREtTGe8RSmf083ODEGUsJY7Nsh83XlZTTrGowbYfCYl/Dd5madkAd9u7r0FhfZvbpAVDGvRlpPaMRZscvmLerulIx5+uVdHdJrgayi5yOGoyhBpLnAnbw3BYxU7bIk+XmoITDE0EXwt+SDT17uQlGAx7SoJncNBdL41eI1xO1V1HsYK5ALPvRmFeKxu9Bp2s5RJ5/xTPWDM48pIsIo+Ko+BBTyZqXIH6F+aKW8xTHeD/HxmcOWyMrugD4mIEJocp5ElzeD6V3Ln0WPvTqIE3frwrp2r49R94LeTEtbAbO8VJDTIAl+jg7sOXJOgqiDElHB+t82SiDGZRhxsD/n4+ymBpPi4VxmU+fLus43YDNErPKvESUpo8MWmB3E4mOuZFXp/+IZwlQ9FJiNfHpq2m/bKHbAaNZhvoXBkXrVDZswJdcYi9Xio9qTrU8KoKWK3iynK7o+g29W6n9vqJv5H1Aqku/cHUCfCbVUOJrFyP8+x7reBYiMteWkzwAUqUvKAzqvLuN4OFhE74yY+VccwvLlbkeqzm4T9haMA8k/9EK6GIrpS48MhztcoDz0H5kVdLk8C3rNl4JKsvvEvWenUco5qndpXwusDyHsAO4zQOoBT/hZggKgD+xbCILuu3P+DzSyQB1CtLE64MI6zTl9tFPMB4 A+DOPBZR UCIMwxAK1egh6s2XtUW71XPvJ4qXfla/iFXAQCXnQYL53HRtnYshM1k+FpufQRTh9c0hgFSqutytoOTtBj26zFkV84I+v77BDz/Fwj/w/iB7v4FsgO6uJeinf1cxR1mWjinonl9qAGeqdABVVsL2QZe9cKqbPN6ndIwW8Jd0zPJ8xqPQZbtt96stLt7Y/3TJsUrjyG9Q8ITj0HOo12m8zSEtUavTajzMzjKHUGTUrIkyULdhKa7J1KJ3gmKaNW7C7X8ER2vo8iVsa4Ca2CC8h1LG5ghsELkgmh3m3w1nsismpVd0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 24, 2023 at 02:11:50PM +0000, David Howells wrote: > Jason Gunthorpe wrote: > > > if (cleanup_flags & PAGE_CLEANUP_UNPIN) > > gup_put_folio(folio, 1, true); > > else if (cleanup_flags & PAGE_CLEANUP_PUT) > > gup_put_folio(folio, 1, false); > > gup_put_folio() doesn't take a bool - it takes FOLL_PIN and FOLL_GET: My point was to change that to take a 'bool unpin' because FOLL_PIN is not to be used outside gup.c Jason