Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFCB9C54EBD for ; Fri, 13 Jan 2023 15:47:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B818710E1CF; Fri, 13 Jan 2023 15:47:50 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8E7BF10E1CF; Fri, 13 Jan 2023 15:47:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673624867; x=1705160867; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=drD33sAx5gjjcRkozsAJSrAFVmd5zo3pbQJ6aOlk0jQ=; b=Akq2tn/JlKj7cSQA/drioYRYNEDLspO1li9QI2gSEH9wnURIygoNG114 lWj6H/rb/XfjxTP6CyeDVe9eio5DogNo2QBgiezt9DcMrE7KuLto5eI3g L4I0y+Xp8EkSCLcCrp/DKiqMpID8bRpoD4f2w0mtbB8Myu9rhEGpz+TzY EapoXPI5OcnFNLo8z53sJRkZYi4IH+D3KoLPeTxbnb6v8gXEv7MqNGRhG +TWyCxiHvyhb66IECUwNJ4uoxQiAYU1YEiUrxExE8UWo8n1+2O1Vrerta yysCjAhDQdqWT/Ok8Jw0Pg1p9oJkOAfOXREYJbIsyq4wDJgWQdV939jZQ w==; X-IronPort-AV: E=McAfee;i="6500,9779,10589"; a="307565081" X-IronPort-AV: E=Sophos;i="5.97,214,1669104000"; d="scan'208";a="307565081" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2023 07:47:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10589"; a="688784173" X-IronPort-AV: E=Sophos;i="5.97,214,1669104000"; d="scan'208";a="688784173" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.55]) by orsmga008.jf.intel.com with SMTP; 13 Jan 2023 07:47:40 -0800 Received: by stinkbox (sSMTP sendmail emulation); Fri, 13 Jan 2023 17:47:39 +0200 Date: Fri, 13 Jan 2023 17:47:39 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Sam Ravnborg Subject: Re: [PATCH v2 02/10] drm: Include where needed Message-ID: References: <20230111130206.29974-1-tzimmermann@suse.de> <20230111130206.29974-3-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: f.fainelli@gmail.com, Thomas Zimmermann , amd-gfx@lists.freedesktop.org, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, thierry.reding@gmail.com, james.qian.wang@arm.com, alexander.deucher@amd.com, bcm-kernel-feedback-list@broadcom.com, christian.koenig@amd.com, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Jan 13, 2023 at 04:11:48PM +0100, Sam Ravnborg wrote: > Hi Ville, > On Wed, Jan 11, 2023 at 06:08:42PM +0200, Ville Syrjälä wrote: > > On Wed, Jan 11, 2023 at 02:01:58PM +0100, Thomas Zimmermann wrote: > > > Include in source files that need it. Some of DRM's > > > source code gets OF header via drm_crtc_helper.h and , > > > which can leed to unnecessary recompilation. > > > > > > In drm_modes.c, add a comment on the reason for still including > > > . The header file is required to get KHZ2PICOS(). The > > > macro is part of the UAPI headers, so it cannot be moved to a less > > > prominent location. > > > > I never liked that KHZ2PICOS() thing in there. Maybe we should > > just nuke it and see if anyone notices? > https://github.com/search?q=KHZ2PICOS&type=code No idea what relevance any of those have. > > tells me that it will be noticed. > So it is part of the UAPI The only thing it does it potentially mistake some modes for being equal when they are not. So basically just second guessing what the driver/hardware is actually capable of doing. -- Ville Syrjälä Intel