From: Sam Ravnborg Date: Mon, 16 Jan 2023 21:31:34 +0100 Subject: [PATCH 18/22] drm/sun4i: Remove unnecessary include statements for drm_crtc_helper.h In-Reply-To: <20230116131235.18917-19-tzimmermann@suse.de> References: <20230116131235.18917-1-tzimmermann@suse.de> <20230116131235.18917-19-tzimmermann@suse.de> Message-ID: List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Jan 16, 2023 at 02:12:31PM +0100, Thomas Zimmermann wrote: > Several source files include drm_crtc_helper.h without needing it or > only to get its transitive include statements; leading to unnecessary > compile-time dependencies. > > Directly include required headers and drop drm_crtc_helper.h where > possible. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c > index 477cb6985b4d..37dc66332bbd 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c > +++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c > @@ -8,8 +8,8 @@ > #include > #include > > -#include > #include > +#include Move one up to maintain sorting. With that fixed: Reviewed-by: Sam Ravnborg > #include > > #include "sun8i_dw_hdmi.h" > -- > 2.39.0