Received: by 2002:a17:907:c68a:b0:84d:2074:29bb with SMTP id ue10csp1596023ejc; Mon, 16 Jan 2023 09:22:08 -0800 (PST) X-Google-Smtp-Source: AMrXdXtWngvGJxs4cn0I+kMq0VrVc56pCjMzF8J/uz0MoBkzXrJat4Q8Aa9EfJNTsPKFEny30fSp X-Received: by 2002:a05:6214:d05:b0:532:23db:c116 with SMTP id 5-20020a0562140d0500b0053223dbc116mr673800qvh.46.1673889728774; Mon, 16 Jan 2023 09:22:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673889728; cv=none; d=google.com; s=arc-20160816; b=T0M1A1LFcXNnSj6C+oJHk2tU90hvaPSTBHzDNBOIAaXnRQX2H4BeHIs8QgGdopKZid pBNNMR2h/ckqWEhOodpkd8jagmRJrUvcNoU/bQImcYAbueqEkYzCyvn0aTBAsvvfoCjj yKS37lHjhyBALcWTGm37b2dN7orauZTMArC9Qi18kEvPDZtR/dg5Gdj8JKYq47K/XPLW cjIB5ziNEUjORpghl3XV1bcWmchz/xM66dT89XuF5AkDbKQOH0iuTRikQDYrKGJxDZKI N4NF/kb2R9wxkTXnZzKKgQP75/F+HPHOZ6DMii77NdY5wPie1LfQy5g8sgBuQGywFcc9 GUaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:feedback-id :dkim-signature:dkim-signature; bh=kTa26oSJu85ii62fKpjIHRdBUYyGpGvnlndRcUnHM2Q=; b=OQv3jlU32y0AVeJce8AiVAEmuh5cXFOrjWLe6HXe148wRRfUyOpGLHZGQyopw03ZU3 MElNODvGdMaKhKMVCmWGoXs54MzT+PDlZ7X0mCpXCqPhzxEIe4ekIgONHbgSRrMS4Q7X nbaZSch3Vg4XFg/yguADCiRGuwYGWQM/LmB8BH4wZdcpQZNaQBOnLg6GJLBMtQVZ+vpz VN3jWLWatVocuoadk3Oj7Y8S04HPeILc5WhKaBEjirBABNKcloSnNFIFgEpoYmhjhPdA 25ztWTOGXxkgAMa7q/ZoDs9CfRauxt7wHQdC0sUHKLyTj34Xk8E8dCqwsMrUyGGmWETL HvHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@pjd.dev header.s=fm1 header.b=oizbbvM5; dkim=fail header.i=@messagingengine.com header.s=fm3 header.b=gq4USP2j; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id v5-20020a05620a440500b006ffd8db3445si1532148qkp.733.2023.01.16.09.22.08 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Jan 2023 09:22:08 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@pjd.dev header.s=fm1 header.b=oizbbvM5; dkim=fail header.i=@messagingengine.com header.s=fm3 header.b=gq4USP2j; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHTBL-0007WM-Vv; Mon, 16 Jan 2023 12:22:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHTBH-0007Vk-OB; Mon, 16 Jan 2023 12:21:59 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHTBG-0002qw-C2; Mon, 16 Jan 2023 12:21:59 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 28CFC3200922; Mon, 16 Jan 2023 12:21:56 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 16 Jan 2023 12:21:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pjd.dev; h=cc:cc :content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1673889715; x= 1673976115; bh=kTa26oSJu85ii62fKpjIHRdBUYyGpGvnlndRcUnHM2Q=; b=o izbbvM5Fu6biIQBlfwjkJFTy5yg/ASbXgFLKZ0Hj7rsN7XGOMTUeU39+Rt17/Dw1 XeXYlom4AwOKGKEKd2Qp6Gl75GcrmNeZga5/I7Nzd5tOhXqiEuTIbgat3O64YXrb jJi9b6zJq76CtAgVnIMXI2EZD7FXA0S6tAdxhlJ5K673iY6j29BlF2DnPlHi3Ff7 8/VLTW5KJ1x/AY9Dj2dYaRX9fYdybZTWdw3ZNtO/jEMYFdRb20m4jpWG34twjED1 SDxeP9HJCgyZ5Vll5h8oxDxQxLRVnRl74uqw5ZeNbCh2zMThwI/yXyY6FQX5YxBs vm64sFPN+2mwrO6KsGQ3g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1673889715; x= 1673976115; bh=kTa26oSJu85ii62fKpjIHRdBUYyGpGvnlndRcUnHM2Q=; b=g q4USP2jrC0s79+EgnWHvKF+E6EsVNISYJ9m40cNzpx484WFQ14Yw3aMfJIsvgvL4 +DhGW2kFiVa2WMUF2rchZG5AFP2VqlXgv4b2+ZIEKWK+sOmHLyeD8NJRMYNeHYkU EAESMn3KAYc5QVyjwiHyUL4kz+HmtlwoO5sfUIVt63ulhxd1P5pbM8Y11gP3WiMo bI/8Ojpgv6JuJyUSYMrVlaUGLxUTZAeHDIei3mg9JD4SaqNbTsT7L8A4gT1yrQer JTvudocta9t0huQP2Ot/AHURNWanl1UdPwX/j0iNfNgKMIDtJxXw8HLl21l8ffPQ v7YUrE5GcyPCbEdMLyCDQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddtgedguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtugfgjgesthekredttddtudenucfhrhhomheprfgv thgvrhcuffgvlhgvvhhorhihrghsuceophgvthgvrhesphhjugdruggvvheqnecuggftrf grthhtvghrnhephfegffevudefveetgeekteeijefhhfduueejvdegvdehffehjeevtefh hffffeeunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epphgvthgvrhesphhjugdruggvvh X-ME-Proxy: Feedback-ID: i9e814621:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 16 Jan 2023 12:21:54 -0500 (EST) Date: Mon, 16 Jan 2023 09:21:52 -0800 From: Peter Delevoryas To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: patrick@stwcx.xyz, clg@kaod.org, peter.maydell@linaro.org, andrew@aj.id.au, joal@jms.id.au, hskinnemoen@google.com, kfting@nuvoton.com, qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: Re: [PATCH 2/6] hw/arm/aspeed: Remove local copy of at24c_eeprom_init Message-ID: References: <20230114170151.87833-1-peter@pjd.dev> <20230114170151.87833-3-peter@pjd.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Received-SPF: pass client-ip=64.147.123.24; envelope-from=peter@pjd.dev; helo=wout1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: L5DwYt8jBG62 On Mon, Jan 16, 2023 at 01:24:36PM +0100, Philippe Mathieu-Daudé wrote: > On 14/1/23 18:01, Peter Delevoryas wrote: > > Signed-off-by: Peter Delevoryas > > --- > > hw/arm/aspeed.c | 10 +--------- > > 1 file changed, 1 insertion(+), 9 deletions(-) > > > -static void at24c_eeprom_init(I2CBus *bus, uint8_t addr, uint32_t rsize) > > -{ > > - I2CSlave *i2c_dev = i2c_slave_new("at24c-eeprom", addr); > > - DeviceState *dev = DEVICE(i2c_dev); > > - > > - qdev_prop_set_uint32(dev, "rom-size", rsize); > > - i2c_slave_realize_and_unref(i2c_dev, bus, &error_abort); > > -} > > Why not squash in previous commit as 'extract helper' change? +1, I'll squash this. > > Anyhow, > Reviewed-by: Philippe Mathieu-Daudé > >