Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECC2EC05027 for ; Fri, 3 Feb 2023 18:52:38 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DDA4985F5C; Fri, 3 Feb 2023 19:52:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="CgrQRBeQ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5B45585F66; Fri, 3 Feb 2023 19:52:34 +0100 (CET) Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BDCD485EF9 for ; Fri, 3 Feb 2023 19:52:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x830.google.com with SMTP id h24so6626037qtr.0 for ; Fri, 03 Feb 2023 10:52:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=12Q6M3APE4bl6mZZaWpZkwSFqzXbiUluAMjjdZNqqxo=; b=CgrQRBeQGe6Hldvbfwn5vR+2EsgPgYSTmkFvlCDqhcHAk1WkwKY9XleivPj7MDN9lu 3d6LmUgMj+JbBdMvqIboXbmKABr/d8yKADRw9YEcq89jWz/LGKIkXKYvb5t8hNb7dTBc ilnGwQ0uOaRViHicnnv6Xpulto13z2idgR9H8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=12Q6M3APE4bl6mZZaWpZkwSFqzXbiUluAMjjdZNqqxo=; b=rtJYKHNV9HnsEkbiaLFPrwujkVAqIfX2bnLJAMpH+Mmnk26sVnzQc9IeFB9HNhIhvl Lsz6vCzCfSQ7geKHVNos+xOjgTQ5co53UMXnS0W+3WnC6SAsZE++GZvhHFAyr7TKGSE1 EkQJhvTDAl6Zlz2rkr79uZXcC/teP0VfLByuP3V7wy4VoF0hhwN23xV7MVpoDXCwdVDq 94GFhcKpTno3+oIk88GI67HwjItyY3pBLnodFZj3Kn9EyAirppbMZWBhq7oYgMuo034J HmDqEBHBMnEp/91TT5Fpbb5NcHP7wHsUo0OyaQAwScsbC9fQ4yX8uP7mAOf0aQ6KfgFZ w70w== X-Gm-Message-State: AO0yUKV0xh8jqlz9H9Yth7H4ZvmhM21M9ZjWDfxrotVZlQmeBjKUIDpI IB+jpOORX+FsAvemU6MtmMeneo8gzNkiPndqs/Y= X-Google-Smtp-Source: AK7set/1VoHa+e9IxBn47jwzvBW9GdrdsDxy/Hsm131EgLvMeWWPvbTU2pzSUzguOO/hhD9BkwBeog== X-Received: by 2002:ac8:7f43:0:b0:3b8:33b5:a7ec with SMTP id g3-20020ac87f43000000b003b833b5a7ecmr21225871qtk.22.1675450350581; Fri, 03 Feb 2023 10:52:30 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-d049-1ce1-b939-5115.res6.spectrum.com. [2603:6081:7b00:6400:d049:1ce1:b939:5115]) by smtp.gmail.com with ESMTPSA id j24-20020ac84058000000b003b635a5d56csm2073873qtl.30.2023.02.03.10.52.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 10:52:30 -0800 (PST) Date: Fri, 3 Feb 2023 13:52:28 -0500 From: Tom Rini To: Jan Kiszka Cc: U-Boot Mailing List Subject: Re: [PATCH V5 05/12] iot2050: Add CONFIG_ENV_FLAGS_LIST_STATIC Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7QuK/+Pren88bDJQ" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --7QuK/+Pren88bDJQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 03, 2023 at 01:26:34PM +0100, Jan Kiszka wrote: > From: Jan Kiszka >=20 > Will be needed when CONFIG_ENV_WRITEABLE_LIST is enabled. The listed > variables shall remain writable, for informational purposes - they have > to be considered untrusted because the persistent U-Boot env is not > protected. >=20 > Signed-off-by: Jan Kiszka > --- > include/configs/iot2050.h | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/include/configs/iot2050.h b/include/configs/iot2050.h > index 5186dfd8ff8..52094e18ea8 100644 > --- a/include/configs/iot2050.h > +++ b/include/configs/iot2050.h > @@ -56,4 +56,12 @@ > =20 > #include > =20 > +#ifdef CONFIG_ENV_WRITEABLE_LIST > +/* relevant for secure boot with CONFIG_ENV_WRITEABLE_LIST=3Dy */ > +#define CONFIG_ENV_FLAGS_LIST_STATIC \ > + "board_uuid:sw,board_name:sw,board_serial:sw,board_a5e:sw," \ > + "mlfb:sw,fw_version:sw,seboot_version:sw," \ > + "eth1addr:mw,eth2addr:mw,watchdog_timeout_ms:dw,boot_targets:sw" > +#endif > + > #endif /* __CONFIG_IOT2050_H */ I don't think you've tested the whole series on top of current master, this needs to be CFG_ENV_FLAGS_LIST_STATIC. If this is the only thing that needs changing, I can just correct this while applying, otherwise a v6, and I'll try my best to not forget to grab this before -rc2, I know this whole series has been waiting a while so I thank you for your patience and persistence here. --=20 Tom --7QuK/+Pren88bDJQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPdV+wACgkQFHw5/5Y0 tyxeKwwAiy8gdhQn75lzWNN/USTsHfnJ1ra5lL0yv0DYiMv2wd/d4/4g4I5qC6EL cKIhScrMKePKvteA9NV6kRRoGXMpcPy5vYLNelOzPktIQ6pju+ZZBfgFgnT95dAL M890wenTxUyCEACnxdL352lUF1oqs2/SitB2evp+3YHWY0HTdLOkzkAjanBfDsl4 lK9qiu37CU4l8fwt/zDKkQC592vYbMTL7NNnoCZZmBH602BEtQTFODPt602yCCN7 8KVjH58EC17PLpN8jtxTZ1mFyRuI9H/RK65nkxocRvgWgIUpG8be3EFTEATtNd+M Ohrw18iAhq1WZk20qLd+Env36OFPKbDJYlZg4HYox0RQj95XDqoL3gVznPHd/uOB yKiXxUdRpmEVN5mzRytJ2CPBTEP49uQXWS7kfzCEzDB+cNr5yCXrkEVAh2dYQ+kY iXNwhDnJwTLUx6lb4temBzFJMiPw2k6Xs7qnMMhyc8wSFtZwRphdZg02A40QjQnE OWfsXNOr =qZtj -----END PGP SIGNATURE----- --7QuK/+Pren88bDJQ--