Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31912C05027 for ; Fri, 3 Feb 2023 22:12:37 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BBD4D85FD5; Fri, 3 Feb 2023 23:12:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="O1oXMn/V"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7E8B285FD3; Fri, 3 Feb 2023 23:12:32 +0100 (CET) Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 012FC85F91 for ; Fri, 3 Feb 2023 23:12:29 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x834.google.com with SMTP id h24so7170638qta.12 for ; Fri, 03 Feb 2023 14:12:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=khHvlG457xWTgUVM0vzh2Uc3q7yJ+ucJFDaV3z5NwHY=; b=O1oXMn/VzJrb3PjDDV+FkwwVf74V9Dj1TNsjSn4zgvKz9Bt9/dgP9qQsKmOYiRcEBX 1fja62B5fHXseSI20dZoLFJx6h/4K9iyRGNpIdmcXOz+7OjmOkh7j7u8bD74COXeeGqn s2XparMEUdbr0uxjcAn9Otd0JARNv8VueGN8Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=khHvlG457xWTgUVM0vzh2Uc3q7yJ+ucJFDaV3z5NwHY=; b=UuO+Fgl9tsGjNeJtDj2qryP88xjYjg3zkIzEttm2cYGcRAVDqEFFmp6llZT3GAbN4h 5QunWElhMhrdzg2F+vCKZs6WS62H5lE+XvYElm/3PuV9MuMW9rS2ehhfqkwUV9fjQX+F BNQPDEATI8oALWYn0KdJ88gcNvPjVoh0R+EOXkNOaRref+b3Po4MEFQFiz2nnefnqlVh 9d2Rppp2/uLpiobDOnwr7+TK6uzZ4Obm3dfehM2Aqn+93U23W0j2UW3zc50S7IZIZAb3 Hpv7GvkKFDGD3aJ4i2aWlMdnefX5x0QUTn4iqJi/Y2TFVIJQ2KbfC+JtOTuGaR5c1mTk gydA== X-Gm-Message-State: AO0yUKXTYcCow1xS5CFLInqdRsib9VYFKsaldQltljwaVtyhqQyuQ/Io ETe+Em8WqCjJ8eMSOXje1Cz4kQ== X-Google-Smtp-Source: AK7set/s4AgVZEaN23jW/k+Sb4BNMeSSnjtWnLpqPNHeRBPPa84Hngc8JTloc49YhFuW0QrKsBJ3xg== X-Received: by 2002:a05:622a:60e:b0:3ba:1113:751a with SMTP id z14-20020a05622a060e00b003ba1113751amr2667627qta.67.1675462348694; Fri, 03 Feb 2023 14:12:28 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-1319-d221-b7f9-9bb1.res6.spectrum.com. [2603:6081:7b00:6400:1319:d221:b7f9:9bb1]) by smtp.gmail.com with ESMTPSA id 16-20020a05620a049000b0072692330190sm2614707qkr.64.2023.02.03.14.12.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 14:12:28 -0800 (PST) Date: Fri, 3 Feb 2023 17:12:26 -0500 From: Tom Rini To: Simon Glass Cc: seanedmond@linux.microsoft.com, u-boot@lists.denx.de, joe.hershberger@ni.com, rfried.dev@gmail.com, v.v.mitrofanov@yadro.com, seanedmond@microsoft.com Subject: Re: [PATCH 1/2] net: dhcp6: Add DHCPv6 (DHCP for IPv6) Message-ID: References: <20230202002626.32335-1-seanedmond@linux.microsoft.com> <20230202002626.32335-2-seanedmond@linux.microsoft.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1VcBX86lJEEuqpUM" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --1VcBX86lJEEuqpUM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 02, 2023 at 10:12:04AM -0700, Simon Glass wrote: > Hi, >=20 > On Wed, 1 Feb 2023 at 17:26, wrote: > > > > From: Sean Edmond > > > > Adds DHCPv6 protocol to u-boot. > > > > Allows for address assignement with DHCPv6 4-message exchange > > (SOLICIT->ADVERTISE->REQUEST->REPLY). Includes DHCPv6 options > > required by RFC 8415. Also adds DHCPv6 options required > > for PXE boot. > > > > New configs added: > > - CMD_DHCP6 > > - DHCP6_PXE_CLIENTARCH > > - DHCP6_PXE_DHCP_OPTION > > - DHCP6_ENTERPRISE_ID > > > > Possible enhancements: > > - Duplicate address detection on DHCPv6 assigned address > > - IPv6 address assignement through SLAAC > > - Sending/parsing other DHCPv6 options (NTP, DNS, etc...) > > > > Signed-off-by: Sean Edmond > > --- > > cmd/Kconfig | 26 ++ > > include/net.h | 8 +- > > net/Makefile | 1 + > > net/dhcpv6.c | 741 ++++++++++++++++++++++++++++++++++++++++++++++++++ > > net/dhcpv6.h | 212 +++++++++++++++ > > net/net.c | 12 + > > 6 files changed, 998 insertions(+), 2 deletions(-) > > create mode 100644 net/dhcpv6.c > > create mode 100644 net/dhcpv6.h >=20 > Can you write a sandbox test for this? See test/dm/eth.c This should be like our existing dhcp test I think, under test/py/tests/test_net.py --=20 Tom --1VcBX86lJEEuqpUM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPdhscACgkQFHw5/5Y0 tyxqPQwAtvFKz7m0OG43RPXLzMswuR77z7qSdj/0csy6+z4KaoP5Wb/kMESSwDbr 5Z2/6+Sx+v/WjvVlcCifjkamiG1crSKNhZ8bkv7vGfUsNzc9Q4cUOM3MFNWtFB/L kpHTYm4a6dqkKmE43rYFBYDmph05nLXhYdBycZWd41kaXSQzZbhPYptBYGN7S736 gUwJ1g6thchtu+/xLR8jPH8wu+6ko5509J1aH4Fjo5sAAmowGFacglb5Fw49npiX 3ElsRs4XIpO5t+20/F0YIqDcy7yEsu6AJGt0aq8TMA2yG6CIsqeAx3dYZbN2UMKq g3Yd/xPnhvgkrVL72+VLDlT3tiLFTcuIC9i9t0DdjSQ+kZ3M2Sp2ZscfUZGo2POK OKYPPQyIjTLIga2Sy7rNRlhL1nCPHubuepLRugbTTD4dsF6p5oUVQbk+WT1g0vc3 Zid8FNv83iWluw11zw/kPmJpQJRrWVcB36IMApKh4skV5vjHRSSH8DPmxH+P6L3m HrKQVsdV =JkMA -----END PGP SIGNATURE----- --1VcBX86lJEEuqpUM--