Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1pKjHK-0008QV-VF for mharc-grub-devel@gnu.org; Wed, 25 Jan 2023 12:09:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKjHI-0008P4-Ka for grub-devel@gnu.org; Wed, 25 Jan 2023 12:09:40 -0500 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKjHF-00026v-V7 for grub-devel@gnu.org; Wed, 25 Jan 2023 12:09:40 -0500 Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30PFPxMJ014171; Wed, 25 Jan 2023 17:09:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2022-7-12; bh=Q/R8w/XzVW/PokUCPNgEHABWpHIuhwHrTzNicCikeNA=; b=M7igK+PPfVNUDpuH/iTEVOMoaHsLmjEjzEd/nt4RsCgEhNqD5xRnp9+QVSu78IJ6UrfR +zIYLvH1cE3tAsbiwM/MBtTvjp8SdrP2+ttnZX+XfuPjhGwOqatPV9++rhMF02Ltb9/a wWrDM8e6kkYtiMIQTuY+alzlsKt69w/v0Mj2LuUkfFt7kRW2C1FjRVgkJUxqod9Ij8Dj zkgq1unfq6SgZRCwd+n3kwX2L5Ow8n/1F7Mh5oyVG/L7mDG3hdg40GUdpyAtmrayarug WJw2fQr0Qo7MsaCWR2uQ9Ee+eobWl+mc8LHV4A1UoAe5R0KrpWFZNixZrjhsf63bcAQv 0A== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3n87xa8g1c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Jan 2023 17:09:30 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 30PGGDRp019146; Wed, 25 Jan 2023 17:09:29 GMT Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam02lp2047.outbound.protection.outlook.com [104.47.51.47]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3n86gd5p56-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Jan 2023 17:09:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M5+X0yekLjZxLVJSCka/giNZ/HbCxToAw0Cn7SyjxlSZM+B2khmMPeBD/YdOwwoiXbSMw8FBnx1AxLfsflHaNnncGXkHGVmajr8gRdmkzca/R9CPzR0vfpjcfEvXqQPWe9PQV+6gSKvi8b00no1/SbCCCcAeHQKAcFVLdKzcUxzKJcETlPqGjte1h42kdwV644g3RGfEB1rmk8sv27RAG295wUkzhpUdZwgVptsup8j4R6lt7IqEhI2WH/GkQilnqryb41GoWfasEdLmszSYtivJqX9UGSnfKarXPbaSLwWeQgqMwSvGVeDyOx5I3uaZ/C2j82yJ2FHuRW+g8ZS/xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q/R8w/XzVW/PokUCPNgEHABWpHIuhwHrTzNicCikeNA=; b=D099qP8YQkninuKgzxs1GyJ2R+9+JspanhAqO1bLRRi19hXlBKxm5NDribqQyXkfY6TGge1C8mV9VCjKXOkP9txxdqZun2vNEtB5sQe7DmkQ/jJ67sKGUN+dFwARWvr8Z0z3TV14VgfjPDNZAuJtHkTJurZ0ll5ueXzR/8Ih2kQOLzkHBJem6rBkWaL3IOjUEWAXgN7Q236/snogOOMNqFrEeTxd9wjGlrWZEAo8fr18FE9jn6xfAu3Xr8MlGXZ9k8e5wHN+R8m6Rk61ieZa9dtuEHnC/AwwxQtdvw1WxOD5XXgStvAYKoFVMlOfJTFiULLctAaSqNhlf3HPEex2xg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q/R8w/XzVW/PokUCPNgEHABWpHIuhwHrTzNicCikeNA=; b=LCr+siJdw2ljUwdJ2emfnx7khs6aTvdoKviR4XGcOnbYnu8YqTUSXkHKfrOjEmKevI5QGgqyxP4Zh8dO6kyIVFjCE1JNB4bhsQsl5+sc2yxOnA/oRStAr3Mazm5Dp1fB8ozqlXGq+14JbCzPbIK4d0SVM6emEytBbZ/sosNvPik= Received: from BN0PR10MB4822.namprd10.prod.outlook.com (2603:10b6:408:124::13) by SJ0PR10MB5804.namprd10.prod.outlook.com (2603:10b6:a03:428::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.16; Wed, 25 Jan 2023 17:09:27 +0000 Received: from BN0PR10MB4822.namprd10.prod.outlook.com ([fe80::8781:9b5f:7205:b8b7]) by BN0PR10MB4822.namprd10.prod.outlook.com ([fe80::8781:9b5f:7205:b8b7%8]) with mapi id 15.20.6043.020; Wed, 25 Jan 2023 17:09:26 +0000 Date: Wed, 25 Jan 2023 18:09:21 +0100 From: Daniel Kiper To: Lidong Chen Cc: grub-devel@gnu.org, scdbackup@gmx.net, fengtao40@huawei.com, yanan@huawei.com, lichenca2005@gmail.com Subject: Re: [PATCH v3 0/5] fs/iso9660: Fix out-of-bounds read Message-ID: References: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: BE1P281CA0081.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:78::19) To BN0PR10MB4822.namprd10.prod.outlook.com (2603:10b6:408:124::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN0PR10MB4822:EE_|SJ0PR10MB5804:EE_ X-MS-Office365-Filtering-Correlation-Id: bdc79080-fedd-47d3-37d9-08dafef6e9ef X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x1GJfACUtUM2fwXnWMQPFKl255Zj2m//ztiOKjkkzllUEk73w69E/4lZf+LOFXqKKFCVq6GBfM54a9rXUkDtUFwSGEywsyY+OFWGHFcBKE4YKeIjp66PF5/9ebhoSdrJ7YlxcgK+dEvtU0vU6L+x9BpacaZELQfGFnzK5jAdJIdjbVQ3z4zLOs4Z7Sqr19thtRGhMeeb1e62BwFgu3g8ZNioihfyzCiuhhx5/eTX2Xm+XPDyLXNXIA621Jw474tmzAzAffchyX4wFBDPHvielVBCyf8fVsWYkgB31rtQLLlx724dA6gI8Sa21YXgZLK/fKmr1Tn+4h08chMgyGMNMfHT0+jEBxQEvwj/XXPx/THBqWE3YEPV9yunlPx8HS53BntDMXwXVx2R2qmft+XJwwR6WVxplqGHFER3MIGvl2ijsMfWotSl+bJtPeQ0VR+WxFxvLPtGXnxFFpCaBWa9Nu3BXBn+hN9C+tQdDNxCTuUPXlIxu5js/HXvwBg397mFXz2Zej+CyGCzvwG8hSI7pdmPTAnvCi5VnBQyOYVMe34ADvqrVhwbdJtOL8BRm3PO+69wOqYxyc2ay/2rkIeQZhNjyYW3WnkrzpcdGvN6ifhpaEBWKQQHO3akJBQSuTBA7/1N0mkjHKNdiGi2cYaxvg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN0PR10MB4822.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(366004)(136003)(376002)(396003)(39860400002)(346002)(451199018)(6512007)(6486002)(8936002)(9686003)(83380400001)(186003)(478600001)(38100700002)(6506007)(5660300002)(44832011)(66946007)(8676002)(66556008)(2906002)(4744005)(66476007)(6862004)(26005)(316002)(86362001)(6666004)(4326008)(41300700001)(6636002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XSIz6vjYCH1gGDb3sYDWosGg9YaX38AhlzRvwZayPMqpXiHZ8XCSYXgJEJ36?= =?us-ascii?Q?UZdg83Fkd2G1ExpArfG8/sFjgIVmdjzqE2rtUGD5lOVjooesqjyJlb8k4jst?= =?us-ascii?Q?UhnrRjRtIUMunZUgWzo2frHTDUo9yjcKVSGgT6U1VxstDEXmaHQzVaQ1Umop?= =?us-ascii?Q?mN33up2HdkNGAHHr+OQV0N6HGg9LZPSCYMI7RQ/m28ZowTAQ+CBS3/7cfkji?= =?us-ascii?Q?5DoYfcKpwfATlPzDsffd+b1qJMMI866TArincr5uhyBRQL8HC3+ysCrfhSLQ?= =?us-ascii?Q?46/TirZRWMMcBdTBmX8N4xOsw3Ie6Uqv8ov7Gt9uJTY01HXz/lEQzWxORmns?= =?us-ascii?Q?/jxHKpLixXSWxvfdEc8AM6xEvGYwr07/FWrXfvQcfBS+xrdQzjEksJ8GFc05?= =?us-ascii?Q?gkWcDoj/oM3vY8qYa6Mhsgl+yfR4MPkpDZV/Gx2RGJVQ3YJJnYqE20zw8IYp?= =?us-ascii?Q?0s8zy15frklxc8UxEzWlPWJ3IskUwrtQQ+2SH0rrIGAgpdJAU1o6EPfJZzU4?= =?us-ascii?Q?yf0iNPZXCY3xSQF23cm3MJUqa/mkESa8Pde9LaGQIwb4HmJQOWT2Bb0l+r1Q?= =?us-ascii?Q?4NIEk6rLchoLkORAcAMyWjxI9DChBIzr84kJDapAmJbnm10m9Eheh+IdfZ2Y?= =?us-ascii?Q?tuDC6ikj2jPSh52V6BAroPsBf21C441vUKWT35+ekiyaaJ7nu9frvtSmd2Vm?= =?us-ascii?Q?ud1mZ1mKbskLSDIxn0FWz5KxKAgvoyhuWefsKsFBbtQzaW3Zg1HsE8xJGNth?= =?us-ascii?Q?CGKX85N0S7iYrNixmHwvjSNK7NHF0iGmtzuHmByij7jJNkwh+oiVWYP5rGfw?= =?us-ascii?Q?r4OLjEd6Fn1vsxgeZN0oLDk0tdJKcVbaNbRCNH5QYP4iX07HdwsjodXZ+pi8?= =?us-ascii?Q?lzUFMLfBoZdg9rg8ReVB8s7TP8Mxg+4kdT7dSTpb+KETYj8Lj0mQ0JgTRqpR?= =?us-ascii?Q?okaZ5356ukgHWpYMVo8Owre6/pEMEOcnxeN8x24T3AtOgYf4KOiaBU0Mz+qX?= =?us-ascii?Q?V2iCAGndJSbgjDKkI7o4ZgvbISgzYBu0Gs8CVUkg5Jw6FckYfGsDUYgFIkEz?= =?us-ascii?Q?PjsinQfEXk1Kyy3IbeAfXNMmskXmaiHOOViFJ8WO1xRhbq1SSnuzWbrHdmfN?= =?us-ascii?Q?GGskfXmR5BtY6DdCA89RnZeWJw/r4jmGDNLHfKq0WW6qbpF4PMRUlFq2B91z?= =?us-ascii?Q?t2QMK9g+TZNmKIJqHl6PHHX2n0VqUGnJiNVvNaP9/1c+RysBd/dbzcytWcJa?= =?us-ascii?Q?mCWkllH/IYvFPrUmHxbCvRue3l/f4TQyGzr/p0xzXpDydwkFCymgqmaSBc4j?= =?us-ascii?Q?K8kO50XgwnYzSH2dVCGXHKZLrCqm6Rda7/IzotU7W8Nl4FDhQwVs0rUyg/UO?= =?us-ascii?Q?QIFAo5OjzVStkvng4rmZI1FbqI8dcAPMxOIjY9flQVzzpe6bjHuCxhtVVQtj?= =?us-ascii?Q?bDdwjOnogm2Mhop9cAmn+arrBfteQX2UU03yoxQiZ+7QQkbBEW8OBY5BnsMx?= =?us-ascii?Q?bYeZgySe+iy/QJqJDir/S4uWsozaRlAUKqtAX+c2ZjqrJS/sI4QEOMG26wz0?= =?us-ascii?Q?CNd81RaPH0Oy3U4cqjY84PphDK+KD5MKXZSozaJa7BwFl5LEXUKBYfGZy03K?= =?us-ascii?Q?tw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 6M/t/JWLR8LLFOMGWEYu4p3T9UMOoG0KRhiwIA7bdqPM8WZjt7RV80TUr5cYpfEtKkBjgwdFWeXfjYuDPwNgW3WPDOmZGGf3hiGQlpE6gjX8pE/NyOZgOOfiZrWR0jS7Mt4MKgKo6mQv0/7X+szsTud7QEO/9cQK0Djg8Aoy9TNf4i8eqhpfp4veD/ogGhyrxHR/3hoc5OqZWCszSYQdvpGeCRbb7NVSfR/QoBnw5Ffq9EUJ2gZ6uskVWciBHHY+e0My7wJNty/avT3bPu4ltHZwPOHt4puyPSilQhpIy5U23U2HrjX7eLV1FmuRJkf0hcA4fEAt3Ude6ud1v/iA/xPoRix27eBXdtTtYEjXDYQc0a6VzDhmAt1pn74giO1VtqpDNKtY2/I0hd0IOzK/LVRpf8UAxggO98OA/w0GnisWQ5mDN0KjG4bzOYHpbDqPYau2lUJB7fT9MvGV2ZBqhogSIOZpaZg5SgVpTY3l0hya2ZccX9O+KEVWWxgzbdEya8eHm1EZgf8SBsWB75FY4I13lXxD4oWdYtZsDScxOL52Ti0595CtMWGCSIvqStm0jYUNC/mJ24QlpFmxOhReLPZiMdZFCawUdynCX3xG4fvyrV8cyGnQICh6w30O1Ask9b03q657Vw1nVE972wyHCfZKqLwHkgohBgXvHBLToOSbeurqjI2LsSg0xvslhSXk7TXjFZBbiYKuorKVRH7rGJ9H79QktRC+pFnERMdInKZhdAYpVT+XPzbRHVq2fOi012XIlFrykIG5p+4/p8voeCJ0dl8f5P0f5YLQ6bHr0ZP3oIWRSNyoGkKTciWtJ5/q X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: bdc79080-fedd-47d3-37d9-08dafef6e9ef X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB4822.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2023 17:09:26.8243 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 218Wio1RyFSbPiGjmyz/rhSFnAKa72iPLy5k6Fx+9bR6mBIAq8PpI9ZmOa675tGPeW/JGt3c4OTZuTcDlA8N1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5804 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-25_11,2023-01-25_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 mlxlogscore=999 adultscore=0 mlxscore=0 suspectscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301250153 X-Proofpoint-GUID: CydWdXdB6htOoB_h_A86ls6_hCyd9asG X-Proofpoint-ORIG-GUID: CydWdXdB6htOoB_h_A86ls6_hCyd9asG Received-SPF: pass client-ip=205.220.165.32; envelope-from=daniel.kiper@oracle.com; helo=mx0a-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jan 2023 17:09:41 -0000 On Fri, Jan 20, 2023 at 07:39:37PM +0000, Lidong Chen wrote: > This v3 patches set addressed v2 review comments for patch 5. > There is no changes to patch 1 to 4. Tested patch 5, the fixes > were able to detect the endless loop, and Grub exited accordingly. > > Lidong Chen (5): > fs/iso9660: Add check to prevent infinite loop > fs/iso9660: Prevent read past the end of system use area > fs/iso9660: Avoid reading past the entry boundary > fs/iso9660: Incorrect check for entry boundary > fs/iso9660: Prevent skipping CE or ST at start of continuation area For all the patches Reviewed-by: Daniel Kiper ... Lidong, Thomas, I thank both of you for patiently working on these fixes! Thomas, it would be nice if you could add the broken ISOs images which you used for tests to the tests in the GRUB. If you do that please CC Glenn. Daniel