Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E26B8C54EAA for ; Sat, 28 Jan 2023 01:13:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232433AbjA1BNk (ORCPT ); Fri, 27 Jan 2023 20:13:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229478AbjA1BNj (ORCPT ); Fri, 27 Jan 2023 20:13:39 -0500 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D61378AD1 for ; Fri, 27 Jan 2023 17:13:21 -0800 (PST) Received: by mail-pj1-x1036.google.com with SMTP id b10so6241566pjo.1 for ; Fri, 27 Jan 2023 17:13:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=s9NIl2COXvudH/2TUG9HlbD55DTPEYr6JyawT6Piovw=; b=p4IXFD1+GOy/BO49wCddjWpLy5JQM8MnJTHFNoTElf6AZhyIt8EPeWvp0c4DqdIGSQ 2EV4p6C2IMe/vU/P7Pp8HganiqNDO7swiau1HH7n70wA1GoaFM+kjD42e2A+xcEyntFc 7+4/mk0BpC+dnTjhVe+qYU4E6Zl2lSLBQWCX9WMdYJ78TFw4Qd6byQJk+pzt0oMnIyIt A568qWJSreYSMCcxUMjdN89Gj5gBIFTpU1pGk5AW+7rb/9ZI2A6Cvcnz1RQa/Wq63ISx QJmJb+8+ma3NepcE1oYZqV+tY4OToCVIdeyxNWC6nmfvrAGhbxPyn1Uoe2YQRmq72NEC 0DZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=s9NIl2COXvudH/2TUG9HlbD55DTPEYr6JyawT6Piovw=; b=gVaz8bG5GuXeYrmln299eLdHr6aQ8FpXMko6dTFfXU2Z2p9Pz+VOVz0mxmPtjK9tJe WZOP16qt/5wREo5qbF4+yAkCkI/W1Yvp1PmiZA+Rx9cEF6ri1vqVgw2psn27+/ymsB1R wTnIER5ppUvrLiSM8i1pDqAzQymN9w3l+dV3iv7zZ67wLveQK/VGsRj//ZG/IvTnS8gq iJCxYOPvDeyf2Y6BwESNRvSD4AMX7vr++Teel3JdF0sfVMZDOOtVdq21IYLBLKM2Ke+S NfinSFJO2nbc4bHC/xGEOJ+H89qbOed6W/2h1E8al86nVsmgauNzPMduIqFSkkxMqPXM KvYg== X-Gm-Message-State: AO0yUKXGNitAHl/5t//PaaoioGln4swn5M2gF719vCBeWhRWs3N4DKpP O0FafUW5T1ETB4p6HXpR/y7+BA== X-Google-Smtp-Source: AK7set99eTIGPlT9GdoLO1Rx+rLUJeqv7QqQJTZpeEKKsGbhDnnOkhVg/9JFaBS7dtXLkrh1VQTdtw== X-Received: by 2002:a05:6a21:33aa:b0:b9:14e:184b with SMTP id yy42-20020a056a2133aa00b000b9014e184bmr244186pzb.3.1674868400563; Fri, 27 Jan 2023 17:13:20 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id b10-20020a17090a9bca00b00218cd71781csm3330017pjw.51.2023.01.27.17.13.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jan 2023 17:13:20 -0800 (PST) Date: Sat, 28 Jan 2023 01:13:16 +0000 From: Sean Christopherson To: Maxim Levitsky Cc: kvm@vger.kernel.org, Sandipan Das , Paolo Bonzini , Jim Mattson , Peter Zijlstra , Dave Hansen , Borislav Petkov , Pawan Gupta , Thomas Gleixner , Ingo Molnar , Josh Poimboeuf , Daniel Sneddon , Jiaxi Chen , Babu Moger , linux-kernel@vger.kernel.org, Jing Liu , Wyes Karny , x86@kernel.org, "H. Peter Anvin" Subject: Re: [PATCH v2 00/11] SVM: vNMI (with my fixes) Message-ID: References: <20221129193717.513824-1-mlevitsk@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221129193717.513824-1-mlevitsk@redhat.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Nov 29, 2022, Maxim Levitsky wrote: > Hi! > > This is the vNMI patch series based on Santosh Shukla's vNMI patch series. > > In this version of this patch series I addressed most of the review feedback > added some more refactoring and also I think fixed the issue with migration. > > I only tested this on a machine which doesn't have vNMI, so this does need > some testing to ensure that nothing is broken. Apologies for the slow review. Did a fast run through, mostly have questions to address my lack of knowledge. I'll give this a much more thorough review first thing next week (my brain is fried), and am planning on queueing it unless I see someone truly busted (I'll fixup my nits when applying).