Date: Wed, 1 Feb 2023 12:56:38 +0100 From: Frank Lichtenheld Message-ID: References: <20230128223421.2207802-1-selva.nair@...277...> <20230128223421.2207802-5-selva.nair@...277...> MIME-Version: 1.0 In-Reply-To: <20230128223421.2207802-5-selva.nair@...277...> Subject: Re: [Openvpn-devel] [PATCH 4/4] cryptoapi.c: simplify parsing of thumbprint hex string List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit Content-Disposition: inline To: selva.nair@...277... Cc: openvpn-devel@lists.sourceforge.net On Sat, Jan 28, 2023 at 05:34:21PM -0500, selva.nair@...277... wrote: > From: Selva Nair > > Signed-off-by: Selva Nair > --- > src/openvpn/cryptoapi.c | 44 +++++++++++------------------------------ > 1 file changed, 12 insertions(+), 32 deletions(-) > > diff --git a/src/openvpn/cryptoapi.c b/src/openvpn/cryptoapi.c > index 6ff4fcb5..9fd5aea9 100644 > --- a/src/openvpn/cryptoapi.c > +++ b/src/openvpn/cryptoapi.c > @@ -210,49 +210,29 @@ find_certificate_in_store(const char *cert_prop, HCERTSTORE cert_store) This seems to ask for a unittest. Regards, -- Frank Lichtenheld