Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EF31C433DB for ; Thu, 14 Jan 2021 22:50:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3CA0623977 for ; Thu, 14 Jan 2021 22:50:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730815AbhANWtq (ORCPT ); Thu, 14 Jan 2021 17:49:46 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:41602 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729214AbhANWtq (ORCPT ); Thu, 14 Jan 2021 17:49:46 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1l0BQM-000eFG-Hy; Thu, 14 Jan 2021 23:49:02 +0100 Date: Thu, 14 Jan 2021 23:49:02 +0100 From: Andrew Lunn To: Russell King Cc: Heiner Kallweit , "David S. Miller" , netdev@vger.kernel.org, Jakub Kicinski Subject: Re: [PATCH net-next] net: phy: ar803x: disable extended next page bit Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jan 12, 2021 at 10:59:43PM +0000, Russell King wrote: > This bit is enabled by default and advertises support for extended > next page support. XNP is only needed for 10GBase-T and MultiGig > support which is not supported. Additionally, Cisco MultiGig switches > will read this bit and attempt 10Gb negotiation even though Next Page > support is disabled. This will cause timeouts when the interface is > forced to 100Mbps and auto-negotiation will fail. The interfaces are > only 1000Base-T and supporting auto-negotiation for this only requires > the Next Page bit to be set. > > Taken from: > https://github.com/SolidRun/linux-stable/commit/7406c5244b7ea6bc17a2afe8568277a8c4b126a9 > and adapted to mainline kernels by rmk. > > Signed-off-by: Russell King Reviewed-by: Andrew Lunn Andrew