Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCDCEC433DB for ; Tue, 19 Jan 2021 15:59:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC8D92137B for ; Tue, 19 Jan 2021 15:59:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC8D92137B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5ED5D89D4A; Tue, 19 Jan 2021 15:59:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 757E38941E for ; Tue, 19 Jan 2021 15:59:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CiCcK8kv/Yj149qFwcqQoyTY88+W1ZWU1NJwVOAOfc4=; b=DDjDNtz5vMzyzBRgKTPlpNMs0o wLMnHTJ5KOZriOQPORNhpLqDv4ZLqQUEWnin3+QBappbgTk8geOKPZ33x+YU6Rem7yLNFcWdVeCPR BV2x8XHjWL9qlleBptJLZXNqBUHf5J0cypVxnHfyEhsHiPKTVaXXE6Rnx7oO3DcxA6AkrthVIkIrW fnOWvAHr9HvsO32NH/NKRwl5WwZymW8cWDPn59LeOSHWCgqB31Ue7HuOfVBbuQt5vjIWBnE1Xhr2v SxdsG90FlEwSgWHfJPZKWepO6CKYpDoZbC6bUWop+mR51PbsEpHbJRWLSp/Y46/qmdAvUutG3DMQY 0wEUp4cQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1tQ8-0006qS-NQ; Tue, 19 Jan 2021 15:59:52 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id B41F6300F7A; Tue, 19 Jan 2021 16:59:48 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 8015820290D21; Tue, 19 Jan 2021 16:59:48 +0100 (CET) Date: Tue, 19 Jan 2021 16:59:48 +0100 From: Peter Zijlstra To: Daniel Vetter Subject: Re: [PATCH] drm/syncobj: make lockdep complain on WAIT_FOR_SUBMIT v3 Message-ID: References: <20210119114841.2003-1-christian.koenig@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christian =?iso-8859-1?Q?K=F6nig?= , dri-devel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jan 19, 2021 at 02:05:09PM +0100, Daniel Vetter wrote: > > diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h > > index b9e9adec73e8..6eb117c0d0f3 100644 > > --- a/include/linux/lockdep.h > > +++ b/include/linux/lockdep.h > > @@ -310,6 +310,10 @@ extern void lock_unpin_lock(struct lockdep_map *lock, struct pin_cookie); > > WARN_ON_ONCE(debug_locks && !lockdep_is_held(l)); \ > > } while (0) > > > > +#define lockdep_assert_none_held_once() do { \ > > + WARN_ON_ONCE(debug_locks && current->lockdep_depth); \ > > + } while (0) > > + > > #define lockdep_recursing(tsk) ((tsk)->lockdep_recursion) > > > > #define lockdep_pin_lock(l) lock_pin_lock(&(l)->dep_map) > > @@ -387,6 +391,7 @@ extern int lockdep_is_held(const void *); > > #define lockdep_assert_held_write(l) do { (void)(l); } while (0) > > #define lockdep_assert_held_read(l) do { (void)(l); } while (0) > > #define lockdep_assert_held_once(l) do { (void)(l); } while (0) > > +#define lockdep_assert_none_held_once() do { } while (0) > > > > #define lockdep_recursing(tsk) (0) > > ofc needs ack from Peter, but drm parts look all good to me. Acked-by: Peter Zijlstra (Intel) _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel