From: Petr Vorel Date: Wed, 27 Jan 2021 16:07:27 +0100 Subject: [LTP] [PATCH v3 2/7] can: Add can_common.h for vcan device setup In-Reply-To: References: <20210120143723.26483-1-rpalethorpe@suse.com> <20210120143723.26483-3-rpalethorpe@suse.com> <058a6f05-d5ca-0746-dc4e-007253d3a84d@hartkopp.net> <87bldd9t9i.fsf@suse.de> <20210126212855.GC15365@pevik> <64f599af-f2a7-901d-06a6-a5ff56a107a2@hartkopp.net> <87im7i94iu.fsf@suse.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi Richie, ... > > I wonder Petr, is it still necessary to define IFF_ECHO now only > > is included? Or do they somehow symlink linux/if.h -> > > net/if.h? > No. > > Indeed it seems the current version of uclibc-ng doesn't include > > IFF_ECHO in . OTOH musl does define it. > Yes => please keep that definition in can_common.h (enough here, we don't have > to bother with if.h when we don't have it yet). > And I'll send tonight patch to uclibc-ng. > The more mature musl is the less relevant uclibc-ng is. Just for a record, I was wrong. Using is enough, no need to keep definition on can_common.h. Sorry for wasting your time. I mixed two problems: and conflict (there are more headers which conflict) [1] and sometimes missing definition on uclibc-ng. *But* musl defines IFF_ECHO in as they try to allow people not having to depend on , which is IMHO better than blindly relying on which glibc and uclibc{,-ng} (which follows glibc) does much more than musl: $ git grep '^#include ' |wc -l 43 # glibc 37 # uclibc-ng 3 # musl Kind regards, Petr [1] https://sourceware.org/glibc/wiki/Synchronizing_Headers#Known_Pairs_of_Headers_that_Conflict