Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1l7bIv-0006O6-AS for mharc-qemu-trivial@gnu.org; Thu, 04 Feb 2021 04:52:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48916) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7bIt-0006Mu-3Q; Thu, 04 Feb 2021 04:51:59 -0500 Received: from mta-02.yadro.com ([89.207.88.252]:54060 helo=mta-01.yadro.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7bIl-0005GO-Be; Thu, 04 Feb 2021 04:51:58 -0500 Received: from localhost (unknown [127.0.0.1]) by mta-01.yadro.com (Postfix) with ESMTP id 3FD024124F; Thu, 4 Feb 2021 09:51:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yadro.com; h= in-reply-to:content-disposition:content-type:content-type :mime-version:references:message-id:subject:subject:from:from :date:date:received:received:received; s=mta-01; t=1612432306; x=1614246707; bh=7oxOfChya2pP3wumcjlwjFp9dz+XbBxdRVEi82PfkV0=; b= soGCmKjRCgLWhtH8i6j9LkvM+vDoLv/xhu2+m20rbr49RljZMzn8VBwEEJhm7hgv bENsT0W1+61inJjL5ezUtrKqkaOtAv4098DpHtFdCkCfEfjrotuf2ndECBOKh3cs C3rIaAaHhfyVGccPBucrYG+s6SLj442XLd+m0IfQtxc= X-Virus-Scanned: amavisd-new at yadro.com Received: from mta-01.yadro.com ([127.0.0.1]) by localhost (mta-01.yadro.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id waO__zykndef; Thu, 4 Feb 2021 12:51:46 +0300 (MSK) Received: from T-EXCH-03.corp.yadro.com (t-exch-03.corp.yadro.com [172.17.100.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mta-01.yadro.com (Postfix) with ESMTPS id BBE5040416; Thu, 4 Feb 2021 12:51:46 +0300 (MSK) Received: from localhost (172.17.204.212) by T-EXCH-03.corp.yadro.com (172.17.100.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.32; Thu, 4 Feb 2021 12:51:46 +0300 Date: Thu, 4 Feb 2021 12:51:45 +0300 From: Roman Bolshakov To: CC: , , , Subject: Re: [PATCH v3] target/i386/hvf: add vmware-cpuid-freq cpu feature Message-ID: References: <20210114194703.134333-1-yaroshchuk2000@gmail.com> <20210122150518.3551-1-yaroshchuk2000@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210122150518.3551-1-yaroshchuk2000@gmail.com> X-Originating-IP: [172.17.204.212] X-ClientProxiedBy: T-EXCH-01.corp.yadro.com (172.17.10.101) To T-EXCH-03.corp.yadro.com (172.17.100.103) Received-SPF: pass client-ip=89.207.88.252; envelope-from=r.bolshakov@yadro.com; helo=mta-01.yadro.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Feb 2021 09:51:59 -0000 On Fri, Jan 22, 2021 at 06:05:18PM +0300, yaroshchuk2000@gmail.com wrote: > From: Vladislav Yaroshchuk > > For `-accel hvf` cpu_x86_cpuid() is wrapped with hvf_cpu_x86_cpuid() to > add paravirtualization cpuid leaf 0x40000010 > https://lkml.org/lkml/2008/10/1/246 > > Leaf 0x40000010, Timing Information: > EAX: (Virtual) TSC frequency in kHz. > EBX: (Virtual) Bus (local apic timer) frequency in kHz. > ECX, EDX: RESERVED (Per above, reserved fields are set to zero). > > On macOS TSC and APIC Bus frequencies can be readed by sysctl call with > names `machdep.tsc.frequency` and `hw.busfrequency` > > This options is required for Darwin-XNU guest to be synchronized with > host > > Leaf 0x40000000 not exposes HVF leaving hypervisor signature empty > > Signed-off-by: Vladislav Yaroshchuk > --- > target/i386/hvf/hvf.c | 96 ++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 95 insertions(+), 1 deletion(-) > I'd prefer to have generic expose-accel option for CPU and vmware-cpuid-freq=on would depend on expose-accel=on. Regardless of that, Reviewed-by: Roman Bolshakov Tested-by: Roman Bolshakov Thanks, Roman