Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D026C433E0 for ; Tue, 9 Feb 2021 00:55:50 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0618164E77 for ; Tue, 9 Feb 2021 00:55:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0618164E77 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D95AB6E1BD; Tue, 9 Feb 2021 00:55:48 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id E753E6E1BD for ; Tue, 9 Feb 2021 00:55:46 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0EE87583; Tue, 9 Feb 2021 01:55:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1612832144; bh=546XL7xvfL+LHfS20TPPogFKXmYg6uzn09ILuWcX4WQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k4O6FiQMMKQ6cBYRJ5jRsDWoUYRiw+BOA6T8Uw7QvLZoRVVGeAXooKnmfJ2MBsS4p irVBm61yDhYnP9U+A7vtglGHhvoRLJnnMPbzdwFdaBp1QWw90DG7pabLEKztc/MiNx ldEbqEpdlm54OOSjSMHBAWxwDvDcVFhwRzqq4WH4= Date: Tue, 9 Feb 2021 02:55:19 +0200 From: Laurent Pinchart To: Mykyta Poturai Subject: Re: [PATCH 2/2] dt-bindings: display: Add "disable-hpd" binding Message-ID: References: <20210131095701.965147-1-ddone@aruko.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210131095701.965147-1-ddone@aruko.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Rob Herring , Kieran Bingham Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Mykyta, Thank you for the patch. On Sun, Jan 31, 2021 at 11:57:01AM +0200, Mykyta Poturai wrote: > Add the "disable-hpd" binding, used to disable hotplug detected > functionality in the driver. When it's enabled the driver assumes that > the connector is always connected and disables the hotplug detect > related IRQ. > > Signed-off-by: Mykyta Poturai > --- > .../devicetree/bindings/display/bridge/renesas,dw-hdmi.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt > index 3f6072651182..b2b899f46b86 100644 > --- a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt > @@ -39,6 +39,7 @@ Optional properties: > > - power-domains: Shall reference the power domain that contains the DWC HDMI, > if any. > +- disable-hpd: Disables the hotplug detect feature A similar property has been added to the ti,sn65dsi86 bindings in commit 1dbc979172af ("dt-bindings: drm/bridge: ti-sn65dsi86: Document no-hpd"). A property with the same name exists in panel-common.yaml. Could we standardize on that name ? The description should also explain the hardware architecture, not the driver behaviour. This is what the ti,sn65dsi86 binding documents: no-hpd: type: boolean description: Set if the HPD line on the bridge isn't hooked up to anything or is otherwise unusable. You could use the same description, assuming this is the use case you want to support. Could you perhaps describe your problem in a bit more details ? Do you have a system with an HDMI panel that is always connected, with the HPD signal of the dw-hdmi not connected ? > Example: -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel