From: Cyril Hrubis Date: Tue, 2 Mar 2021 15:02:28 +0100 Subject: [LTP] Determinism issue for swapon/swapoff tests In-Reply-To: References: Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi! > I've been ensuring the ltp binaries/packages used by Yocto Project > are reproducible. I've sent two patches which address most of the issues, > the remaining one was with the swapon/swapoff tests. > > The challenge there is they share libswapon.o. There is a race over > building it depending on whether swapon or swapoff is built first. > The issue is that in one case "../swapon/libswapon.c" is referenced > in libswapon.o and in the other, "libswapon.c" is referenced. This > means the build isn't deterministic/reproducible. > > I've worked around this in Yocto Project by executing: > > "make -C XXX/testcases/kernel/syscalls/swapon/" > > before running the main compile. That ensures we're deterministic > but I wanted to mention the issue in case you had a better solution > to fix the Makefiles? Actually we recently introduced top level libs directory for code shared between multiple tests, so the best course of action would be to move the libswapon.c there. -- Cyril Hrubis chrubis@suse.cz