Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BF57C433DB for ; Sun, 28 Mar 2021 20:41:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 13E5A61953 for ; Sun, 28 Mar 2021 20:41:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231213AbhC1UlC (ORCPT ); Sun, 28 Mar 2021 16:41:02 -0400 Received: from maynard.decadent.org.uk ([95.217.213.242]:37098 "EHLO maynard.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229950AbhC1Uk4 (ORCPT ); Sun, 28 Mar 2021 16:40:56 -0400 Received: from [2a02:1811:d34:3700:3b8d:b310:d327:e418] (helo=deadeye) by maynard with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lQcDP-0001w4-MR; Sun, 28 Mar 2021 22:40:55 +0200 Received: from ben by deadeye with local (Exim 4.94) (envelope-from ) id 1lQcDO-003GZt-Ue; Sun, 28 Mar 2021 22:40:54 +0200 Date: Sun, 28 Mar 2021 22:40:54 +0200 From: Ben Hutchings To: stable@vger.kernel.org Cc: Lee Jones , "Luis Claudio R. Goncalves" , Florian Fainelli Subject: [PATCH 01/13] futex: Use smp_store_release() in mark_wake_futex() Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Q5NbVCB82Ekm7uuL" Content-Disposition: inline X-SA-Exim-Connect-IP: 2a02:1811:d34:3700:3b8d:b310:d327:e418 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on maynard); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org --Q5NbVCB82Ekm7uuL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable =46rom: Peter Zijlstra commit 1b367ece0d7e696cab1c8501bab282cc6a538b3f upstream. Since the futex_q can dissapear the instruction after assigning NULL, this really should be a RELEASE barrier. That stops loads from hitting dead memory too. Signed-off-by: Peter Zijlstra (Intel) Cc: juri.lelli@arm.com Cc: bigeasy@linutronix.de Cc: xlpang@redhat.com Cc: rostedt@goodmis.org Cc: mathieu.desnoyers@efficios.com Cc: jdesfossez@efficios.com Cc: dvhart@infradead.org Cc: bristot@redhat.com Link: http://lkml.kernel.org/r/20170322104151.604296452@infradead.org Signed-off-by: Thomas Gleixner Signed-off-by: Ben Hutchings --- kernel/futex.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/futex.c b/kernel/futex.c index 796b1c860839..e112a9d4c84f 100644 --- a/kernel/futex.c +++ b/kernel/futex.c @@ -1565,8 +1565,7 @@ static void mark_wake_futex(struct wake_q_head *wake_= q, struct futex_q *q) * memory barrier is required here to prevent the following * store to lock_ptr from getting ahead of the plist_del. */ - smp_wmb(); - q->lock_ptr =3D NULL; + smp_store_release(&q->lock_ptr, NULL); } =20 /* --Q5NbVCB82Ekm7uuL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAmBg6dYACgkQ57/I7JWG EQmcAxAAhvYXwZMjH93SO06Z7nyRUfu72eES3OQvO0d/81zKFpYoCLeVir+h68k5 8PgssV6xhRLVNNmLK6AVHLs0YTMyXJ8Dhz6/6XGdwUAdqwK+ycDEJe8mkLp+gAIz hUoOoDexn5S1/peLgEJQxd02UtG6ABxuZMREJwrlzms2RAZOSawh/fuKN9ujIyYE lwIVSStObnjJK5woeWb/r8NaPGu7AOV2RR3TdQGOZubkKi5sNqs21zw9ARbocKcY COLlAu7APn0ENH6mNPIoYM+MmTLMngQrQrYnogY0yJLXKXiM9BNtILvaVsLnbSVy NtTnBFgMxVgnd72CjQq0dEBepYncgyxeE8/fscJCK0xaUHOaUY49QlnYWv5RcJjA N0ZY4cvd3HvQq3AE/2Y/5z26GfJPJCswM0o/Lhm4MacqNcR8h5lBurMfrtt/V2DG xdkengc0JwmneDDS9npCSTxFaOENcKHTSzxbmLFpRBZegVJJwqIbSdS1Oo7FqBfA xTLaXdLKXclw+7kK5E1IqPHfBKKTSpAbn8pcSHivxLIYWvj5JGSz2ZEU1w3z/IKC Y1HiuPKnKAiqDOtthavfxOMy/NBRK8JYHulN+ARgk8pyhQqNeh9nvI+l6Qv8RpNj st19Gh8uzPytT6JSGZZKynUsw8MB5yEIIum/eHiHiHlkZS+Fn3Y= =YzZ2 -----END PGP SIGNATURE----- --Q5NbVCB82Ekm7uuL--