Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAFF2C433ED for ; Mon, 5 Apr 2021 00:59:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93DC16138E for ; Mon, 5 Apr 2021 00:59:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93DC16138E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0F5CD6E0E9; Mon, 5 Apr 2021 00:59:34 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3FE0B6E0E9 for ; Mon, 5 Apr 2021 00:59:32 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B06C1D40; Mon, 5 Apr 2021 02:59:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1617584370; bh=vfFmpNJF/fiC2qTs4S5P4oYV9/Rjj51A1zCLqAj61Ag=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c/cYoodP20+9+bb1rkYiNbOu6k4O/M5qnuNWvP5kmaoV0Qlw0rnIk7Cok/O/4KeQy KmkFAXeegKyc61qJNvIxWff6v2sPnFezEVIO+2JsReAcatNQoRt1H224cBjGwhM0tx HKe+SQDQW2SAo3aQOlV7SwL2UljxxB7t1fNHwr1k= Date: Mon, 5 Apr 2021 03:58:46 +0300 From: Laurent Pinchart To: Douglas Anderson Subject: Re: [PATCH v3 06/12] drm/bridge: ti-sn65dsi86: Get rid of the useless detect() function Message-ID: References: <20210402222846.2461042-1-dianders@chromium.org> <20210402152701.v3.6.I826adf4faeb7f39f560b387f6b380e639c6986c8@changeid> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210402152701.v3.6.I826adf4faeb7f39f560b387f6b380e639c6986c8@changeid> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robdclark@chromium.org, Jernej Skrabec , dri-devel@lists.freedesktop.org, Jonas Karlman , David Airlie , linux-arm-msm@vger.kernel.org, Neil Armstrong , linux-kernel@vger.kernel.org, Steev Klimaszewski , Bjorn Andersson , Stanislav Lisovskiy , Andrzej Hajda , Robert Foss , Stephen Boyd , Sam Ravnborg Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Doug, Thank you for the patch. On Fri, Apr 02, 2021 at 03:28:40PM -0700, Douglas Anderson wrote: > If we just leave the detect() function as NULL then the upper layers > assume we're always connected. There's no reason for a stub. > > Signed-off-by: Douglas Anderson > Reviewed-by: Andrzej Hajda Reviewed-by: Laurent Pinchart > --- > > (no changes since v1) > > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > index e30460002c48..51db30d573c1 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > @@ -306,20 +306,8 @@ static struct drm_connector_helper_funcs ti_sn_bridge_connector_helper_funcs = { > .mode_valid = ti_sn_bridge_connector_mode_valid, > }; > > -static enum drm_connector_status > -ti_sn_bridge_connector_detect(struct drm_connector *connector, bool force) > -{ > - /** > - * TODO: Currently if drm_panel is present, then always > - * return the status as connected. Need to add support to detect > - * device state for hot pluggable scenarios. > - */ > - return connector_status_connected; > -} > - > static const struct drm_connector_funcs ti_sn_bridge_connector_funcs = { > .fill_modes = drm_helper_probe_single_connector_modes, > - .detect = ti_sn_bridge_connector_detect, > .destroy = drm_connector_cleanup, > .reset = drm_atomic_helper_connector_reset, > .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel