From: Roman Gushchin Subject: Re: [PATCH v3 1/2] mm: memcg/slab: Properly set up gfp flags for objcg pointer array Date: Wed, 5 May 2021 09:46:39 -0700 Message-ID: References: <20210505154613.17214-1-longman@redhat.com> <20210505154613.17214-2-longman@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=facebook; bh=BEpaIDP5RFuqf5+6IRNmCEX0RBS4oU0O6eTJreg0IOE=; b=FNs/wzerMcTEirrKb6mebm7CTV83Lumxtefo3xfoSmTwtXZHhXX5oXqVyKol1miHs0Sl aMnMJPgXOuKGex1Pm4C+XPpSH3G6juEKXOLpQug2shgWUStFP704c673TGDKs6R5BIEE 4ZMXa3NItOGJcGSwkoyegBSr1C5CuruH70A= Content-Disposition: inline In-Reply-To: <20210505154613.17214-2-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-ID: Content-Transfer-Encoding: 7bit To: Waiman Long Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Shakeel Butt , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org On Wed, May 05, 2021 at 11:46:12AM -0400, Waiman Long wrote: > Since the merging of the new slab memory controller in v5.9, the page > structure may store a pointer to obj_cgroup pointer array for slab pages. > Currently, only the __GFP_ACCOUNT bit is masked off. However, the array > is not readily reclaimable and doesn't need to come from the DMA buffer. > So those GFP bits should be masked off as well. > > Do the flag bit clearing at memcg_alloc_page_obj_cgroups() to make sure > that it is consistently applied no matter where it is called. > > Fixes: 286e04b8ed7a ("mm: memcg/slab: allocate obj_cgroups for non-root slab pages") > Signed-off-by: Waiman Long > --- > mm/memcontrol.c | 8 ++++++++ > mm/slab.h | 1 - > 2 files changed, 8 insertions(+), 1 deletion(-) Acked-by: Roman Gushchin Thanks!