From: Borislav Petkov Subject: Re: [PATCH] x86/thermal: Fix LVT thermal setup for SMI delivery mode Date: Thu, 27 May 2021 21:01:35 +0200 Message-ID: References: <373464e3-b8a0-0fe0-b890-41df0eecf090@nurealm.net> <1f6c70f4-6680-d6ea-465a-548dc7698317@nurealm.net> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1622142097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=3McnNCepB5hW/fju+vVEoOY+HqLuey0+yRIpnzxlez8=; b=BQ3DtOWZmcw2ASN1yYM0XjgySvZ2JuWGx5TB1e7aQFx3lFDZzauJQ4xr5m/3soSaMkrG+b K23V3prSqm1wCykboY6Z/V1DuQinqBcdQLVtaKwS2Y9YC5hiHJcZc8LNXiKz/obMfIyyN9 iEZpMgNjNzwUhFOuvcmv0r1jG2MYTnI= Content-Disposition: inline In-Reply-To: List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Srinivas Pandruvada Cc: Borislav Petkov , James Feeney , linux-smp@vger.kernel.org, Jens Axboe , lkml , Zhang Rui , x86-ml On Thu, May 27, 2021 at 11:09:59AM -0700, Srinivas Pandruvada wrote: > My guess is that system is booting hot sometimes. SMM started fan or > some cooling and set a temperature threshold. It is waiting for thermal > interrupt for temperature threshold, which it never got. Are you saying that that replication of lvtthmr_init to the APs in intel_init_thermal() is absolutely needed on those SMI machines running hot? That thing: * If BIOS takes over the thermal interrupt and sets its interrupt * delivery mode to SMI (not fixed), it restores the value that the * BIOS has programmed on AP based on BSP's info we saved since BIOS * is always setting the same value for all threads/cores. ? Me moving that lvtthmr_init read later would replicate the wrong value because we'd soft-disable the APIC and thus the core would lockup waiting... The other interesting thing is that the core would always lockup when trying to IPI another core to remote-flush the TLBs. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette