From: Borislav Petkov Subject: Re: [PATCH] x86/thermal: Fix LVT thermal setup for SMI delivery mode Date: Thu, 27 May 2021 13:56:59 +0200 Message-ID: References: <373464e3-b8a0-0fe0-b890-41df0eecf090@nurealm.net> <1f6c70f4-6680-d6ea-465a-548dc7698317@nurealm.net> <87h7io8kh5.ffs@nanos.tec.linutronix.de> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1622116621; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=SAOBNM/TdWmKVJtnca/J3NIttsNpU6/kPggS1hONNPM=; b=GsE0NG9O3hlWuFbsWHM/CwAt4dnpyz2PFFcBKTeq7CqvKMbQeUTY+v1qFEbNpbGTRRdEod MWAUBleTu3okjBk+5hSi2XkUrnzX4PEXZbxajJ7k5eyaBXrAusPeZ71pAeYeNkGk5xw5O9 mrjU1eBI12dis2KgeEhc8QCVJL3SyyE= Content-Disposition: inline In-Reply-To: <87h7io8kh5.ffs@nanos.tec.linutronix.de> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Thomas Gleixner Cc: James Feeney , linux-smp@vger.kernel.org, Jens Axboe , lkml , Zhang Rui , Srinivas Pandruvada , x86-ml On Thu, May 27, 2021 at 01:49:42PM +0200, Thomas Gleixner wrote: > That works, but TBH, it's a hack.... Yeah, it restores to the previous behavior. > What I really fail to understand is how disabling that LVT entry makes > the machine lock up. The observation is is that on James' box, *sometimes* - not always - it would softlockup on CPU0 without this early LVT thermal read. I can try to reproduce on the box I have here, lemme see... > Also if disabling this entry is causing the BIOS/SMM gunk to go south, then > disabling CONFIG_X86_THERMAL_VECTOR should have the same effect. > > Which made me look at other places like lapic_suspend/resume which does > the save/restore Kconfig conditional as well. The fact that it doesn't reproduce always shows that there's something else at play too. As I said in the commit message: "Those soft lockups are not 100% reproducible and the reason for that can only be speculated as no one tells you what SMM does." -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette