Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80A95C4708F for ; Fri, 4 Jun 2021 15:46:00 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0510D6140B for ; Fri, 4 Jun 2021 15:45:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0510D6140B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=blueri.se Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2B06382C9B; Fri, 4 Jun 2021 17:45:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=blueri.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 5428E82CC0; Fri, 4 Jun 2021 17:45:56 +0200 (CEST) Received: from pwildt.genua.de (pwildt.genua.de [80.154.94.49]) (using TLSv1.3 with cipher TLS_CHACHA20_POLY1305_SHA256 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0032E82B8D for ; Fri, 4 Jun 2021 17:45:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=blueri.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=patrick@blueri.se Received: from mini.fritz.box (p200300c1c72389009c39944bc57ba271.dip0.t-ipconnect.de [2003:c1:c723:8900:9c39:944b:c57b:a271]) by pwildt.genua.de (OpenSMTPD) with ESMTPSA id 29b9c595 (TLSv1.3:AEAD-CHACHA20-POLY1305-SHA256:256:NO); Fri, 4 Jun 2021 17:45:50 +0200 (CEST) Date: Fri, 4 Jun 2021 17:45:48 +0200 From: Patrick Wildt To: Anand Moon Cc: u-boot@lists.denx.de, Neil Armstrong , Kever Yang Subject: Re: [PATCHv3 2/3] pci: pcie_dw_rockchip: Drop the unused variable warning Message-ID: References: <20210604045607.1003-1-linux.amoon@gmail.com> <20210604045607.1003-2-linux.amoon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210604045607.1003-2-linux.amoon@gmail.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Am Fri, Jun 04, 2021 at 04:56:06AM +0000 schrieb Anand Moon: > Drop the unused variable warning below. > > drivers/pci/pcie_dw_rockchip.c:161:6: warning: unused variable > 'val' [-Wunused-variable] > 161 | u32 val; > | ^~~ > Cc: Patrick Wildt > Cc: Neil Armstrong > Cc: Kever Yang > Reviewed-by: Neil Armstrong > Signed-off-by: Anand Moon > --- > V1 > V2: Added Neil review tags. > --- > drivers/pci/pcie_dw_rockchip.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/pci/pcie_dw_rockchip.c b/drivers/pci/pcie_dw_rockchip.c > index 3ac2434b69..4e448c0a3d 100644 > --- a/drivers/pci/pcie_dw_rockchip.c > +++ b/drivers/pci/pcie_dw_rockchip.c > @@ -158,8 +158,6 @@ static inline void rk_pcie_writel_apb(struct rk_pcie *rk_pcie, u32 reg, > */ > static void rk_pcie_configure(struct rk_pcie *pci, u32 cap_speed) > { > - u32 val; > - > dw_pcie_dbi_write_enable(&pci->dw, true); > > clrsetbits_le32(pci->dw.dbi_base + PCIE_LINK_CAPABILITY, > -- > 2.31.1 > Reviewed-by: Patrick Wildt