Content-Type: multipart/mixed; boundary="===============7254922562177684145==" MIME-Version: 1.0 From: Andy Shevchenko To: kbuild-all@lists.01.org Subject: Re: [PATCH v1 1/1] device property: Unify access to of_node Date: Fri, 04 Jun 2021 18:55:54 +0300 Message-ID: In-Reply-To: <202106042250.BjbSOQc0-lkp@intel.com> List-Id: --===============7254922562177684145== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Fri, Jun 04, 2021 at 10:55:05PM +0800, kernel test robot wrote: > Hi Andy, > = > I love your patch! Perhaps something to improve: Definitely. Thanks for report! > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > = > All warnings (new ones prefixed by >>): > = > drivers/base/property.c: In function 'device_dma_supported': > >> drivers/base/property.c:875:48: warning: passing argument 1 of 'to_acp= i_device_node' discards 'const' qualifier from pointer target type [-Wdisca= rded-qualifiers] > 875 | return acpi_dma_supported(to_acpi_device_node(fwnode)); > | ^~~~~~ > In file included from drivers/base/property.c:10: > include/linux/acpi.h:768:77: note: expected 'struct fwnode_handle *' b= ut argument is of type 'const struct fwnode_handle *' > 768 | static inline struct acpi_device *to_acpi_device_node(struct f= wnode_handle *fwnode) > | ~~~~~~~~= ~~~~~~~~~~~~~~^~~~~~ > drivers/base/property.c: In function 'device_get_dma_attr': > drivers/base/property.c:890:48: warning: passing argument 1 of 'to_acp= i_device_node' discards 'const' qualifier from pointer target type [-Wdisca= rded-qualifiers] > 890 | attr =3D acpi_get_dma_attr(to_acpi_device_node(fwnode)); > | ^~~~~~ > In file included from drivers/base/property.c:10: > include/linux/acpi.h:768:77: note: expected 'struct fwnode_handle *' b= ut argument is of type 'const struct fwnode_handle *' > 768 | static inline struct acpi_device *to_acpi_device_node(struct f= wnode_handle *fwnode) > | ~~~~~~~~= ~~~~~~~~~~~~~~^~~~~~ -- = With Best Regards, Andy Shevchenko --===============7254922562177684145==--