Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 885E5C48BCF for ; Wed, 9 Jun 2021 10:02:01 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02CFE60E08 for ; Wed, 9 Jun 2021 10:01:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02CFE60E08 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id ED11916A2; Wed, 9 Jun 2021 12:01:07 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz ED11916A2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1623232918; bh=y5GJQnLC5JKowffTHGX+5L4qB6tZi5mbQC7TJaTdqA0=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=s5n/vvC7GEChmOHC7QalddMsTuKQjpsdt08i8nXgtWAkehCfKBRQ4fOBvLh07GITQ Qp+EvpWKEXp23V4jG1koGxJ3Qz+oWVbDoCPR4+XFuQx1SuGyzYdsXZcVo2jbxsW2Tc ZMwDFlFrNqvjE7aBzLQKSA66xjpsz/ENp/KkSYtU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7F0CAF80212; Wed, 9 Jun 2021 12:01:07 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 81EA4F8026C; Wed, 9 Jun 2021 12:01:06 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D0D58F8020D for ; Wed, 9 Jun 2021 12:00:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D0D58F8020D Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="o7Ttiboe" Received: by mail.kernel.org (Postfix) with ESMTPSA id 8AFE8610C7; Wed, 9 Jun 2021 10:00:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623232857; bh=y5GJQnLC5JKowffTHGX+5L4qB6tZi5mbQC7TJaTdqA0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o7TtiboeaC9i5+GoW2tlvaLfkj5+LTxTt8huuypnB0ni0Rwub23LvYoIHtC36vRym CPtz+TRzM9zXtmC3iehyz473znFAUDDkC0K+GUhAdY+ILrdAiyqL6A6qX39DePKcpz x3+q8mmpiCovvoMx/My8c7S7vUp/ZVe8MnHx5jyc= Date: Wed, 9 Jun 2021 12:00:54 +0200 From: Greg Kroah-Hartman To: Mark Brown Subject: Re: [PATCH] ASoC: rt5645: Avoid upgrading static warnings to errors Message-ID: References: <20210608160713.21040-1-broonie@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210608160713.21040-1-broonie@kernel.org> Cc: alsa-devel@alsa-project.org, Liam Girdwood , Phillip Potter X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Jun 08, 2021 at 05:07:13PM +0100, Mark Brown wrote: > One of the fixes reverted as part of the UMN fallout was actually fine, > however rather than undoing the revert the process that handled all this > stuff resulted in a patch which attempted to add extra error checks > instead. Unfortunately this new change wasn't really based on a good > understanding of the subsystem APIs and bypassed the usual patch flow > without ensuring it was reviewed by people with subsystem knowledge and > was merged as a fix rather than during the merge window. > > The effect of the new fix is to upgrade what were previously warnings on > static data in the code to hard errors on that data. If this actually > happens then it would break existing systems, if it doesn't happen then > the change has no effect so this was not a safe change to apply as a fix > to the release candidates. Since the new code has not been tested and > doesn't in practice improve error handling revert it instead, and also > drop the original revert since the original fix was fine. This takes > the driver back to what it was in -rc1. > > Fixes: 5e70b8e22b64e ("ASoC: rt5645: add error checking to rt5645_probe function") > Fixes: 1e0ce84215dbf ("Revert "ASoC: rt5645: fix a NULL pointer dereference") > Signed-off-by: Mark Brown > Cc: Greg Kroah-Hartman > Cc: Phillip Potter > --- > sound/soc/codecs/rt5645.c | 49 +++++++++------------------------------ > 1 file changed, 11 insertions(+), 38 deletions(-) Reviewed-by: Greg Kroah-Hartman