Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9722C48BE5 for ; Tue, 15 Jun 2021 18:04:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5D6F361042 for ; Tue, 15 Jun 2021 18:04:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D6F361042 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C80C66B006E; Tue, 15 Jun 2021 14:04:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C30F96B0073; Tue, 15 Jun 2021 14:04:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD1606B0074; Tue, 15 Jun 2021 14:04:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0004.hostedemail.com [216.40.44.4]) by kanga.kvack.org (Postfix) with ESMTP id 7B97F6B006E for ; Tue, 15 Jun 2021 14:04:54 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1FA758249980 for ; Tue, 15 Jun 2021 18:04:54 +0000 (UTC) X-FDA: 78256734108.19.1CB5B0C Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf15.hostedemail.com (Postfix) with ESMTP id 83D29A0001CF for ; Tue, 15 Jun 2021 18:04:49 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 4D4366109D; Tue, 15 Jun 2021 18:04:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623780292; bh=qHFj0jjHf8dwYggsbcjGlYx/b2OsiVOozqfbCFZaVmc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OapCdjtqQyic7adsNgbjRIy88KCh9pqicljwlmqMT3Wm5dHAgh96uE8MOIsXXSjBK 6FCsNCQkrtcw2EZNd4ASN+joL9NqRvf0Gwt2keeX/f7CFOwE9lVBXT792/MwwTTZaC FWDxjcM76zSgHS1LMTv7QeaHKXigJCRXvm2Dyu5c= Date: Tue, 15 Jun 2021 20:04:50 +0200 From: Greg Kroah-Hartman To: Christoph Hellwig Cc: Matthew Wilcox , Andrew Morton , Jan Kara , Al Viro , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] iomap: Use __set_page_dirty_nobuffers Message-ID: References: <20210615162342.1669332-1-willy@infradead.org> <20210615162342.1669332-4-willy@infradead.org> <20210615173453.GA2849@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210615173453.GA2849@lst.de> Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=OapCdjtq; spf=pass (imf15.hostedemail.com: domain of gregkh@linuxfoundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org X-Stat-Signature: 56p43p8x8wbjiukmoxjikxdpbnwhgrad X-Rspamd-Queue-Id: 83D29A0001CF X-Rspamd-Server: rspam06 X-HE-Tag: 1623780289-772629 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 15, 2021 at 07:34:53PM +0200, Christoph Hellwig wrote: > On Tue, Jun 15, 2021 at 06:32:37PM +0100, Matthew Wilcox wrote: > > On Tue, Jun 15, 2021 at 07:19:59PM +0200, Greg Kroah-Hartman wrote: > > > On Tue, Jun 15, 2021 at 05:23:39PM +0100, Matthew Wilcox (Oracle) wrote: > > > Using __ functions in structures in different modules feels odd to me. > > > Why not just have iomap_set_page_dirty be a #define to this function now > > > if you want to do this? > > > > > > Or take the __ off of the function name? > > > > > > Anyway, logic here is fine, but feels odd. > > > > heh, that was how I did it the first time. Then I thought that it was > > better to follow Christoph's patch: > > > > static const struct address_space_operations adfs_aops = { > > + .set_page_dirty = __set_page_dirty_buffers, > > (etc) > > Eventually everything around set_page_dirty should be changed to operate > on folios, and that will be a good time to come up with a sane > naming scheme without introducing extra churn. Ok, that's fine, I don't normally touch these files, so it's not an issue for me :)