Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D52EC4743C for ; Tue, 22 Jun 2021 00:07:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 53763611C1 for ; Tue, 22 Jun 2021 00:07:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229949AbhFVAKH (ORCPT ); Mon, 21 Jun 2021 20:10:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229640AbhFVAKH (ORCPT ); Mon, 21 Jun 2021 20:10:07 -0400 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55E78C061574 for ; Mon, 21 Jun 2021 17:07:52 -0700 (PDT) Received: by mail-pg1-x52b.google.com with SMTP id n12so6765322pgs.13 for ; Mon, 21 Jun 2021 17:07:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=cEZ2B0/VxjehmXDHG4+9ccmammhIbJj7C/0nukp4rN0=; b=TEZqtPQoDr5M/38Kdx4v+LTnR6iZmtN2PaeBsW34PV5K8OuwMaDRjodD+QhbC3g6wA c3rPjJK9VRM2TTgKzBz2/5MRrmVdO28n/pyBGMOtYpmDPWjF/LkXF0MIfPU+Guo/9+vc vs72ElzBPj6G2vfbZIddOiMpTQJofVM4dgFUM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cEZ2B0/VxjehmXDHG4+9ccmammhIbJj7C/0nukp4rN0=; b=qckeMA0e1n3aqfI8LXNldQ/eEJ22caDsU9YtLmNd4M6E/wVB1X7oJxDY3U4b+t+LUt xG1OQz9bTm0Sie9W4iWsFGqONdPYhuRlvsufynthfLa3EvAG4lyeMotzqrIJ0HSphu8Y MHbuwfyoW+WqUl0TfYO5Wrux/t98SYZClSZdjbqS9U+pSoiXU2V3298V8+D+VmUdQ+XZ b2gimqfPu9ghIZUkm6skIh4pzleOZN7wceNolgBhaKNSxQ8UhMNFbMmRus7dzyfzi/cD yz3IZsr+92JWv8Pe0l17Vty55iY0iJEFFVNZklqet5YlKWRK1URN05MG8Q9XIkUNe1Vm Y0EQ== X-Gm-Message-State: AOAM5314rDJt9TUGI63hC7H66bC2ZbNBvM9wouboF/mW6INRiMgoYifa ZOj3pobSgDvuWSwC1Esuzo/kbQ== X-Google-Smtp-Source: ABdhPJyIEERW8Z9bugjAaYkJE2XC+IsIIQNSIjl9wYtNA/TBpGkKu1694BD7NR/9teqcWiB6ZH8GXw== X-Received: by 2002:a63:2d46:: with SMTP id t67mr985871pgt.307.1624320471927; Mon, 21 Jun 2021 17:07:51 -0700 (PDT) Received: from localhost ([2620:15c:202:201:9f0f:4fd2:adeb:6f55]) by smtp.gmail.com with UTF8SMTPSA id cu4sm290845pjb.40.2021.06.21.17.07.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Jun 2021 17:07:51 -0700 (PDT) Date: Mon, 21 Jun 2021 17:07:50 -0700 From: Matthias Kaehlcke To: Mike Tipton Cc: djakov@kernel.org, bjorn.andersson@linaro.org, agross@kernel.org, okukatla@codeaurora.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] interconnect: qcom: icc-rpmh: Consolidate probe functions Message-ID: References: <20210621214241.13521-1-mdtipton@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210621214241.13521-1-mdtipton@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, Jun 21, 2021 at 02:42:41PM -0700, Mike Tipton wrote: > The current probe/remove functions are implemented separately for each > target, but they are almost identical. Replace them with common > functions that can be used across all rpmh targets. > > Signed-off-by: Mike Tipton Good catch, the code is indeed very redundant. Reviewed-by: Matthias Kaehlcke