Content-Type: multipart/mixed; boundary="===============3629433645501849243==" MIME-Version: 1.0 From: Boris Burkov To: kbuild-all@lists.01.org Subject: Re: [PATCH v5 2/3] btrfs: initial fsverity support Date: Wed, 30 Jun 2021 12:42:11 -0700 Message-ID: In-Reply-To: <202106260148.y7YIYV3M-lkp@intel.com> List-Id: --===============3629433645501849243== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Mon, Jun 28, 2021 at 11:23:51AM +0300, Dan Carpenter wrote: > Hi Boris, > = > url: https://github.com/0day-ci/linux/commits/Boris-Burkov/btrfs-suppo= rt-fsverity/20210625-064209 > base: https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git f= or-next > config: parisc-randconfig-m031-20210625 (attached as .config) > compiler: hppa-linux-gcc (GCC) 9.3.0 > = > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > Reported-by: Dan Carpenter > = > New smatch warnings: > fs/btrfs/verity.c:268 write_key_bytes() error: uninitialized symbol 'ret'. > fs/btrfs/verity.c:745 btrfs_write_merkle_tree_block() warn: should '1 << = log_blocksize' be a 64 bit type? good catch :) > = > Old smatch warnings: > fs/btrfs/verity.c:552 btrfs_begin_enable_verity() error: uninitialized sy= mbol 'trans'. This was a screw up from re-arranging the patches, will clean up. > = > vim +/ret +268 fs/btrfs/verity.c > = > 24749321fc3abc Boris Burkov 2021-06-24 209 static int write_key_bytes(s= truct btrfs_inode *inode, u8 key_type, u64 offset, > 24749321fc3abc Boris Burkov 2021-06-24 210 const char *src, u64 l= en) > 24749321fc3abc Boris Burkov 2021-06-24 211 { > 24749321fc3abc Boris Burkov 2021-06-24 212 struct btrfs_trans_handle *= trans; > 24749321fc3abc Boris Burkov 2021-06-24 213 struct btrfs_path *path; > 24749321fc3abc Boris Burkov 2021-06-24 214 struct btrfs_root *root =3D= inode->root; > 24749321fc3abc Boris Burkov 2021-06-24 215 struct extent_buffer *leaf; > 24749321fc3abc Boris Burkov 2021-06-24 216 struct btrfs_key key; > 24749321fc3abc Boris Burkov 2021-06-24 217 u64 copied =3D 0; > 24749321fc3abc Boris Burkov 2021-06-24 218 unsigned long copy_bytes; > 24749321fc3abc Boris Burkov 2021-06-24 219 unsigned long src_offset = =3D 0; > 24749321fc3abc Boris Burkov 2021-06-24 220 void *data; > 24749321fc3abc Boris Burkov 2021-06-24 221 int ret; > 24749321fc3abc Boris Burkov 2021-06-24 222 = > 24749321fc3abc Boris Burkov 2021-06-24 223 path =3D btrfs_alloc_path(); > 24749321fc3abc Boris Burkov 2021-06-24 224 if (!path) > 24749321fc3abc Boris Burkov 2021-06-24 225 return -ENOMEM; > 24749321fc3abc Boris Burkov 2021-06-24 226 = > 24749321fc3abc Boris Burkov 2021-06-24 227 while (len > 0) { > = > Can we write zero bytes? My test system has linux-next so I don't know. > I don't think the kbuild bot uses the cross function DB so it doesn't > know either. Considering the three callsites and then the callsite of end_enable_verity in fs/verity/enable.c, I don't think it's possible to call write_key_bytes with len=3D=3D0, but it doesn't hurt to fix it anyway, just in case. It makes write_key_bytes more correct as documented, at least. > = > 24749321fc3abc Boris Burkov 2021-06-24 228 /* > 24749321fc3abc Boris Burkov 2021-06-24 229 * 1 for the new item bein= g inserted > 24749321fc3abc Boris Burkov 2021-06-24 230 */ > 24749321fc3abc Boris Burkov 2021-06-24 231 trans =3D btrfs_start_tran= saction(root, 1); > 24749321fc3abc Boris Burkov 2021-06-24 232 if (IS_ERR(trans)) { > 24749321fc3abc Boris Burkov 2021-06-24 233 ret =3D PTR_ERR(trans); > 24749321fc3abc Boris Burkov 2021-06-24 234 break; > 24749321fc3abc Boris Burkov 2021-06-24 235 } > 24749321fc3abc Boris Burkov 2021-06-24 236 = > 24749321fc3abc Boris Burkov 2021-06-24 237 key.objectid =3D btrfs_ino= (inode); > 24749321fc3abc Boris Burkov 2021-06-24 238 key.type =3D key_type; > 24749321fc3abc Boris Burkov 2021-06-24 239 key.offset =3D offset; > 24749321fc3abc Boris Burkov 2021-06-24 240 = > 24749321fc3abc Boris Burkov 2021-06-24 241 /* > 24749321fc3abc Boris Burkov 2021-06-24 242 * Insert 2K at a time mos= tly to be friendly for smaller > 24749321fc3abc Boris Burkov 2021-06-24 243 * leaf size filesystems > 24749321fc3abc Boris Burkov 2021-06-24 244 */ > 24749321fc3abc Boris Burkov 2021-06-24 245 copy_bytes =3D min_t(u64, = len, 2048); > 24749321fc3abc Boris Burkov 2021-06-24 246 = > 24749321fc3abc Boris Burkov 2021-06-24 247 ret =3D btrfs_insert_empty= _item(trans, root, path, &key, copy_bytes); > 24749321fc3abc Boris Burkov 2021-06-24 248 if (ret) { > 24749321fc3abc Boris Burkov 2021-06-24 249 btrfs_end_transaction(tra= ns); > 24749321fc3abc Boris Burkov 2021-06-24 250 break; > 24749321fc3abc Boris Burkov 2021-06-24 251 } > 24749321fc3abc Boris Burkov 2021-06-24 252 = > 24749321fc3abc Boris Burkov 2021-06-24 253 leaf =3D path->nodes[0]; > 24749321fc3abc Boris Burkov 2021-06-24 254 = > 24749321fc3abc Boris Burkov 2021-06-24 255 data =3D btrfs_item_ptr(le= af, path->slots[0], void); > 24749321fc3abc Boris Burkov 2021-06-24 256 write_extent_buffer(leaf, = src + src_offset, > 24749321fc3abc Boris Burkov 2021-06-24 257 (unsigned long)data,= copy_bytes); > 24749321fc3abc Boris Burkov 2021-06-24 258 offset +=3D copy_bytes; > 24749321fc3abc Boris Burkov 2021-06-24 259 src_offset +=3D copy_bytes; > 24749321fc3abc Boris Burkov 2021-06-24 260 len -=3D copy_bytes; > 24749321fc3abc Boris Burkov 2021-06-24 261 copied +=3D copy_bytes; > 24749321fc3abc Boris Burkov 2021-06-24 262 = > 24749321fc3abc Boris Burkov 2021-06-24 263 btrfs_release_path(path); > 24749321fc3abc Boris Burkov 2021-06-24 264 btrfs_end_transaction(tran= s); > 24749321fc3abc Boris Burkov 2021-06-24 265 } > 24749321fc3abc Boris Burkov 2021-06-24 266 = > 24749321fc3abc Boris Burkov 2021-06-24 267 btrfs_free_path(path); > 24749321fc3abc Boris Burkov 2021-06-24 @268 return ret; > 24749321fc3abc Boris Burkov 2021-06-24 269 } > = > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org >=20 --===============3629433645501849243==--