Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C0E5C11F65 for ; Wed, 30 Jun 2021 20:03:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0EF8E61429 for ; Wed, 30 Jun 2021 20:03:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234034AbhF3UFv (ORCPT ); Wed, 30 Jun 2021 16:05:51 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:35330 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233693AbhF3UFu (ORCPT ); Wed, 30 Jun 2021 16:05:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=YKMhRboh+lKze4+WuoZJxqXVfSKTDuhGeZI4lldCD3I=; b=B2 g5ekKiuufadZ7g9B/g7TPSdKWdoYs0+gegQ31z2Y0P+qvA/kaf6Umg+Odmno39uka24QsHIlIhgpw SZMVYUxSQ1qV1cZ44/RYFiHuR98n2dJ9psm7y7E36WImIQ2FzUYYD0r+m1R3tIM3tup9NjFwQDxKp PgQZB9s9ugNKsuw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1lygQa-00Bh5e-Fs; Wed, 30 Jun 2021 22:03:20 +0200 Date: Wed, 30 Jun 2021 22:03:20 +0200 From: Andrew Lunn To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: netdev@vger.kernel.org, Vivien Didelot , "David S . Miller" , Jakub Kicinski Subject: Re: [PATCH net 2/6] net: dsa: mv88e6xxx: use correct .stats_set_histogram() on Topaz Message-ID: References: <20210630174308.31831-1-kabel@kernel.org> <20210630174308.31831-3-kabel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210630174308.31831-3-kabel@kernel.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jun 30, 2021 at 07:43:04PM +0200, Marek Behún wrote: > Commit 40cff8fca9e3 ("net: dsa: mv88e6xxx: Fix stats histogram mode") > introduced wrong .stats_set_histogram() method for Topaz family. > > The Peridot method should be used instead. > > Signed-off-by: Marek Behún > Fixes: 40cff8fca9e3 ("net: dsa: mv88e6xxx: Fix stats histogram mode") Reviewed-by: Andrew Lunn Andrew