Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADC27C4338F for ; Sun, 25 Jul 2021 20:03:36 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43D6660E78 for ; Sun, 25 Jul 2021 20:03:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 43D6660E78 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2E57F6E4AA; Sun, 25 Jul 2021 20:03:35 +0000 (UTC) Received: from mx2.smtp.larsendata.com (mx2.smtp.larsendata.com [91.221.196.228]) by gabe.freedesktop.org (Postfix) with ESMTPS id CC4F86E4AA for ; Sun, 25 Jul 2021 20:03:32 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx2.smtp.larsendata.com (Halon) with ESMTPS id 6bf0807c-ed83-11eb-8d1a-0050568cd888; Sun, 25 Jul 2021 20:03:47 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id 34693194B04; Sun, 25 Jul 2021 22:03:50 +0200 (CEST) Date: Sun, 25 Jul 2021 22:03:29 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Thomas Zimmermann Subject: Re: [PATCH v2 5/5] drm/vkms: Map output framebuffer BOs with drm_gem_fb_vmap() Message-ID: References: <20210725174438.24493-1-tzimmermann@suse.de> <20210725174438.24493-6-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210725174438.24493-6-tzimmermann@suse.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: hamohammed.sa@gmail.com, rodrigosiqueiramelo@gmail.com, airlied@linux.ie, melissa.srw@gmail.com, noralf@tronnes.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, Jul 25, 2021 at 07:44:38PM +0200, Thomas Zimmermann wrote: > Abstract the framebuffer details by mappings its BOs with a call > to drm_gem_fb_vmap(). Unmap with drm_gem_fb_vunamp(). > > Before, the output address with stored as raw pointer in the priv > field of struct drm_writeback_job. Introduce the new type > struct vkms_writeback_job, which holds the output mappings addresses > while the writeback job is active. > > The patchset also cleans up some internal casting an setup of the > output addresses. No functional changes. > > Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg > --- > drivers/gpu/drm/vkms/vkms_composer.c | 2 +- > drivers/gpu/drm/vkms/vkms_drv.h | 6 +++++- > drivers/gpu/drm/vkms/vkms_writeback.c | 21 ++++++++++----------- > 3 files changed, 16 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b/drivers/gpu/drm/vkms/vkms_composer.c > index ead8fff81f30..49f109c3a2b3 100644 > --- a/drivers/gpu/drm/vkms/vkms_composer.c > +++ b/drivers/gpu/drm/vkms/vkms_composer.c > @@ -257,7 +257,7 @@ void vkms_composer_worker(struct work_struct *work) > return; > > if (wb_pending) > - vaddr_out = crtc_state->active_writeback; > + vaddr_out = crtc_state->active_writeback->map[0].vaddr; > > ret = compose_active_planes(&vaddr_out, primary_composer, > crtc_state); > diff --git a/drivers/gpu/drm/vkms/vkms_drv.h b/drivers/gpu/drm/vkms/vkms_drv.h > index 8c731b6dcba7..8bc9e3f52e1f 100644 > --- a/drivers/gpu/drm/vkms/vkms_drv.h > +++ b/drivers/gpu/drm/vkms/vkms_drv.h > @@ -20,6 +20,10 @@ > #define XRES_MAX 8192 > #define YRES_MAX 8192 > > +struct vkms_writeback_job { > + struct dma_buf_map map[DRM_FORMAT_MAX_PLANES]; > +}; > + > struct vkms_composer { > struct drm_framebuffer fb; > struct drm_rect src, dst; > @@ -57,7 +61,7 @@ struct vkms_crtc_state { > int num_active_planes; > /* stack of active planes for crc computation, should be in z order */ > struct vkms_plane_state **active_planes; > - void *active_writeback; > + struct vkms_writeback_job *active_writeback; > > /* below four are protected by vkms_output.composer_lock */ > bool crc_pending; > diff --git a/drivers/gpu/drm/vkms/vkms_writeback.c b/drivers/gpu/drm/vkms/vkms_writeback.c > index 0935686475a0..765bb85ba76c 100644 > --- a/drivers/gpu/drm/vkms/vkms_writeback.c > +++ b/drivers/gpu/drm/vkms/vkms_writeback.c > @@ -65,21 +65,23 @@ static int vkms_wb_connector_get_modes(struct drm_connector *connector) > static int vkms_wb_prepare_job(struct drm_writeback_connector *wb_connector, > struct drm_writeback_job *job) > { > - struct drm_gem_object *gem_obj; > - struct dma_buf_map map; > + struct vkms_writeback_job *vkmsjob; > int ret; > > if (!job->fb) > return 0; > > - gem_obj = drm_gem_fb_get_obj(job->fb, 0); > - ret = drm_gem_shmem_vmap(gem_obj, &map); > + vkmsjob = kzalloc(sizeof(*vkmsjob), GFP_KERNEL); > + if (!vkmsjob) > + return -ENOMEM; > + > + ret = drm_gem_fb_vmap(job->fb, vkmsjob->map); > if (ret) { > DRM_ERROR("vmap failed: %d\n", ret); > return ret; > } > > - job->priv = map.vaddr; > + job->priv = vkmsjob; > > return 0; > } > @@ -87,18 +89,15 @@ static int vkms_wb_prepare_job(struct drm_writeback_connector *wb_connector, > static void vkms_wb_cleanup_job(struct drm_writeback_connector *connector, > struct drm_writeback_job *job) > { > - struct drm_gem_object *gem_obj; > + struct vkms_writeback_job *vkmsjob = job->priv; > struct vkms_device *vkmsdev; > - struct dma_buf_map map; > > if (!job->fb) > return; > > - gem_obj = drm_gem_fb_get_obj(job->fb, 0); > - dma_buf_map_set_vaddr(&map, job->priv); > - drm_gem_shmem_vunmap(gem_obj, &map); > + drm_gem_fb_vunmap(job->fb, vkmsjob->map); > > - vkmsdev = drm_device_to_vkms_device(gem_obj->dev); > + vkmsdev = drm_device_to_vkms_device(job->fb->dev); > vkms_set_composer(&vkmsdev->output, false); > } > > -- > 2.32.0