Content-Type: multipart/mixed; boundary="===============5163007609991111130==" MIME-Version: 1.0 From: Peter Xu To: kbuild-all@lists.01.org Subject: Re: [RFC PATCH] mm/hugetlb: __unmap_hugepage_range() can be static Date: Thu, 15 Jul 2021 14:53:04 -0400 Message-ID: In-Reply-To: <20210715170524.GA48547@78ef4ef0cd6c> List-Id: --===============5163007609991111130== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Fri, Jul 16, 2021 at 01:05:24AM +0800, kernel test robot wrote: > mm/hugetlb.c:4334:6: warning: symbol '__unmap_hugepage_range' was not dec= lared. Should it be static? > = > Reported-by: kernel test robot > Signed-off-by: kernel test robot > --- > hugetlb.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > = > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 924553aa8f789ad..4bdd637b0c29a95 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -4331,9 +4331,9 @@ int copy_hugetlb_page_range(struct mm_struct *dst, = struct mm_struct *src, > return ret; > } > = > -void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struc= t *vma, > - unsigned long start, unsigned long end, > - struct page *ref_page) > +static void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_are= a_struct *vma, > + unsigned long start, unsigned long end, > + struct page *ref_page) > { > struct mm_struct *mm =3D vma->vm_mm; > unsigned long address; Will squash this change into the patch. Thanks. -- = Peter Xu --===============5163007609991111130==--