Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0302BC12002 for ; Fri, 16 Jul 2021 10:50:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C15DF613F8 for ; Fri, 16 Jul 2021 10:50:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C15DF613F8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m4LQQ-0007AC-RY for qemu-devel@archiver.kernel.org; Fri, 16 Jul 2021 06:50:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55586) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4LPQ-0006O6-Qp for qemu-devel@nongnu.org; Fri, 16 Jul 2021 06:49:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:58776) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4LPO-0006sC-N5 for qemu-devel@nongnu.org; Fri, 16 Jul 2021 06:49:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626432570; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yGX7fwEXDvKVQAA/yP+7bpZvvaoex1L9wip9+nmmWcA=; b=ii3BV/LiMaLKugtzqyraM3tAopwyCb4GA8s1Z4Fiz8q9kX2NaqufRUyghdcrBedCAIEc8M I5KaRpzFCJXfTQQoZn8+iLRsXbFGdYv8LgBfU7SDvYGlobroTSRjQhB3wLsqAa2Y4RH4aD 2uihtxVC6JHIqBHw9z9GcLMXF6Dvm/Y= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-584-KBLQuKKSMVmJHbvNFMiMWQ-1; Fri, 16 Jul 2021 06:49:20 -0400 X-MC-Unique: KBLQuKKSMVmJHbvNFMiMWQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3D5A31922965; Fri, 16 Jul 2021 10:49:19 +0000 (UTC) Received: from redhat.com (ovpn-115-37.ams2.redhat.com [10.36.115.37]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0615619C45; Fri, 16 Jul 2021 10:49:12 +0000 (UTC) Date: Fri, 16 Jul 2021 11:49:09 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Cornelia Huck Subject: Re: [PATCH v1 2/9] s390x: toplogy: adding drawers and books to smp parsing Message-ID: References: <1626281596-31061-1-git-send-email-pmorel@linux.ibm.com> <1626281596-31061-3-git-send-email-pmorel@linux.ibm.com> <87y2a8cda7.fsf@dusky.pond.sub.org> <0801e122-0e9c-e266-42e8-d5cddb16c237@linux.ibm.com> <87bl73df9y.fsf@dusky.pond.sub.org> <87y2a6bp5f.fsf@redhat.com> <87pmvibkri.fsf@redhat.com> MIME-Version: 1.0 In-Reply-To: <87pmvibkri.fsf@redhat.com> User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: thuth@redhat.com, ehabkost@redhat.com, Pierre Morel , david@redhat.com, richard.henderson@linaro.org, Markus Armbruster , qemu-devel@nongnu.org, pasic@linux.ibm.com, borntraeger@de.ibm.com, qemu-s390x@nongnu.org, pbonzini@redhat.com, eblake@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Jul 16, 2021 at 12:44:49PM +0200, Cornelia Huck wrote: > On Fri, Jul 16 2021, Daniel P. Berrangé wrote: > > > On Fri, Jul 16, 2021 at 11:10:04AM +0200, Cornelia Huck wrote: > >> On Thu, Jul 15 2021, Markus Armbruster wrote: > >> > >> > Pierre Morel writes: > >> > > >> >> On 7/15/21 8:16 AM, Markus Armbruster wrote: > >> >>> Pierre Morel writes: > >> >>> > >> >>>> Drawers and Books are levels 4 and 3 of the S390 CPU > >> >>>> topology. > >> >>>> We allow the user to define these levels and we will > >> >>>> store the values inside the S390CcwMachineState. > >> >>> > >> >>> Double-checking: are these members specific to S390? > >> >> > >> >> Yes AFAIK > >> > > >> > Makes me wonder whether they should be conditional on TARGET_S390X. > >> > > >> > What happens when you specify them for another target? Silently > >> > ignored, or error? > >> > >> I'm wondering whether we should include them in the base machine state > >> and treat them as we treat 'dies' (i.e. the standard parser errors out > >> if they are set, and only the s390x parser supports them.) > > > > To repeat what i just wrote in my reply to patch 1, I think we ought to > > think about a different approach to handling the usage constraints, > > which doesn't require full re-implementation of the smp_parse method > > each time. There should be a way for each target to report topology > > constraints, such the the single smp_parse method can do the right > > thing, especially wrt error reporting for unsupported values. > > That would mean that all possible fields would need to go into common > code, right? Yes, that is an implication of what i'm suggesting. > I'm wondering whether there are more architecture/cpu specific values > lurking in the corner, it would get unwieldy if we need to go beyond the > existing fields and drawers/books. Is the book/drawer thing architecture specific, or is it machine type / CPU specific. ie do /all/ the s390x machine types / CPUS QEMU support the book/drawer concept, or only a subset. If only a subset, then restricting it per target on QAPI doesn't fully solve the root problem, and we instead are better focusing on accurate runtime error reporting. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|