Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6659C07E95 for ; Fri, 16 Jul 2021 16:23:52 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8611F61374 for ; Fri, 16 Jul 2021 16:23:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8611F61374 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.157647.290332 (Exim 4.92) (envelope-from ) id 1m4Qcn-0006FE-8j; Fri, 16 Jul 2021 16:23:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 157647.290332; Fri, 16 Jul 2021 16:23:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m4Qcn-0006F7-5P; Fri, 16 Jul 2021 16:23:41 +0000 Received: by outflank-mailman (input) for mailman id 157647; Fri, 16 Jul 2021 16:23:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m4Qcl-0006F1-A5 for xen-devel@lists.xenproject.org; Fri, 16 Jul 2021 16:23:39 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 43c67b32-4551-4bce-a007-7dd082171dd8; Fri, 16 Jul 2021 16:23:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43c67b32-4551-4bce-a007-7dd082171dd8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626452618; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=B3tE4f57NelE1LohuNJ9hG9uHNWiBTNxUFDOpF+Jmms=; b=XQ6mez6m58dau3goYbFiHILUqu8O6mcmruDgErEkSL5bY95fM0X4DQsp 2JuZzWKTSGP6UHhUkT9oo5l53DMug26ovnhr32BnTfvv2IYuhLoqmD35H BETbqVMgswQceUdGosrdfgn4aPfXdURoCfyCHJlEWeeD4QQ94B7Xmbx+y Y=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: zq2UcFMgoXyXVKIlxFtAFNbALSi2BQIXdlWQ+t6wicQdwSIJMEuigrGPi8fpXC5ZDfWkLaKPeL mjt2RGR267CXG7F4zE8kZHrIBIYnMmNGq0bbptxn69UZSMwsOom2ixpO9eJQbN0+d+n/6rSOVa elyM6HOVWJWqLyrrt+5qMFy/rH04YHk5WZjKxmQI68IyW4EOMLn4zmMMLlK0tLerJJrUKoL671 EwebFX6++BTNdgg4OV8GshR7cYZ2WCL5Qga/efsU4O7O43nE+4wLY5WSMdan00egPp+a19Tg4z k1I= X-SBRS: 5.1 X-MesageID: 48145624 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:z1oXmK0j/hYXLB0JHdLMSQqjBIokLtp133Aq2lEZdPRUGvb4qy mLpoV96faSskd2ZJhAo6HlBEDuex/hHPJOjrX5eI3SJTUO21HYSb2Kj7GSoAEIcheWnoU2uJ uIMZIOauEYZWIK9foSizPZLz9P+re6zJw= X-IronPort-AV: E=Sophos;i="5.84,245,1620705600"; d="scan'208";a="48145624" Date: Fri, 16 Jul 2021 17:23:33 +0100 From: Anthony PERARD To: Andrew Cooper CC: Jan Beulich , George Dunlap , Ian Jackson , Julien Grall , "Stefano Stabellini" , Wei Liu , Subject: Re: [XEN PATCH] xen: allow XSM_FLASK_POLICY only if checkpolicy binary is available Message-ID: References: <20210714161734.256246-1-anthony.perard@citrix.com> <17a250d3-1c1b-f079-c950-5590975e56ae@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <17a250d3-1c1b-f079-c950-5590975e56ae@citrix.com> On Fri, Jul 16, 2021 at 02:15:28PM +0100, Andrew Cooper wrote: > On 15/07/2021 07:25, Jan Beulich wrote: > > On 14.07.2021 18:17, Anthony PERARD wrote: > >> --- a/xen/common/Kconfig > >> +++ b/xen/common/Kconfig > >> @@ -25,6 +25,9 @@ config GRANT_TABLE > >> config HAS_ALTERNATIVE > >> bool > >> > >> +config HAS_CHECKPOLICY > >> + def_bool $(success,$(CHECKPOLICY) -h 2>&1 | grep -q xen) > >> + > > This is no different from other aspects of "Kconfig vs tool chain > > capabilities" sent out last August to start a discussion about > > whether we really want such. Besides Jürgen no-one cared to reply > > iirc, which to me means no-one really cares one way or the other. > > You know full well that upgrading Kconfig was specifically to be able to > use this functionality, and you know full well that I firmly support To be honest, I've upgraded Kconfig mostly because I needed to start somewhere with upgrading our build system to look more like Kbuild. I may have adding `CC --version` and some other CONFIG_* running shells, but I don't think anymore that is a necessary things to do, it just look cleaner. > using this mechanism, because we've had both of these arguments several > times before. I'd like to read about your (or someone else's) arguments in favor of doing more in Kconfig only, do you have links (or maybe subject, keyword) to look at? I think I understand Jan's arguments. Cheers, -- Anthony PERARD